2018-05-15 21:19:17

by Valdis Klētnieks

[permalink] [raw]
Subject: linux-next 20180515 - ACPI disabled..

Seeing this at boot with linux-next 20180415. ACPI gets disabled, hilarity and hijinks
result - everything from a lot of stuff can't find an IRQ to the dual-core w/ HT CPU
coming up as just 1 core no HT. 20180430 works just fine...

[ 0.000000] ACPI: Early table checksum verification disabled
[ 0.000000] ACPI: RSDP 0x00000000CB7F1000 000024 (v02 DELL )
[ 0.000000] ACPI: XSDT 0x00000000CB7F1088 000094 (v01 DELL CBX3 01072009 AMI 00010013)
[ 0.000000] ACPI: FACP 0x00000000CB7FB720 00010C (v05 DELL CBX3 01072009 AMI 00010013)
[ 0.000000] ACPI: DSDT 0x00000000CB7F11B0 00A56F (v02 DELL CBX3 00000021 INTL 20091112)
[ 0.000000] ACPI: FACS 0x00000000CCFED080 000040
[ 0.000000] ACPI: APIC 0x00000000CB7FB830 000072 (v03 DELL CBX3 01072009 AMI 00010013)
[ 0.000000] ACPI: FPDT 0x00000000CB7FB8A8 000044 (v01 DELL CBX3 01072009 AMI 00010013)
[ 0.000000] ACPI: TCPA 0x00000000CB7FB8F0 000032 (v02 APTIO4 NAPAASF 00000001 MSFT 01000013)
[ 0.000000] ACPI: MCFG 0x00000000CB7FB928 00003C (v01 DELL CBX3 01072009 MSFT 00000097)
[ 0.000000] ACPI: HPET 0x00000000CB7FB968 000038 (v01 DELL CBX3 01072009 AMI. 00000005)
[ 0.000000] ACPI: SSDT 0x00000000CB7FB9A0 000415 (v01 SataRe SataTabl 00001000 INTL 20091112)
[ 0.000000] ACPI: SSDT 0x00000000CB7FBDB8 0009B9 (v01 PmRef Cpu0Ist 00003000 INTL 20051117)
[ 0.000000] ACPI: SSDT 0x00000000CB7FC778 000B22 (v01 PmRef CpuPm 00003000 INTL 20051117)
[ 0.000000] ACPI: DMAR 0x00000000CB7FD2A0 000080 (v01 INTEL SNB 00000001 INTL 00000001)
[ 0.000000] ACPI: ASF! 0x00000000CB7FD320 0000A5 (v32 INTEL HCG 00000001 TFSM 000F4240)
[ 0.000000] ACPI: SSDT 0x00000000CB7FD3C8 000579 (v01 AMITCG PROC 00000001 INTL 20051117)
[ 0.000000] ACPI: BGRT 0x00000000CB7FD948 000038 (v00 ?? 01072009 AMI 00010013)
[ 0.000000] ACPI: SSDT 0x00000000CB7FD980 00198A (v01 NvdRef NvdTabl 00001000 INTL 20091112)
[ 0.000000] ACPI: Local APIC address 0xfee00000
[ 0.000000] ACPI: [APIC:0x05] Invalid zero length
[ 0.000000] ACPI: Error parsing LAPIC address override entry
[ 0.000000] ACPI: Invalid BIOS MADT, disabling ACPI
[ 0.000000] tsc: Fast TSC calibration using PIT

On next-20180430, the boot goes like this, and continues properly:

[ 0.000000] ACPI: SSDT 0x00000000CB7FD980 00198A (v01 NvdRef NvdTabl 00001000 INTL 20091112)
[ 0.000000] ACPI: Local APIC address 0xfee00000
[ 0.000000] tsc: Fast TSC calibration using PIT

Not seeing any commits to drivers/acpi/tables.c other than Al Stone's.

This ringing any bells before I go bisecting?


Attachments:
(No filename) (497.00 B)

2018-05-15 21:24:45

by Andy Shevchenko

[permalink] [raw]
Subject: Re: linux-next 20180515 - ACPI disabled..

+Cc: Rafael

On Wed, May 16, 2018 at 12:18 AM, <[email protected]> wrote:
> Seeing this at boot with linux-next 20180415. ACPI gets disabled, hilarity and hijinks
> result - everything from a lot of stuff can't find an IRQ to the dual-core w/ HT CPU
> coming up as just 1 core no HT. 20180430 works just fine...
>
> [ 0.000000] ACPI: Early table checksum verification disabled
> [ 0.000000] ACPI: RSDP 0x00000000CB7F1000 000024 (v02 DELL )
> [ 0.000000] ACPI: XSDT 0x00000000CB7F1088 000094 (v01 DELL CBX3 01072009 AMI 00010013)
> [ 0.000000] ACPI: FACP 0x00000000CB7FB720 00010C (v05 DELL CBX3 01072009 AMI 00010013)
> [ 0.000000] ACPI: DSDT 0x00000000CB7F11B0 00A56F (v02 DELL CBX3 00000021 INTL 20091112)
> [ 0.000000] ACPI: FACS 0x00000000CCFED080 000040
> [ 0.000000] ACPI: APIC 0x00000000CB7FB830 000072 (v03 DELL CBX3 01072009 AMI 00010013)
> [ 0.000000] ACPI: FPDT 0x00000000CB7FB8A8 000044 (v01 DELL CBX3 01072009 AMI 00010013)
> [ 0.000000] ACPI: TCPA 0x00000000CB7FB8F0 000032 (v02 APTIO4 NAPAASF 00000001 MSFT 01000013)
> [ 0.000000] ACPI: MCFG 0x00000000CB7FB928 00003C (v01 DELL CBX3 01072009 MSFT 00000097)
> [ 0.000000] ACPI: HPET 0x00000000CB7FB968 000038 (v01 DELL CBX3 01072009 AMI. 00000005)
> [ 0.000000] ACPI: SSDT 0x00000000CB7FB9A0 000415 (v01 SataRe SataTabl 00001000 INTL 20091112)
> [ 0.000000] ACPI: SSDT 0x00000000CB7FBDB8 0009B9 (v01 PmRef Cpu0Ist 00003000 INTL 20051117)
> [ 0.000000] ACPI: SSDT 0x00000000CB7FC778 000B22 (v01 PmRef CpuPm 00003000 INTL 20051117)
> [ 0.000000] ACPI: DMAR 0x00000000CB7FD2A0 000080 (v01 INTEL SNB 00000001 INTL 00000001)
> [ 0.000000] ACPI: ASF! 0x00000000CB7FD320 0000A5 (v32 INTEL HCG 00000001 TFSM 000F4240)
> [ 0.000000] ACPI: SSDT 0x00000000CB7FD3C8 000579 (v01 AMITCG PROC 00000001 INTL 20051117)
> [ 0.000000] ACPI: BGRT 0x00000000CB7FD948 000038 (v00 ?? 01072009 AMI 00010013)
> [ 0.000000] ACPI: SSDT 0x00000000CB7FD980 00198A (v01 NvdRef NvdTabl 00001000 INTL 20091112)
> [ 0.000000] ACPI: Local APIC address 0xfee00000
> [ 0.000000] ACPI: [APIC:0x05] Invalid zero length
> [ 0.000000] ACPI: Error parsing LAPIC address override entry
> [ 0.000000] ACPI: Invalid BIOS MADT, disabling ACPI
> [ 0.000000] tsc: Fast TSC calibration using PIT
>
> On next-20180430, the boot goes like this, and continues properly:
>
> [ 0.000000] ACPI: SSDT 0x00000000CB7FD980 00198A (v01 NvdRef NvdTabl 00001000 INTL 20091112)
> [ 0.000000] ACPI: Local APIC address 0xfee00000
> [ 0.000000] tsc: Fast TSC calibration using PIT
>
> Not seeing any commits to drivers/acpi/tables.c other than Al Stone's.
>
> This ringing any bells before I go bisecting?
>



--
With Best Regards,
Andy Shevchenko

2018-05-15 21:50:16

by Al Stone

[permalink] [raw]
Subject: Re: linux-next 20180515 - ACPI disabled..

On 05/15/2018 03:23 PM, Andy Shevchenko wrote:
> +Cc: Rafael
>
> On Wed, May 16, 2018 at 12:18 AM, <[email protected]> wrote:
>> Seeing this at boot with linux-next 20180415. ACPI gets disabled, hilarity and hijinks
>> result - everything from a lot of stuff can't find an IRQ to the dual-core w/ HT CPU
>> coming up as just 1 core no HT. 20180430 works just fine...
>>
>> [ 0.000000] ACPI: Early table checksum verification disabled
>> [ 0.000000] ACPI: RSDP 0x00000000CB7F1000 000024 (v02 DELL )
>> [ 0.000000] ACPI: XSDT 0x00000000CB7F1088 000094 (v01 DELL CBX3 01072009 AMI 00010013)
>> [ 0.000000] ACPI: FACP 0x00000000CB7FB720 00010C (v05 DELL CBX3 01072009 AMI 00010013)
>> [ 0.000000] ACPI: DSDT 0x00000000CB7F11B0 00A56F (v02 DELL CBX3 00000021 INTL 20091112)
>> [ 0.000000] ACPI: FACS 0x00000000CCFED080 000040
>> [ 0.000000] ACPI: APIC 0x00000000CB7FB830 000072 (v03 DELL CBX3 01072009 AMI 00010013)
>> [ 0.000000] ACPI: FPDT 0x00000000CB7FB8A8 000044 (v01 DELL CBX3 01072009 AMI 00010013)
>> [ 0.000000] ACPI: TCPA 0x00000000CB7FB8F0 000032 (v02 APTIO4 NAPAASF 00000001 MSFT 01000013)
>> [ 0.000000] ACPI: MCFG 0x00000000CB7FB928 00003C (v01 DELL CBX3 01072009 MSFT 00000097)
>> [ 0.000000] ACPI: HPET 0x00000000CB7FB968 000038 (v01 DELL CBX3 01072009 AMI. 00000005)
>> [ 0.000000] ACPI: SSDT 0x00000000CB7FB9A0 000415 (v01 SataRe SataTabl 00001000 INTL 20091112)
>> [ 0.000000] ACPI: SSDT 0x00000000CB7FBDB8 0009B9 (v01 PmRef Cpu0Ist 00003000 INTL 20051117)
>> [ 0.000000] ACPI: SSDT 0x00000000CB7FC778 000B22 (v01 PmRef CpuPm 00003000 INTL 20051117)
>> [ 0.000000] ACPI: DMAR 0x00000000CB7FD2A0 000080 (v01 INTEL SNB 00000001 INTL 00000001)
>> [ 0.000000] ACPI: ASF! 0x00000000CB7FD320 0000A5 (v32 INTEL HCG 00000001 TFSM 000F4240)
>> [ 0.000000] ACPI: SSDT 0x00000000CB7FD3C8 000579 (v01 AMITCG PROC 00000001 INTL 20051117)
>> [ 0.000000] ACPI: BGRT 0x00000000CB7FD948 000038 (v00 ?? 01072009 AMI 00010013)
>> [ 0.000000] ACPI: SSDT 0x00000000CB7FD980 00198A (v01 NvdRef NvdTabl 00001000 INTL 20091112)
>> [ 0.000000] ACPI: Local APIC address 0xfee00000
>> [ 0.000000] ACPI: [APIC:0x05] Invalid zero length
>> [ 0.000000] ACPI: Error parsing LAPIC address override entry
>> [ 0.000000] ACPI: Invalid BIOS MADT, disabling ACPI
>> [ 0.000000] tsc: Fast TSC calibration using PIT
>>
>> On next-20180430, the boot goes like this, and continues properly:
>>
>> [ 0.000000] ACPI: SSDT 0x00000000CB7FD980 00198A (v01 NvdRef NvdTabl 00001000 INTL 20091112)
>> [ 0.000000] ACPI: Local APIC address 0xfee00000
>> [ 0.000000] tsc: Fast TSC calibration using PIT
>>
>> Not seeing any commits to drivers/acpi/tables.c other than Al Stone's.
>>
>> This ringing any bells before I go bisecting?
>>
>
>
>

Not off-hand. Could you please send me a copy of /sys/firmware/acpi/tables/APIC
on this machine? The commit cd8c65a6442b that I wrote looks like it got pulled
in on 20180430, which if I'm understanding correctly, seems to have fixed the
problem. Did this work before 20180415? I assume it did.

What puzzles me is that this message:

ACPI: [APIC:0x05] Invalid zero length

should only have shown up if the MADT has a broken subtable, and I think that
bit of code has been that way for quite some time (git blame says somewhere
around 2012 when the test for this condition was put in).

--
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Red Hat, Inc.
[email protected]
-----------------------------------

2018-05-15 22:26:18

by Valdis Klētnieks

[permalink] [raw]
Subject: Re: linux-next 20180515 - ACPI disabled..

On Tue, 15 May 2018 15:49:15 -0600, Al Stone said:

> Not off-hand. Could you please send me a copy of /sys/firmware/acpi/tables/APIC

cat /sys/firmware/acpi/tables/APIC | od -x
0000000 5041 4349 0072 0000 3903 4544 4c4c 2020
0000020 4243 3358 2020 0020 2009 0107 4d41 2049
0000040 0013 0001 0000 fee0 0001 0000 0800 0001
0000060 0001 0000 0800 0202 0001 0000 0800 0103
0000100 0001 0000 0800 0304 0001 0000 0c01 0002
0000120 0000 fec0 0000 0000 0a02 0000 0002 0000
0000140 0000 0a02 0900 0009 0000 000d 0604 05ff
0000160 0100
0000162

> on this machine? The commit cd8c65a6442b that I wrote looks like it got pulled
> in on 20180430, which if I'm understanding correctly, seems to have fixed the
> problem. Did this work before 20180415? I assume it did.

0430 is what I'm running right ow, and it works. Everything before that too.
It fell over sometime between 0430 and 0515,

> What puzzles me is that this message:
>
> ACPI: [APIC:0x05] Invalid zero length
>
> should only have shown up if the MADT has a broken subtable, and I think that
> bit of code has been that way for quite some time (git blame says somewhere
> around 2012 when the test for this condition was put in).


Attachments:
(No filename) (497.00 B)

2018-05-15 22:40:45

by Al Stone

[permalink] [raw]
Subject: Re: linux-next 20180515 - ACPI disabled..

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 05/15/2018 04:25 PM, [email protected] wrote:
> On Tue, 15 May 2018 15:49:15 -0600, Al Stone said:
>
>> Not off-hand. Could you please send me a copy of
>> /sys/firmware/acpi/tables/APIC
>
> cat /sys/firmware/acpi/tables/APIC | od -x 0000000 5041 4349 0072 0000
> 3903 4544 4c4c 2020 0000020 4243 3358 2020 0020 2009 0107 4d41 2049 0000040
> 0013 0001 0000 fee0 0001 0000 0800 0001 0000060 0001 0000 0800 0202 0001
> 0000 0800 0103 0000100 0001 0000 0800 0304 0001 0000 0c01 0002 0000120 0000
> fec0 0000 0000 0a02 0000 0002 0000 0000140 0000 0a02 0900 0009 0000 000d
> 0604 05ff 0000160 0100 0000162

Thanks.

>> on this machine? The commit cd8c65a6442b that I wrote looks like it got
>> pulled in on 20180430, which if I'm understanding correctly, seems to
>> have fixed the problem. Did this work before 20180415? I assume it
>> did.
>
> 0430 is what I'm running right ow, and it works. Everything before that
> too. It fell over sometime between 0430 and 0515,

Oh, I see. I had read "0515" as "0415", hence my confusion.

- --
ciao,
al
- -----------------------------------
Al Stone
Software Engineer
Red Hat, Inc.
[email protected]
- -----------------------------------
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEiclaKI7ZGQ+4GJLWUwywAtdhsWwFAlr7Yb0ACgkQUwywAtdh
sWwshQ//XvOPtjH5kB/OHR0jGP5LQ+9iiyJa40P6UhsW4dTFZbWLWOvhzqrdBJD2
dyA7Xz3ig4zULS1ZAmIpubMixgekGa9VaMtJMumw4CiwqkuphLNnB6gFqZ5QkWS4
YyGwW6zz2RSONf5Lq3K65mr+6cDHMhdtidtEunXzMOC6Ny8ELC52hIr295NpnyXn
sv72SVdy9kQYHfxRv7K1IIbMKJZYRBN3TCoWFFJHbJH0stiLnCk+O+57QcsCKNWH
ECJ6z8+kELo3BD42PLk7cRYoUKnyPsrGn+fAQvLD9rnknjVRPKhVjRilI9qr/HCo
pmj0N9xNcEI0WK2feyN3vzYPeZbzwsxIiiCwd9E+bQIrwq8nI+fbhV6egFZlbwcR
89w3Zhu31s7umcopLLHAEstm4STKOZGS54PdGQFku/Nff4GVes+vvjP1wC3yMEDL
kUeOt5tLWgexEMOdXqo9YaMz2AUeog2Duk1PL27EiHjc4eGbSt1Yb9SgRFln03rH
Orozfqjjwv6G4yWkz6sjZ/0T6ODWa+CW8qTr2WjFH2l2sj3ZT3DoemN4GkYo3O7x
oI+7lKoY31L+GQnKluW6EceliANVmLlgNhlQv5v9i9NYFrgwj8UucJfJVQdJWVKk
uJxhGITkkResHoPOfEuHsJ9Ks5wI22L6RiO9OTX2rr7accsA+aY=
=Vj8z
-----END PGP SIGNATURE-----

2018-05-16 11:59:27

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: linux-next 20180515 - ACPI disabled..

On Wednesday, May 16, 2018 12:25:30 AM CEST [email protected] wrote:
> On Tue, 15 May 2018 15:49:15 -0600, Al Stone said:
>
> > Not off-hand. Could you please send me a copy of /sys/firmware/acpi/tables/APIC
>
> cat /sys/firmware/acpi/tables/APIC | od -x
> 0000000 5041 4349 0072 0000 3903 4544 4c4c 2020
> 0000020 4243 3358 2020 0020 2009 0107 4d41 2049
> 0000040 0013 0001 0000 fee0 0001 0000 0800 0001
> 0000060 0001 0000 0800 0202 0001 0000 0800 0103
> 0000100 0001 0000 0800 0304 0001 0000 0c01 0002
> 0000120 0000 fec0 0000 0000 0a02 0000 0002 0000
> 0000140 0000 0a02 0900 0009 0000 000d 0604 05ff
> 0000160 0100
> 0000162
>
> > on this machine? The commit cd8c65a6442b that I wrote looks like it got pulled
> > in on 20180430, which if I'm understanding correctly, seems to have fixed the
> > problem. Did this work before 20180415? I assume it did.
>
> 0430 is what I'm running right ow, and it works. Everything before that too.
> It fell over sometime between 0430 and 0515,
>
> > What puzzles me is that this message:
> >
> > ACPI: [APIC:0x05] Invalid zero length
> >
> > should only have shown up if the MADT has a broken subtable, and I think that
> > bit of code has been that way for quite some time (git blame says somewhere
> > around 2012 when the test for this condition was put in).

There was one commit that I had to drop.

Please try linux-next tomorrow and let me know if it works for you.


2018-05-17 22:02:04

by Valdis Klētnieks

[permalink] [raw]
Subject: Re: linux-next 20180515 - ACPI disabled..

On Wed, 16 May 2018 13:58:04 +0200, "Rafael J. Wysocki" said:
> On Wednesday, May 16, 2018 12:25:30 AM CEST [email protected] wrote:
> > On Tue, 15 May 2018 15:49:15 -0600, Al Stone said:
> >
> > > Not off-hand. Could you please send me a copy of /sys/firmware/acpi/tables/APIC

> There was one commit that I had to drop.
>
> Please try linux-next tomorrow and let me know if it works for you.

Confirming that linux-next 20180517 works as expected, thanks.

2018-05-18 07:43:13

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: linux-next 20180515 - ACPI disabled..

On Friday, May 18, 2018 12:01:21 AM CEST [email protected] wrote:
> On Wed, 16 May 2018 13:58:04 +0200, "Rafael J. Wysocki" said:
> > On Wednesday, May 16, 2018 12:25:30 AM CEST [email protected] wrote:
> > > On Tue, 15 May 2018 15:49:15 -0600, Al Stone said:
> > >
> > > > Not off-hand. Could you please send me a copy of /sys/firmware/acpi/tables/APIC
>
> > There was one commit that I had to drop.
> >
> > Please try linux-next tomorrow and let me know if it works for you.
>
> Confirming that linux-next 20180517 works as expected, thanks.
>

Good, thanks!