2021-12-10 06:21:54

by David Yang

Subject: [PATCH] pyh: qcom: fix the application of sizeof to pointer

From: Yang Guang <[email protected]>

The coccinelle check report:
./drivers/phy/qualcomm/phy-qcom-edp.c:574:31-37:
ERROR: application of sizeof to pointer

Using the real size to fix it.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: David Yang <[email protected]>
Signed-off-by: Yang Guang <[email protected]>
---
drivers/phy/qualcomm/phy-qcom-edp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
index 17d5653b661d..a8ecd2e8442d 100644
--- a/drivers/phy/qualcomm/phy-qcom-edp.c
+++ b/drivers/phy/qualcomm/phy-qcom-edp.c
@@ -571,7 +571,7 @@ static int qcom_edp_clks_register(struct qcom_edp *edp, struct device_node *np)
struct clk_init_data init = { };
int ret;

- data = devm_kzalloc(edp->dev, sizeof(data), GFP_KERNEL);
+ data = devm_kzalloc(edp->dev, struct_size(data, hws, 2), GFP_KERNEL);
if (!data)
return -ENOMEM;

--
2.30.2

2021-12-14 09:26:42

by Vinod Koul

Subject: Re: [PATCH] pyh: qcom: fix the application of sizeof to pointer

On 10-12-21, 14:21, [email protected] wrote:
> From: Yang Guang <[email protected]>
>
> The coccinelle check report:
> ./drivers/phy/qualcomm/phy-qcom-edp.c:574:31-37:
> ERROR: application of sizeof to pointer

- this should be tagged v2
- You should always note the changes done in v2 (after the --- line)
- subsystem name is 'phy' and not pyh
- I have already applied fix e87f13c33e126ab2c72f9acb5ae98fbb93ddfd32

--
~Vinod

2021-12-14 10:18:16

by David Yang

Subject: Re: [PATCH] pyh: qcom: fix the application of sizeof to pointer

Sorry about that. Thank you for your advice.

On Tue, Dec 14, 2021 at 02:56:35PM +0530, Vinod Koul wrote:
> On 10-12-21, 14:21, [email protected] wrote:
> > From: Yang Guang <[email protected]>
> >
> > The coccinelle check report:
> > ./drivers/phy/qualcomm/phy-qcom-edp.c:574:31-37:
> > ERROR: application of sizeof to pointer
>
> - this should be tagged v2
> - You should always note the changes done in v2 (after the --- line)
> - subsystem name is 'phy' and not pyh
> - I have already applied fix e87f13c33e126ab2c72f9acb5ae98fbb93ddfd32
>
> --
> ~Vinod