2023-12-01 00:31:23

by Bagas Sanjaya

[permalink] [raw]
Subject: Fwd: Thinkpad X13 AMD: Problems with external monitor wake up after suspend

Hi,

I notice a regression report on Bugzilla [1]. Quoting from it:

> Since kernel version 6.1.57 I have problems with external monitor wakeup after suspend on Thinkpad X13 AMD Gen2 Notebook.
>
> Notebook is in docking station with closed lid. Suspend & Resume. The external monitor gets no signal. After randomly typing Ctrl+Alt+Fn for switchung consoles, the monitor at some point gets signal and is usable again.
>
> It worked with kernel 6.1.56.
>
> I managed to compile a 6.1.57 kernel and also a 6.1.64 kernel by reverting the changes from commit ec5fa9 "drm/amd/display: Adjust the MST resume flow" (https://github.com/torvalds/linux/commit/ec5fa9fcdeca69edf7dab5ca3b2e0ceb1c08fe9a?diff=split&w=1?diff=split&w=1) and with this suspend & resume worked like before without any problems.
>
> I reported this also to the Manjaro's support forum, since I tried this on Manjaro Linux (https://forum.manjaro.org/t/problems-with-external-monitor-wake-up-after-suspend/151840).

See Bugzilla for the full thread.

Anyway, I'm adding this regression to regzbot:

#regzbot introduced: ec5fa9fcdeca69 https://bugzilla.kernel.org/show_bug.cgi?id=218211
#regzbot title: MST resume flow adjustment breaks external monitor wakeup after suspend on Thinkpad X13
#regzbot link: https://forum.manjaro.org/t/problems-with-external-monitor-wake-up-after-suspend/151840

Thanks.

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=218211

--
An old man doll... just what I always wanted! - Clara


2023-12-01 11:37:27

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: Fwd: Thinkpad X13 AMD: Problems with external monitor wake up after suspend

[CCing stable list and Mario, who submitted this to 6.1.y]

On 01.12.23 01:30, Bagas Sanjaya wrote:
>
> I notice a regression report on Bugzilla [1]. Quoting from it:
>
>> Since kernel version 6.1.57 I have problems with external monitor
>> wakeup after suspend on Thinkpad X13 AMD Gen2 Notebook.
>>
>> Notebook is in docking station with closed lid. Suspend & Resume.
>> The external monitor gets no signal. After randomly typing
>> Ctrl+Alt+Fn for switchung consoles, the monitor at some point gets
>> signal and is usable again.
>>
>> It worked with kernel 6.1.56.
>>
>> I managed to compile a 6.1.57 kernel and also a 6.1.64 kernel by
>> reverting the changes from commit ec5fa9 "drm/amd/display: Adjust
>> the MST resume flow"
>> (https://github.com/torvalds/linux/commit/ec5fa9fcdeca69edf7dab5ca3b2e0ceb1c08fe9a?diff=split&w=1?diff=split&w=1)
>> and with this suspend & resume worked like before without any
>> problems.
> [...]
> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=218211

We have a small problem here: that error might happen because
ec5fa9fcdeca69 ("drm/amd/display: Adjust the MST resume flow")
[v6.6-rc2] contains a bug or because something it needs was not
backported to 6.1.y.

Maybe one of the developers among the recipients has a idea. Oliver, but
if none of them replies any time soon, it would be best if you'd check
if 6.6 (and/or 6.7-rc) is affected as well; and if reverting it there
fixes it, too.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

2023-12-01 19:16:19

by Oliver Schmidt

[permalink] [raw]
Subject: Re: Fwd: Thinkpad X13 AMD: Problems with external monitor wake up after suspend


On 01.12.23 12:37, Thorsten Leemhuis wrote:
> Maybe one of the developers among the recipients has a idea. Oliver, but
> if none of them replies any time soon, it would be best if you'd check
> if 6.6 (and/or 6.7-rc) is affected as well; and if reverting it there
> fixes it, too.

OK, I checked it: compiled a 6.6.3 kernel and got the same suspend-resume
problem as with the 6.1.57 and 6.1.64 kernels. I also was able to revert the
changes of commit ec5fa9 "drm/amd/display: Adjust the MST resume flow" in the
6.6.3 kernel and the problem was solved as in the 6.1.x kernels (however it
seems that resuming with the 6.6 kernel needs a little more time until the
monitor gets signal).

Best regards,
Oliver


2023-12-15 11:22:28

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: Fwd: Thinkpad X13 AMD: Problems with external monitor wake up after suspend

[TLDR: This mail in primarily relevant for Linux kernel regression
tracking. See link in footer if these mails annoy you.]

On 01.12.23 01:30, Bagas Sanjaya wrote:
>
>> Since kernel version 6.1.57 I have problems with external monitor wakeup after suspend on Thinkpad X13 AMD Gen2 Notebook.
>>
>> Notebook is in docking station with closed lid. Suspend & Resume. The external monitor gets no signal. After randomly typing Ctrl+Alt+Fn for switchung consoles, the monitor at some point gets signal and is usable again.

#regzbot resolve: firmware update for the dock fixed it
#regzbot ignore-activity

Side note: yes, that is not ideal, but it afaics is an acceptable
outcome in this case

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
That page also explains what to do if mails like this annoy you.