cbass_wakeup interconnect which is the parent of wakeup_uart node
defines address-cells=1 and size-cells=1, therefore fix up reg property
of wakeup_uart node accordingly. Otherwise, this UART instance fails to
probe if enabled.
Fixes: 4201af2544b3 ("arm64: dts: ti: am654: Add uart nodes")
Signed-off-by: Vignesh R <[email protected]>
---
Based on next-20180926
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
index ee56959f4af8..c617393ea767 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
@@ -44,7 +44,7 @@
wkup_uart0: serial@42300000 {
compatible = "ti,am654-uart";
- reg = <0x00 0x42300000 0x00 0x100>;
+ reg = <0x42300000 0x100>;
reg-shift = <2>;
reg-io-width = <4>;
interrupts = <GIC_SPI 697 IRQ_TYPE_LEVEL_HIGH>;
--
2.19.0
On Thursday 27 September 2018 10:31 AM, Vignesh R wrote:
> cbass_wakeup interconnect which is the parent of wakeup_uart node
> defines address-cells=1 and size-cells=1, therefore fix up reg property
> of wakeup_uart node accordingly. Otherwise, this UART instance fails to
> probe if enabled.
>
> Fixes: 4201af2544b3 ("arm64: dts: ti: am654: Add uart nodes")
> Signed-off-by: Vignesh R <[email protected]>
Reviewed-by: Lokesh Vutla <[email protected]>
Thanks and regards,
Lokesh
On 05:01-20180927, Vignesh R wrote:
> cbass_wakeup interconnect which is the parent of wakeup_uart node
> defines address-cells=1 and size-cells=1, therefore fix up reg property
> of wakeup_uart node accordingly. Otherwise, this UART instance fails to
> probe if enabled.
>
> Fixes: 4201af2544b3 ("arm64: dts: ti: am654: Add uart nodes")
> Signed-off-by: Vignesh R <[email protected]>
> ---
>
> Based on next-20180926
>
> arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> index ee56959f4af8..c617393ea767 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> @@ -44,7 +44,7 @@
>
> wkup_uart0: serial@42300000 {
> compatible = "ti,am654-uart";
> - reg = <0x00 0x42300000 0x00 0x100>;
> + reg = <0x42300000 0x100>;
> reg-shift = <2>;
> reg-io-width = <4>;
> interrupts = <GIC_SPI 697 IRQ_TYPE_LEVEL_HIGH>;
Thanks. Tero: we should probably queue for rc fixes. wkup_uart is used
by System Firmware logs (if enabled), so kernel usage is limited to some
specific platforms. This is a valid fix and my miss..
Acked-by: Nishanth Menon <[email protected]>
--
Regards,
Nishanth Menon
On 10:10-20181005, Vutla, Lokesh wrote:
>
>
> On Thursday 27 September 2018 10:31 AM, Vignesh R wrote:
> > cbass_wakeup interconnect which is the parent of wakeup_uart node
> > defines address-cells=1 and size-cells=1, therefore fix up reg property
> > of wakeup_uart node accordingly. Otherwise, this UART instance fails to
> > probe if enabled.
> >
> > Fixes: 4201af2544b3 ("arm64: dts: ti: am654: Add uart nodes")
> > Signed-off-by: Vignesh R <[email protected]>
>
> Reviewed-by: Lokesh Vutla <[email protected]>
Tero:
Could we pick this up for rc2? looks like $subject might be good to fix
up to:
arm64: dts: ti: k3-am65-wakeup: Fix wakeup_uart reg address
instead of
arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address
could be fixed locally.
--
Regards,
Nishanth Menon
On 07/11/2018 23:00, Nishanth Menon wrote:
> On 10:10-20181005, Vutla, Lokesh wrote:
>>
>>
>> On Thursday 27 September 2018 10:31 AM, Vignesh R wrote:
>>> cbass_wakeup interconnect which is the parent of wakeup_uart node
>>> defines address-cells=1 and size-cells=1, therefore fix up reg property
>>> of wakeup_uart node accordingly. Otherwise, this UART instance fails to
>>> probe if enabled.
>>>
>>> Fixes: 4201af2544b3 ("arm64: dts: ti: am654: Add uart nodes")
>>> Signed-off-by: Vignesh R <[email protected]>
>>
>> Reviewed-by: Lokesh Vutla <[email protected]>
>
> Tero:
>
> Could we pick this up for rc2? looks like $subject might be good to fix
> up to:
> arm64: dts: ti: k3-am65-wakeup: Fix wakeup_uart reg address
> instead of
> arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address
>
> could be fixed locally.
>
Thanks, queued up for 4.20-rc.
-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki