2022-03-29 01:46:49

by Howard Chiu

Subject: [PATCH v3 1/2] ARM: dts: aspeed: Add video engine

The ast2600 SoC has an embedded video engine
This node was removed by commit 645afe7

Signed-off-by: Howard Chiu <[email protected]>
---
arch/arm/boot/dts/aspeed-g6.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
index c32e87fad4dc..aac55b3aeded 100644
--- a/arch/arm/boot/dts/aspeed-g6.dtsi
+++ b/arch/arm/boot/dts/aspeed-g6.dtsi
@@ -389,6 +389,16 @@ sbc: secure-boot-controller@1e6f2000 {
reg = <0x1e6f2000 0x1000>;
};

+ video: video@1e700000 {
+ compatible = "aspeed,ast2600-video-engine";
+ reg = <0x1e700000 0x1000>;
+ clocks = <&syscon ASPEED_CLK_GATE_VCLK>,
+ <&syscon ASPEED_CLK_GATE_ECLK>;
+ clock-names = "vclk", "eclk";
+ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ };
+
gpio0: gpio@1e780000 {
#gpio-cells = <2>;
gpio-controller;
--
2.25.1

2022-03-29 02:48:45

by Andrew Jeffery

Subject: Re: [PATCH v3 1/2] ARM: dts: aspeed: Add video engine

Hi Howard,

On Tue, 29 Mar 2022, at 12:08, Howard Chiu wrote:
> The ast2600 SoC has an embedded video engine
> This node was removed by commit 645afe7

The summary line of the commit should follow the commit ID (which
should also be 12 characters not 7) here, so:

645afe73f951 ("ARM: dts: aspeed: ast2600: Update XDMA engine node")

>

And then you also need a fixes tag:

Fixes: 645afe73f951 ("ARM: dts: aspeed: ast2600: Update XDMA engine node")


> Signed-off-by: Howard Chiu <[email protected]>
> ---
> arch/arm/boot/dts/aspeed-g6.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index c32e87fad4dc..aac55b3aeded 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -389,6 +389,16 @@ sbc: secure-boot-controller@1e6f2000 {
> reg = <0x1e6f2000 0x1000>;
> };
>
> + video: video@1e700000 {
> + compatible = "aspeed,ast2600-video-engine";
> + reg = <0x1e700000 0x1000>;
> + clocks = <&syscon ASPEED_CLK_GATE_VCLK>,
> + <&syscon ASPEED_CLK_GATE_ECLK>;
> + clock-names = "vclk", "eclk";
> + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + };
> +
> gpio0: gpio@1e780000 {
> #gpio-cells = <2>;
> gpio-controller;
> --
> 2.25.1

Cheers,

Andrew