2019-06-27 17:34:27

by Fuqian Huang

Subject: [PATCH 02/87] ata: acard-ahci: Remove call to memset after dmam_alloc_coherent

In commit af7ddd8a627c
("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
dmam_alloc_coherent has already zeroed the memory.
So memset is not needed.

Signed-off-by: Fuqian Huang <[email protected]>
---
drivers/ata/acard-ahci.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/ata/acard-ahci.c b/drivers/ata/acard-ahci.c
index b1b49dbd0b14..85357f27a66b 100644
--- a/drivers/ata/acard-ahci.c
+++ b/drivers/ata/acard-ahci.c
@@ -344,7 +344,6 @@ static int acard_ahci_port_start(struct ata_port *ap)
mem = dmam_alloc_coherent(dev, dma_sz, &mem_dma, GFP_KERNEL);
if (!mem)
return -ENOMEM;
- memset(mem, 0, dma_sz);

/*
* First item in chunk of DMA memory: 32-slot command table,
--
2.11.0

2019-06-29 15:43:49

by Jens Axboe

Subject: Re: [PATCH 02/87] ata: acard-ahci: Remove call to memset after dmam_alloc_coherent

On 6/27/19 11:33 AM, Fuqian Huang wrote:
> In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> dmam_alloc_coherent has already zeroed the memory.
> So memset is not needed.

Applied this, and the rest of the ATA related patches, for 5.3. Thanks.

--
Jens Axboe