2023-11-25 08:58:31

by Helge Deller

[permalink] [raw]
Subject: Re: [PATCH v2] fbdev/fsl-diu-fb: Fix srapse warning due to virt_to_phys() prototype change

On 11/21/23 01:01, Stanislav Kinsburskii wrote:
> Explicitly cast __iomem pointer to const void* with __force to fix the
> following warning:
>
> incorrect type in argument 1 (different address spaces)
> expected void const volatile *address
> got char [noderef] __iomem *screen_base
>
> Signed-off-by: Stanislav Kinsburskii <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> ---
> drivers/video/fbdev/fsl-diu-fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c
> index 7fbd9f069ac2..b0fda5bd1964 100644
> --- a/drivers/video/fbdev/fsl-diu-fb.c
> +++ b/drivers/video/fbdev/fsl-diu-fb.c
> @@ -877,7 +877,7 @@ static int map_video_memory(struct fb_info *info)
> }
> mutex_lock(&info->mm_lock);
> info->screen_base = p;
> - info->fix.smem_start = virt_to_phys(info->screen_base);
> + info->fix.smem_start = virt_to_phys((__force const void *)info->screen_base);
> info->fix.smem_len = smem_len;
> mutex_unlock(&info->mm_lock);
> info->screen_size = info->fix.smem_len;

applied to fbdev git tree (with some typos corrected).

Helge