On 4/5/2019 5:19 PM, Andra Danciu wrote:
> Adopt the SPDX license identifier headers to ease license compliance
> management.
>
> Signed-off-by: Andra Danciu <[email protected]>
> ---
> sound/soc/fsl/efika-audio-fabric.c | 17 ++++++-----------
> 1 file changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/sound/soc/fsl/efika-audio-fabric.c b/sound/soc/fsl/efika-audio-fabric.c
> index 667f4215dfc0..3e832902fc99 100644
> --- a/sound/soc/fsl/efika-audio-fabric.c
> +++ b/sound/soc/fsl/efika-audio-fabric.c
> @@ -1,14 +1,9 @@
> -/*
> - * Efika driver for the PSC of the Freescale MPC52xx
> - * configured as AC97 interface
> - *
> - * Copyright 2008 Jon Smirl, Digispeaker
> - * Author: Jon Smirl <[email protected]>
> - *
> - * This file is licensed under the terms of the GNU General Public License
> - * version 2. This program is licensed "as is" without any warranty of any
> - * kind, whether express or implied.
> - */
> +// SPDX-License-Identifier: GPL-2.0
Don't change entire thing with //. only above line with the license is
enough.
Please apply this rule every patch of yours.
Thanks,
Mukesh
> +// Efika driver for the PSC of the Freescale MPC52xx
> +// configured as AC97 interface
> +//
> +// Copyright 2008 Jon Smirl, Digispeaker
> +// Author: Jon Smirl <[email protected]>
>
> #include <linux/init.h>
> #include <linux/module.h>
On Fri, Apr 5, 2019 at 9:47 AM Mukesh Ojha <[email protected]> wrote:
> Don't change entire thing with //. only above line with the license is
> enough.
>
> Please apply this rule every patch of yours.
Not really. This is the style preferred in this subsystem.
On 4/5/2019 6:20 PM, Fabio Estevam wrote:
> On Fri, Apr 5, 2019 at 9:47 AM Mukesh Ojha <[email protected]> wrote:
>
>> Don't change entire thing with //. only above line with the license is
>> enough.
>>
>> Please apply this rule every patch of yours.
> Not really. This is the style preferred in this subsystem.
you mean all lines to start with //, does not it look to noisy to eyes ?
-Mukesh
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Fri, Apr 5, 2019 at 10:24 AM Mukesh Ojha <[email protected]> wrote:
> you mean all lines to start with //, does not it look to noisy to eyes ?
Mark Brown's recommendation is to use // in all the initial block
lines instead of only in the SPDX one.