2019-09-08 12:55:55

by Souptick Joarder

Subject: [PATCH 1/3] hv_ballon: Avoid calling dummy function __online_page_set_limits()

__online_page_set_limits() is a dummy function and an extra call
to this function can be avoided.

Signed-off-by: Souptick Joarder <[email protected]>
---
drivers/hv/hv_balloon.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
index 6fb4ea5..9bab443 100644
--- a/drivers/hv/hv_balloon.c
+++ b/drivers/hv/hv_balloon.c
@@ -680,7 +680,6 @@ static void hv_page_online_one(struct hv_hotadd_state *has, struct page *pg)
__ClearPageOffline(pg);

/* This frame is currently backed; online the page. */
- __online_page_set_limits(pg);
__online_page_increment_counters(pg);
__online_page_free(pg);

--
1.9.1

2019-09-09 22:18:41

by David Hildenbrand

Subject: Re: [PATCH 1/3] hv_ballon: Avoid calling dummy function __online_page_set_limits()

On 07.09.19 23:47, Souptick Joarder wrote:
> __online_page_set_limits() is a dummy function and an extra call
> to this function can be avoided.
>
> Signed-off-by: Souptick Joarder <[email protected]>
> ---
> drivers/hv/hv_balloon.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
> index 6fb4ea5..9bab443 100644
> --- a/drivers/hv/hv_balloon.c
> +++ b/drivers/hv/hv_balloon.c
> @@ -680,7 +680,6 @@ static void hv_page_online_one(struct hv_hotadd_state *has, struct page *pg)
> __ClearPageOffline(pg);
>
> /* This frame is currently backed; online the page. */
> - __online_page_set_limits(pg);
> __online_page_increment_counters(pg);
> __online_page_free(pg);
>
>

Reviewed-by: David Hildenbrand <[email protected]>

--

Thanks,

David / dhildenb