2021-01-26 02:46:55

by Tong Zhang

Subject: [PATCH v1] scsi: lpfc: Add auto select on IRQ_POLL

lpfc depends on irq_poll library, but it is not selected automatically.
When irq_poll is not selected, compiling it can run into following error

ERROR: modpost: "irq_poll_init" [drivers/scsi/lpfc/lpfc.ko] undefined!
ERROR: modpost: "irq_poll_sched" [drivers/scsi/lpfc/lpfc.ko] undefined!
ERROR: modpost: "irq_poll_complete" [drivers/scsi/lpfc/lpfc.ko] undefined!

Signed-off-by: Tong Zhang <[email protected]>
---
drivers/scsi/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 701b61ec76ee..c79ac0731b13 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1159,6 +1159,7 @@ config SCSI_LPFC
depends on NVME_TARGET_FC || NVME_TARGET_FC=n
depends on NVME_FC || NVME_FC=n
select CRC_T10DIF
+ select IRQ_POLL
help
This lpfc driver supports the Emulex LightPulse
Family of Fibre Channel PCI host adapters.
--
2.25.1

2021-01-26 14:29:24

by James Smart

Subject: Re: [PATCH v1] scsi: lpfc: Add auto select on IRQ_POLL

On 1/25/2021 4:05 PM, Tong Zhang wrote:
> lpfc depends on irq_poll library, but it is not selected automatically.
> When irq_poll is not selected, compiling it can run into following error
>
> ERROR: modpost: "irq_poll_init" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: modpost: "irq_poll_sched" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: modpost: "irq_poll_complete" [drivers/scsi/lpfc/lpfc.ko] undefined!
>
> Signed-off-by: Tong Zhang <[email protected]>
> ---
> drivers/scsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 701b61ec76ee..c79ac0731b13 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -1159,6 +1159,7 @@ config SCSI_LPFC
> depends on NVME_TARGET_FC || NVME_TARGET_FC=n
> depends on NVME_FC || NVME_FC=n
> select CRC_T10DIF
> + select IRQ_POLL
> help
> This lpfc driver supports the Emulex LightPulse
> Family of Fibre Channel PCI host adapters.

Reviewed-by: James Smart <[email protected]>

-- james

2021-01-27 21:28:52

by Martin K. Petersen

Subject: Re: [PATCH v1] scsi: lpfc: Add auto select on IRQ_POLL

Tong,

> lpfc depends on irq_poll library, but it is not selected
> automatically. When irq_poll is not selected, compiling it can run
> into following error

Applied to 5.12/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2021-01-29 19:08:01

by Martin K. Petersen

Subject: Re: [PATCH v1] scsi: lpfc: Add auto select on IRQ_POLL

On Mon, 25 Jan 2021 19:05:54 -0500, Tong Zhang wrote:

> lpfc depends on irq_poll library, but it is not selected automatically.
> When irq_poll is not selected, compiling it can run into following error
>
> ERROR: modpost: "irq_poll_init" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: modpost: "irq_poll_sched" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: modpost: "irq_poll_complete" [drivers/scsi/lpfc/lpfc.ko] undefined!

Applied to 5.12/scsi-queue, thanks!

[1/1] scsi: lpfc: Add auto select on IRQ_POLL
https://git.kernel.org/mkp/scsi/c/fad0a16130b6

--
Martin K. Petersen Oracle Linux Engineering