Add the bindings and driver changes for DSP support on the
SM8650 platform in order to enable the aDSP, cDSP and MPSS
subsystems to boot.
Compared to SM8550, where SM8650 uses the same dual firmware files,
(dtb file and main firmware) the memory zones requirement has changed:
- cDSP: now requires 2 memory zones to be configured as shared
between the cDSP and the HLOS subsystem
- MPSS: In addition to the memory zone required for the SM8550
MPSS, another one is required to be configured for MPSS
usage only.
In order to handle this and avoid code duplication, the region_assign_*
code patch has been made more generic and is able handle multiple
DSP-only memory zones (for MPSS) or DSP-HLOS shared memory zones (cDSP)
in the same region_assign functions.
Dependencies: None
For convenience, a regularly refreshed linux-next based git tree containing
all the SM8650 related work is available at:
https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/sm8650/upstream/integ
Signed-off-by: Neil Armstrong <[email protected]>
---
Changes in v2:
- Fixed sm8650 entries in allOf:if:then to match Krzysztof's comments
- Collected reviewed-by on patch 3
- Link to v1: https://lore.kernel.org/r/20231025-topic-sm8650-upstream-remoteproc-v1-0-a8d20e4ce18c@linaro.org
---
Neil Armstrong (3):
dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS
remoteproc: qcom: pas: make region assign more generic
remoteproc: qcom: pas: Add SM8650 remoteproc support
.../bindings/remoteproc/qcom,sm8550-pas.yaml | 44 +++++-
drivers/remoteproc/qcom_q6v5_pas.c | 152 ++++++++++++++++-----
2 files changed, 159 insertions(+), 37 deletions(-)
---
base-commit: fe1998aa935b44ef873193c0772c43bce74f17dc
change-id: 20231016-topic-sm8650-upstream-remoteproc-66a87eeb6fee
Best regards,
--
Neil Armstrong <[email protected]>
Add DSP Peripheral Authentication Service support for the SM8650 platform.
Reviewed-by: Dmitry Baryshkov <[email protected]>
Signed-off-by: Neil Armstrong <[email protected]>
---
drivers/remoteproc/qcom_q6v5_pas.c | 50 ++++++++++++++++++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index 4829fd26e17d..c593e6d529b3 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -1195,6 +1195,53 @@ static const struct adsp_data sm8550_mpss_resource = {
.region_assign_vmid = QCOM_SCM_VMID_MSS_MSA,
};
+static const struct adsp_data sm8650_cdsp_resource = {
+ .crash_reason_smem = 601,
+ .firmware_name = "cdsp.mdt",
+ .dtb_firmware_name = "cdsp_dtb.mdt",
+ .pas_id = 18,
+ .dtb_pas_id = 0x25,
+ .minidump_id = 7,
+ .auto_boot = true,
+ .proxy_pd_names = (char*[]){
+ "cx",
+ "mxc",
+ "nsp",
+ NULL
+ },
+ .load_state = "cdsp",
+ .ssr_name = "cdsp",
+ .sysmon_name = "cdsp",
+ .ssctl_id = 0x17,
+ .region_assign_idx = 2,
+ .region_assign_count = 1,
+ .region_assign_shared = true,
+ .region_assign_vmid = QCOM_SCM_VMID_CDSP,
+};
+
+static const struct adsp_data sm8650_mpss_resource = {
+ .crash_reason_smem = 421,
+ .firmware_name = "modem.mdt",
+ .dtb_firmware_name = "modem_dtb.mdt",
+ .pas_id = 4,
+ .dtb_pas_id = 0x26,
+ .minidump_id = 3,
+ .auto_boot = false,
+ .decrypt_shutdown = true,
+ .proxy_pd_names = (char*[]){
+ "cx",
+ "mss",
+ NULL
+ },
+ .load_state = "modem",
+ .ssr_name = "mpss",
+ .sysmon_name = "modem",
+ .ssctl_id = 0x12,
+ .region_assign_idx = 2,
+ .region_assign_count = 2,
+ .region_assign_vmid = QCOM_SCM_VMID_MSS_MSA,
+};
+
static const struct of_device_id adsp_of_match[] = {
{ .compatible = "qcom,msm8226-adsp-pil", .data = &adsp_resource_init},
{ .compatible = "qcom,msm8953-adsp-pil", .data = &msm8996_adsp_resource},
@@ -1247,6 +1294,9 @@ static const struct of_device_id adsp_of_match[] = {
{ .compatible = "qcom,sm8550-adsp-pas", .data = &sm8550_adsp_resource},
{ .compatible = "qcom,sm8550-cdsp-pas", .data = &sm8550_cdsp_resource},
{ .compatible = "qcom,sm8550-mpss-pas", .data = &sm8550_mpss_resource},
+ { .compatible = "qcom,sm8650-adsp-pas", .data = &sm8550_adsp_resource},
+ { .compatible = "qcom,sm8650-cdsp-pas", .data = &sm8650_cdsp_resource},
+ { .compatible = "qcom,sm8650-mpss-pas", .data = &sm8650_mpss_resource},
{ },
};
MODULE_DEVICE_TABLE(of, adsp_of_match);
--
2.34.1
Document the DSP Peripheral Authentication Service on the SM8650 Platform.
Signed-off-by: Neil Armstrong <[email protected]>
---
.../bindings/remoteproc/qcom,sm8550-pas.yaml | 44 +++++++++++++++++++++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
index 58120829fb06..4e8ce9e7e9fa 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
@@ -19,6 +19,9 @@ properties:
- qcom,sm8550-adsp-pas
- qcom,sm8550-cdsp-pas
- qcom,sm8550-mpss-pas
+ - qcom,sm8650-adsp-pas
+ - qcom,sm8650-cdsp-pas
+ - qcom,sm8650-mpss-pas
reg:
maxItems: 1
@@ -49,6 +52,7 @@ properties:
- description: Memory region for main Firmware authentication
- description: Memory region for Devicetree Firmware authentication
- description: DSM Memory region
+ - description: DSM Memory region 2
required:
- compatible
@@ -63,6 +67,7 @@ allOf:
enum:
- qcom,sm8550-adsp-pas
- qcom,sm8550-cdsp-pas
+ - qcom,sm8650-adsp-pas
then:
properties:
interrupts:
@@ -71,7 +76,26 @@ allOf:
maxItems: 5
memory-region:
maxItems: 2
- else:
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,sm8650-cdsp-pas
+ then:
+ properties:
+ interrupts:
+ maxItems: 5
+ interrupt-names:
+ maxItems: 5
+ memory-region:
+ minItems: 3
+ maxItems: 3
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,sm8550-mpss-pas
+ then:
properties:
interrupts:
minItems: 6
@@ -79,12 +103,28 @@ allOf:
minItems: 6
memory-region:
minItems: 3
+ maxItems: 3
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,sm8650-mpss-pas
+ then:
+ properties:
+ interrupts:
+ minItems: 6
+ interrupt-names:
+ minItems: 6
+ memory-region:
+ minItems: 4
+ maxItems: 4
- if:
properties:
compatible:
enum:
- qcom,sm8550-adsp-pas
+ - qcom,sm8650-adsp-pas
then:
properties:
power-domains:
@@ -101,6 +141,7 @@ allOf:
compatible:
enum:
- qcom,sm8550-mpss-pas
+ - qcom,sm8650-mpss-pas
then:
properties:
power-domains:
@@ -116,6 +157,7 @@ allOf:
compatible:
enum:
- qcom,sm8550-cdsp-pas
+ - qcom,sm8650-cdsp-pas
then:
properties:
power-domains:
--
2.34.1
The current memory region assign only supports a single
memory region.
But new platforms introduces more regions to make the
memory requirements more flexible for various use cases.
Those new platforms also shares the memory region between the
DSP and HLOS.
To handle this, make the region assign more generic in order
to support more than a single memory region and also permit
setting the regions permissions as shared.
Signed-off-by: Neil Armstrong <[email protected]>
---
drivers/remoteproc/qcom_q6v5_pas.c | 102 ++++++++++++++++++++++++-------------
1 file changed, 66 insertions(+), 36 deletions(-)
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index 913a5d2068e8..4829fd26e17d 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -33,6 +33,8 @@
#define ADSP_DECRYPT_SHUTDOWN_DELAY_MS 100
+#define MAX_ASSIGN_COUNT 2
+
struct adsp_data {
int crash_reason_smem;
const char *firmware_name;
@@ -51,6 +53,9 @@ struct adsp_data {
int ssctl_id;
int region_assign_idx;
+ int region_assign_count;
+ bool region_assign_shared;
+ int region_assign_vmid;
};
struct qcom_adsp {
@@ -87,15 +92,18 @@ struct qcom_adsp {
phys_addr_t dtb_mem_phys;
phys_addr_t mem_reloc;
phys_addr_t dtb_mem_reloc;
- phys_addr_t region_assign_phys;
+ phys_addr_t region_assign_phys[MAX_ASSIGN_COUNT];
void *mem_region;
void *dtb_mem_region;
size_t mem_size;
size_t dtb_mem_size;
- size_t region_assign_size;
+ size_t region_assign_size[MAX_ASSIGN_COUNT];
int region_assign_idx;
- u64 region_assign_perms;
+ int region_assign_count;
+ bool region_assign_shared;
+ int region_assign_vmid;
+ u64 region_assign_perms[MAX_ASSIGN_COUNT];
struct qcom_rproc_glink glink_subdev;
struct qcom_rproc_subdev smd_subdev;
@@ -590,37 +598,52 @@ static int adsp_alloc_memory_region(struct qcom_adsp *adsp)
static int adsp_assign_memory_region(struct qcom_adsp *adsp)
{
- struct reserved_mem *rmem = NULL;
- struct qcom_scm_vmperm perm;
+ struct qcom_scm_vmperm perm[MAX_ASSIGN_COUNT];
+ unsigned int perm_size = 1;
struct device_node *node;
- int ret;
+ int offset, ret;
if (!adsp->region_assign_idx)
return 0;
- node = of_parse_phandle(adsp->dev->of_node, "memory-region", adsp->region_assign_idx);
- if (node)
- rmem = of_reserved_mem_lookup(node);
- of_node_put(node);
- if (!rmem) {
- dev_err(adsp->dev, "unable to resolve shareable memory-region\n");
- return -EINVAL;
- }
+ for (offset = 0; offset < adsp->region_assign_count; ++offset) {
+ struct reserved_mem *rmem = NULL;
+
+ node = of_parse_phandle(adsp->dev->of_node, "memory-region",
+ adsp->region_assign_idx + offset);
+ if (node)
+ rmem = of_reserved_mem_lookup(node);
+ of_node_put(node);
+ if (!rmem) {
+ dev_err(adsp->dev, "unable to resolve shareable memory-region index %d\n",
+ offset);
+ return -EINVAL;
+ }
- perm.vmid = QCOM_SCM_VMID_MSS_MSA;
- perm.perm = QCOM_SCM_PERM_RW;
+ if (adsp->region_assign_shared) {
+ perm[0].vmid = QCOM_SCM_VMID_HLOS;
+ perm[0].perm = QCOM_SCM_PERM_RW;
+ perm[1].vmid = adsp->region_assign_vmid;
+ perm[1].perm = QCOM_SCM_PERM_RW;
+ perm_size = 2;
+ } else {
+ perm[0].vmid = adsp->region_assign_vmid;
+ perm[0].perm = QCOM_SCM_PERM_RW;
+ perm_size = 1;
+ }
- adsp->region_assign_phys = rmem->base;
- adsp->region_assign_size = rmem->size;
- adsp->region_assign_perms = BIT(QCOM_SCM_VMID_HLOS);
+ adsp->region_assign_phys[offset] = rmem->base;
+ adsp->region_assign_size[offset] = rmem->size;
+ adsp->region_assign_perms[offset] = BIT(QCOM_SCM_VMID_HLOS);
- ret = qcom_scm_assign_mem(adsp->region_assign_phys,
- adsp->region_assign_size,
- &adsp->region_assign_perms,
- &perm, 1);
- if (ret < 0) {
- dev_err(adsp->dev, "assign memory failed\n");
- return ret;
+ ret = qcom_scm_assign_mem(adsp->region_assign_phys[offset],
+ adsp->region_assign_size[offset],
+ &adsp->region_assign_perms[offset],
+ perm, perm_size);
+ if (ret < 0) {
+ dev_err(adsp->dev, "assign memory %d failed\n", offset);
+ return ret;
+ }
}
return 0;
@@ -629,20 +652,22 @@ static int adsp_assign_memory_region(struct qcom_adsp *adsp)
static void adsp_unassign_memory_region(struct qcom_adsp *adsp)
{
struct qcom_scm_vmperm perm;
- int ret;
+ int offset, ret;
- if (!adsp->region_assign_idx)
+ if (!adsp->region_assign_idx || adsp->region_assign_shared)
return;
- perm.vmid = QCOM_SCM_VMID_HLOS;
- perm.perm = QCOM_SCM_PERM_RW;
+ for (offset = 0; offset < adsp->region_assign_count; ++offset) {
+ perm.vmid = QCOM_SCM_VMID_HLOS;
+ perm.perm = QCOM_SCM_PERM_RW;
- ret = qcom_scm_assign_mem(adsp->region_assign_phys,
- adsp->region_assign_size,
- &adsp->region_assign_perms,
- &perm, 1);
- if (ret < 0)
- dev_err(adsp->dev, "unassign memory failed\n");
+ ret = qcom_scm_assign_mem(adsp->region_assign_phys[offset],
+ adsp->region_assign_size[offset],
+ &adsp->region_assign_perms[offset],
+ &perm, 1);
+ if (ret < 0)
+ dev_err(adsp->dev, "unassign memory failed\n");
+ }
}
static int adsp_probe(struct platform_device *pdev)
@@ -696,6 +721,9 @@ static int adsp_probe(struct platform_device *pdev)
adsp->info_name = desc->sysmon_name;
adsp->decrypt_shutdown = desc->decrypt_shutdown;
adsp->region_assign_idx = desc->region_assign_idx;
+ adsp->region_assign_count = min_t(int, MAX_ASSIGN_COUNT, desc->region_assign_count);
+ adsp->region_assign_vmid = desc->region_assign_vmid;
+ adsp->region_assign_shared = desc->region_assign_shared;
if (dtb_fw_name) {
adsp->dtb_firmware_name = dtb_fw_name;
adsp->dtb_pas_id = desc->dtb_pas_id;
@@ -1163,6 +1191,8 @@ static const struct adsp_data sm8550_mpss_resource = {
.sysmon_name = "modem",
.ssctl_id = 0x12,
.region_assign_idx = 2,
+ .region_assign_count = 1,
+ .region_assign_vmid = QCOM_SCM_VMID_MSS_MSA,
};
static const struct of_device_id adsp_of_match[] = {
--
2.34.1
On 10/30/2023 3:33 PM, Neil Armstrong wrote:
> The current memory region assign only supports a single
> memory region.
>
> But new platforms introduces more regions to make the
> memory requirements more flexible for various use cases.
> Those new platforms also shares the memory region between the
> DSP and HLOS.
>
> To handle this, make the region assign more generic in order
> to support more than a single memory region and also permit
> setting the regions permissions as shared.
>
> Signed-off-by: Neil Armstrong <[email protected]>
> ---
> drivers/remoteproc/qcom_q6v5_pas.c | 102 ++++++++++++++++++++++++-------------
> 1 file changed, 66 insertions(+), 36 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index 913a5d2068e8..4829fd26e17d 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -33,6 +33,8 @@
>
> #define ADSP_DECRYPT_SHUTDOWN_DELAY_MS 100
>
> +#define MAX_ASSIGN_COUNT 2
> +
> struct adsp_data {
> int crash_reason_smem;
> const char *firmware_name;
> @@ -51,6 +53,9 @@ struct adsp_data {
> int ssctl_id;
>
> int region_assign_idx;
> + int region_assign_count;
> + bool region_assign_shared;
> + int region_assign_vmid;
> };
>
> struct qcom_adsp {
> @@ -87,15 +92,18 @@ struct qcom_adsp {
> phys_addr_t dtb_mem_phys;
> phys_addr_t mem_reloc;
> phys_addr_t dtb_mem_reloc;
> - phys_addr_t region_assign_phys;
> + phys_addr_t region_assign_phys[MAX_ASSIGN_COUNT];
> void *mem_region;
> void *dtb_mem_region;
> size_t mem_size;
> size_t dtb_mem_size;
> - size_t region_assign_size;
> + size_t region_assign_size[MAX_ASSIGN_COUNT];
>
> int region_assign_idx;
> - u64 region_assign_perms;
> + int region_assign_count;
> + bool region_assign_shared;
> + int region_assign_vmid;
> + u64 region_assign_perms[MAX_ASSIGN_COUNT];
>
> struct qcom_rproc_glink glink_subdev;
> struct qcom_rproc_subdev smd_subdev;
> @@ -590,37 +598,52 @@ static int adsp_alloc_memory_region(struct qcom_adsp *adsp)
>
> static int adsp_assign_memory_region(struct qcom_adsp *adsp)
> {
> - struct reserved_mem *rmem = NULL;
> - struct qcom_scm_vmperm perm;
> + struct qcom_scm_vmperm perm[MAX_ASSIGN_COUNT];
> + unsigned int perm_size = 1;
AFAICS, not need of initialization.
> struct device_node *node;
> - int ret;
> + int offset, ret;
Nit: one variable per line.
>
> if (!adsp->region_assign_idx)
Not related to this patch..
Should not this be valid only for > 1 ?
> return 0;
>
> - node = of_parse_phandle(adsp->dev->of_node, "memory-region", adsp->region_assign_idx);
> - if (node)
> - rmem = of_reserved_mem_lookup(node);
> - of_node_put(node);
> - if (!rmem) {
> - dev_err(adsp->dev, "unable to resolve shareable memory-region\n");
> - return -EINVAL;
> - }
> + for (offset = 0; offset < adsp->region_assign_count; ++offset) {
> + struct reserved_mem *rmem = NULL;
> +
> + node = of_parse_phandle(adsp->dev->of_node, "memory-region",
> + adsp->region_assign_idx + offset);
> + if (node)
> + rmem = of_reserved_mem_lookup(node);
> + of_node_put(node);
> + if (!rmem) {
> + dev_err(adsp->dev, "unable to resolve shareable memory-region index %d\n",
> + offset);
> + return -EINVAL; > + }
>
> - perm.vmid = QCOM_SCM_VMID_MSS_MSA;
> - perm.perm = QCOM_SCM_PERM_RW;
> + if (adsp->region_assign_shared) {
> + perm[0].vmid = QCOM_SCM_VMID_HLOS;
> + perm[0].perm = QCOM_SCM_PERM_RW;
> + perm[1].vmid = adsp->region_assign_vmid;
> + perm[1].perm = QCOM_SCM_PERM_RW;
> + perm_size = 2;
> + } else {
> + perm[0].vmid = adsp->region_assign_vmid;
> + perm[0].perm = QCOM_SCM_PERM_RW;
> + perm_size = 1;
> + }
>
> - adsp->region_assign_phys = rmem->base;
> - adsp->region_assign_size = rmem->size;
> - adsp->region_assign_perms = BIT(QCOM_SCM_VMID_HLOS);
> + adsp->region_assign_phys[offset] = rmem->base;
> + adsp->region_assign_size[offset] = rmem->size;
> + adsp->region_assign_perms[offset] = BIT(QCOM_SCM_VMID_HLOS);
Do we need array for this, is this changing ?
>
> - ret = qcom_scm_assign_mem(adsp->region_assign_phys,
> - adsp->region_assign_size,
> - &adsp->region_assign_perms,
> - &perm, 1);
> - if (ret < 0) {
> - dev_err(adsp->dev, "assign memory failed\n");
> - return ret;
> + ret = qcom_scm_assign_mem(adsp->region_assign_phys[offset],
> + adsp->region_assign_size[offset],
> + &adsp->region_assign_perms[offset],
> + perm, perm_size);
> + if (ret < 0) {
> + dev_err(adsp->dev, "assign memory %d failed\n", offset);
> + return ret;
> + }
> }
>
> return 0;
> @@ -629,20 +652,22 @@ static int adsp_assign_memory_region(struct qcom_adsp *adsp)
> static void adsp_unassign_memory_region(struct qcom_adsp *adsp)
> {
> struct qcom_scm_vmperm perm;
> - int ret;
> + int offset, ret;
>
> - if (!adsp->region_assign_idx)
> + if (!adsp->region_assign_idx || adsp->region_assign_shared)
> return;
>
> - perm.vmid = QCOM_SCM_VMID_HLOS;
> - perm.perm = QCOM_SCM_PERM_RW;
> + for (offset = 0; offset < adsp->region_assign_count; ++offset) {
> + perm.vmid = QCOM_SCM_VMID_HLOS;
> + perm.perm = QCOM_SCM_PERM_RW;
>
> - ret = qcom_scm_assign_mem(adsp->region_assign_phys,
> - adsp->region_assign_size,
> - &adsp->region_assign_perms,
> - &perm, 1);
> - if (ret < 0)
> - dev_err(adsp->dev, "unassign memory failed\n");
> + ret = qcom_scm_assign_mem(adsp->region_assign_phys[offset],
> + adsp->region_assign_size[offset],
> + &adsp->region_assign_perms[offset],
> + &perm, 1);
> + if (ret < 0)
> + dev_err(adsp->dev, "unassign memory failed\n");
> + }
> }
>
> static int adsp_probe(struct platform_device *pdev)
> @@ -696,6 +721,9 @@ static int adsp_probe(struct platform_device *pdev)
> adsp->info_name = desc->sysmon_name;
> adsp->decrypt_shutdown = desc->decrypt_shutdown;
> adsp->region_assign_idx = desc->region_assign_idx;
> + adsp->region_assign_count = min_t(int, MAX_ASSIGN_COUNT, desc->region_assign_count);
> + adsp->region_assign_vmid = desc->region_assign_vmid;
> + adsp->region_assign_shared = desc->region_assign_shared;
> if (dtb_fw_name) {
> adsp->dtb_firmware_name = dtb_fw_name;
> adsp->dtb_pas_id = desc->dtb_pas_id;
> @@ -1163,6 +1191,8 @@ static const struct adsp_data sm8550_mpss_resource = {
> .sysmon_name = "modem",
> .ssctl_id = 0x12,
> .region_assign_idx = 2,
> + .region_assign_count = 1,
> + .region_assign_vmid = QCOM_SCM_VMID_MSS_MSA,
> };
>
> static const struct of_device_id adsp_of_match[] = {
>
-Mukesh
On 30/10/2023 11:03, Neil Armstrong wrote:
> Document the DSP Peripheral Authentication Service on the SM8650 Platform.
>
> Signed-off-by: Neil Armstrong <[email protected]>
> ---
> .../bindings/remoteproc/qcom,sm8550-pas.yaml | 44 +++++++++++++++++++++-
> 1 file changed, 43 insertions(+), 1 deletion(-)'
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
Hi,
On 30/10/2023 14:10, Mukesh Ojha wrote:
>
>
> On 10/30/2023 3:33 PM, Neil Armstrong wrote:
>> The current memory region assign only supports a single
>> memory region.
>>
>> But new platforms introduces more regions to make the
>> memory requirements more flexible for various use cases.
>> Those new platforms also shares the memory region between the
>> DSP and HLOS.
>>
>> To handle this, make the region assign more generic in order
>> to support more than a single memory region and also permit
>> setting the regions permissions as shared.
>>
>> Signed-off-by: Neil Armstrong <[email protected]>
>> ---
>> drivers/remoteproc/qcom_q6v5_pas.c | 102 ++++++++++++++++++++++++-------------
>> 1 file changed, 66 insertions(+), 36 deletions(-)
>>
>> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
>> index 913a5d2068e8..4829fd26e17d 100644
>> --- a/drivers/remoteproc/qcom_q6v5_pas.c
>> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
>> @@ -33,6 +33,8 @@
>> #define ADSP_DECRYPT_SHUTDOWN_DELAY_MS 100
>> +#define MAX_ASSIGN_COUNT 2
>> +
>> struct adsp_data {
>> int crash_reason_smem;
>> const char *firmware_name;
>> @@ -51,6 +53,9 @@ struct adsp_data {
>> int ssctl_id;
>> int region_assign_idx;
>> + int region_assign_count;
>> + bool region_assign_shared;
>> + int region_assign_vmid;
>> };
>> struct qcom_adsp {
>> @@ -87,15 +92,18 @@ struct qcom_adsp {
>> phys_addr_t dtb_mem_phys;
>> phys_addr_t mem_reloc;
>> phys_addr_t dtb_mem_reloc;
>> - phys_addr_t region_assign_phys;
>> + phys_addr_t region_assign_phys[MAX_ASSIGN_COUNT];
>> void *mem_region;
>> void *dtb_mem_region;
>> size_t mem_size;
>> size_t dtb_mem_size;
>> - size_t region_assign_size;
>> + size_t region_assign_size[MAX_ASSIGN_COUNT];
>> int region_assign_idx;
>> - u64 region_assign_perms;
>> + int region_assign_count;
>> + bool region_assign_shared;
>> + int region_assign_vmid;
>> + u64 region_assign_perms[MAX_ASSIGN_COUNT];
>> struct qcom_rproc_glink glink_subdev;
>> struct qcom_rproc_subdev smd_subdev;
>> @@ -590,37 +598,52 @@ static int adsp_alloc_memory_region(struct qcom_adsp *adsp)
>> static int adsp_assign_memory_region(struct qcom_adsp *adsp)
>> {
>> - struct reserved_mem *rmem = NULL;
>> - struct qcom_scm_vmperm perm;
>> + struct qcom_scm_vmperm perm[MAX_ASSIGN_COUNT];
>> + unsigned int perm_size = 1;
>
> AFAICS, not need of initialization.
Indeed, removed
>
>> struct device_node *node;
>> - int ret;
>> + int offset, ret;
>
> Nit: one variable per line.
Done
>
>> if (!adsp->region_assign_idx)
>
> Not related to this patch..
> Should not this be valid only for > 1 ?
I don't understand, only region_assign_idx > 1 triggers a memory_assign,
and this check discards configurations with region_assign_idx == 0 as
expected.
>
>
>> return 0;
>> - node = of_parse_phandle(adsp->dev->of_node, "memory-region", adsp->region_assign_idx);
>> - if (node)
>> - rmem = of_reserved_mem_lookup(node);
>> - of_node_put(node);
>> - if (!rmem) {
>> - dev_err(adsp->dev, "unable to resolve shareable memory-region\n");
>> - return -EINVAL;
>> - }
>> + for (offset = 0; offset < adsp->region_assign_count; ++offset) {
>> + struct reserved_mem *rmem = NULL;
>> +
>> + node = of_parse_phandle(adsp->dev->of_node, "memory-region",
>> + adsp->region_assign_idx + offset);
>> + if (node)
>> + rmem = of_reserved_mem_lookup(node);
>> + of_node_put(node);
>> + if (!rmem) {
>> + dev_err(adsp->dev, "unable to resolve shareable memory-region index %d\n",
>> + offset);
>> + return -EINVAL; > + }
>
>
>> - perm.vmid = QCOM_SCM_VMID_MSS_MSA;
>> - perm.perm = QCOM_SCM_PERM_RW;
>> + if (adsp->region_assign_shared) {
>> + perm[0].vmid = QCOM_SCM_VMID_HLOS;
>> + perm[0].perm = QCOM_SCM_PERM_RW;
>> + perm[1].vmid = adsp->region_assign_vmid;
>> + perm[1].perm = QCOM_SCM_PERM_RW;
>> + perm_size = 2;
>> + } else {
>> + perm[0].vmid = adsp->region_assign_vmid;
>> + perm[0].perm = QCOM_SCM_PERM_RW;
>> + perm_size = 1;
>> + }
>> - adsp->region_assign_phys = rmem->base;
>> - adsp->region_assign_size = rmem->size;
>> - adsp->region_assign_perms = BIT(QCOM_SCM_VMID_HLOS);
>> + adsp->region_assign_phys[offset] = rmem->base;
>> + adsp->region_assign_size[offset] = rmem->size;
>> + adsp->region_assign_perms[offset] = BIT(QCOM_SCM_VMID_HLOS);
>
> Do we need array for this, is this changing ?
We need to keep region_assign_perms for unassign, but for the other 2 we would
need to duplicate the code from adsp_assign_memory_region into
adsp_unassign_memory_region.
>
>> - ret = qcom_scm_assign_mem(adsp->region_assign_phys,
>> - adsp->region_assign_size,
>> - &adsp->region_assign_perms,
>> - &perm, 1);
>> - if (ret < 0) {
>> - dev_err(adsp->dev, "assign memory failed\n");
>> - return ret;
>> + ret = qcom_scm_assign_mem(adsp->region_assign_phys[offset],
>> + adsp->region_assign_size[offset],
>> + &adsp->region_assign_perms[offset],
>> + perm, perm_size);
>> + if (ret < 0) {
>> + dev_err(adsp->dev, "assign memory %d failed\n", offset);
>> + return ret;
>> + }
>> }
>> return 0;
>> @@ -629,20 +652,22 @@ static int adsp_assign_memory_region(struct qcom_adsp *adsp)
>> static void adsp_unassign_memory_region(struct qcom_adsp *adsp)
>> {
>> struct qcom_scm_vmperm perm;
>> - int ret;
>> + int offset, ret;
>> - if (!adsp->region_assign_idx)
>> + if (!adsp->region_assign_idx || adsp->region_assign_shared)
>> return;
>> - perm.vmid = QCOM_SCM_VMID_HLOS;
>> - perm.perm = QCOM_SCM_PERM_RW;
>> + for (offset = 0; offset < adsp->region_assign_count; ++offset) {
>> + perm.vmid = QCOM_SCM_VMID_HLOS;
>> + perm.perm = QCOM_SCM_PERM_RW;
>
>> - ret = qcom_scm_assign_mem(adsp->region_assign_phys,
>> - adsp->region_assign_size,
>> - &adsp->region_assign_perms,
>> - &perm, 1);
>> - if (ret < 0)
>> - dev_err(adsp->dev, "unassign memory failed\n");
>> + ret = qcom_scm_assign_mem(adsp->region_assign_phys[offset],
>> + adsp->region_assign_size[offset],
>> + &adsp->region_assign_perms[offset],
>> + &perm, 1);
>> + if (ret < 0)
>> + dev_err(adsp->dev, "unassign memory failed\n");
>> + }
>> }
>> static int adsp_probe(struct platform_device *pdev)
>> @@ -696,6 +721,9 @@ static int adsp_probe(struct platform_device *pdev)
>> adsp->info_name = desc->sysmon_name;
>> adsp->decrypt_shutdown = desc->decrypt_shutdown;
>> adsp->region_assign_idx = desc->region_assign_idx;
>> + adsp->region_assign_count = min_t(int, MAX_ASSIGN_COUNT, desc->region_assign_count);
>> + adsp->region_assign_vmid = desc->region_assign_vmid;
>> + adsp->region_assign_shared = desc->region_assign_shared;
>> if (dtb_fw_name) {
>> adsp->dtb_firmware_name = dtb_fw_name;
>> adsp->dtb_pas_id = desc->dtb_pas_id;
>> @@ -1163,6 +1191,8 @@ static const struct adsp_data sm8550_mpss_resource = {
>> .sysmon_name = "modem",
>> .ssctl_id = 0x12,
>> .region_assign_idx = 2,
>> + .region_assign_count = 1,
>> + .region_assign_vmid = QCOM_SCM_VMID_MSS_MSA,
>> };
>> static const struct of_device_id adsp_of_match[] = {
>>
>
> -Mukesh
Thanks,
Neil
On 10/31/2023 10:36 PM, Neil Armstrong wrote:
> Hi,
>
> On 30/10/2023 14:10, Mukesh Ojha wrote:
>>
>>
>> On 10/30/2023 3:33 PM, Neil Armstrong wrote:
>>> The current memory region assign only supports a single
>>> memory region.
>>>
>>> But new platforms introduces more regions to make the
>>> memory requirements more flexible for various use cases.
>>> Those new platforms also shares the memory region between the
>>> DSP and HLOS.
>>>
>>> To handle this, make the region assign more generic in order
>>> to support more than a single memory region and also permit
>>> setting the regions permissions as shared.
>>>
>>> Signed-off-by: Neil Armstrong <[email protected]>
>>> ---
>>> drivers/remoteproc/qcom_q6v5_pas.c | 102
>>> ++++++++++++++++++++++++-------------
>>> 1 file changed, 66 insertions(+), 36 deletions(-)
>>>
>>> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c
>>> b/drivers/remoteproc/qcom_q6v5_pas.c
>>> index 913a5d2068e8..4829fd26e17d 100644
>>> --- a/drivers/remoteproc/qcom_q6v5_pas.c
>>> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
>>> @@ -33,6 +33,8 @@
>>> #define ADSP_DECRYPT_SHUTDOWN_DELAY_MS 100
>>> +#define MAX_ASSIGN_COUNT 2
>>> +
>>> struct adsp_data {
>>> int crash_reason_smem;
>>> const char *firmware_name;
>>> @@ -51,6 +53,9 @@ struct adsp_data {
>>> int ssctl_id;
>>> int region_assign_idx;
>>> + int region_assign_count;
>>> + bool region_assign_shared;
>>> + int region_assign_vmid;
>>> };
>>> struct qcom_adsp {
>>> @@ -87,15 +92,18 @@ struct qcom_adsp {
>>> phys_addr_t dtb_mem_phys;
>>> phys_addr_t mem_reloc;
>>> phys_addr_t dtb_mem_reloc;
>>> - phys_addr_t region_assign_phys;
>>> + phys_addr_t region_assign_phys[MAX_ASSIGN_COUNT];
>>> void *mem_region;
>>> void *dtb_mem_region;
>>> size_t mem_size;
>>> size_t dtb_mem_size;
>>> - size_t region_assign_size;
>>> + size_t region_assign_size[MAX_ASSIGN_COUNT];
>>> int region_assign_idx;
>>> - u64 region_assign_perms;
>>> + int region_assign_count;
>>> + bool region_assign_shared;
>>> + int region_assign_vmid;
>>> + u64 region_assign_perms[MAX_ASSIGN_COUNT];
>>> struct qcom_rproc_glink glink_subdev;
>>> struct qcom_rproc_subdev smd_subdev;
>>> @@ -590,37 +598,52 @@ static int adsp_alloc_memory_region(struct
>>> qcom_adsp *adsp)
>>> static int adsp_assign_memory_region(struct qcom_adsp *adsp)
>>> {
>>> - struct reserved_mem *rmem = NULL;
>>> - struct qcom_scm_vmperm perm;
>>> + struct qcom_scm_vmperm perm[MAX_ASSIGN_COUNT];
>>> + unsigned int perm_size = 1;
>>
>> AFAICS, not need of initialization.
>
> Indeed, removed
>
>>
>>> struct device_node *node;
>>> - int ret;
>>> + int offset, ret;
>>
>> Nit: one variable per line.
>
> Done
>
>>
>>> if (!adsp->region_assign_idx)
>>
>> Not related to this patch..
>> Should not this be valid only for > 1 ?
>
> I don't understand, only region_assign_idx > 1 triggers a memory_assign,
> and this check discards configurations with region_assign_idx == 0 as
> expected.
Ah, you can ignore the comments, I got the intention after commenting
here ..
>
>>
>>
>>> return 0;
>>> - node = of_parse_phandle(adsp->dev->of_node, "memory-region",
>>> adsp->region_assign_idx);
>>> - if (node)
>>> - rmem = of_reserved_mem_lookup(node);
>>> - of_node_put(node);
>>> - if (!rmem) {
>>> - dev_err(adsp->dev, "unable to resolve shareable
>>> memory-region\n");
>>> - return -EINVAL;
>>> - }
>>> + for (offset = 0; offset < adsp->region_assign_count; ++offset) {
>>> + struct reserved_mem *rmem = NULL;
>>> +
>>> + node = of_parse_phandle(adsp->dev->of_node, "memory-region",
>>> + adsp->region_assign_idx + offset);
>>> + if (node)
>>> + rmem = of_reserved_mem_lookup(node);
>>> + of_node_put(node);
>>> + if (!rmem) {
>>> + dev_err(adsp->dev, "unable to resolve shareable
>>> memory-region index %d\n",
>>> + offset);
>>> + return -EINVAL; > + }
>>
>>
>>> - perm.vmid = QCOM_SCM_VMID_MSS_MSA;
>>> - perm.perm = QCOM_SCM_PERM_RW;
>>> + if (adsp->region_assign_shared) {
>>> + perm[0].vmid = QCOM_SCM_VMID_HLOS;
>>> + perm[0].perm = QCOM_SCM_PERM_RW;
>>> + perm[1].vmid = adsp->region_assign_vmid;
>>> + perm[1].perm = QCOM_SCM_PERM_RW;
>>> + perm_size = 2;
>>> + } else {
>>> + perm[0].vmid = adsp->region_assign_vmid;
>>> + perm[0].perm = QCOM_SCM_PERM_RW;
>>> + perm_size = 1;
>>> + }
>>> - adsp->region_assign_phys = rmem->base;
>>> - adsp->region_assign_size = rmem->size;
>>> - adsp->region_assign_perms = BIT(QCOM_SCM_VMID_HLOS);
>>> + adsp->region_assign_phys[offset] = rmem->base;
>>> + adsp->region_assign_size[offset] = rmem->size;
>>> + adsp->region_assign_perms[offset] = BIT(QCOM_SCM_VMID_HLOS);
>>
>> Do we need array for this, is this changing ?
>
> We need to keep region_assign_perms for unassign, but for the other 2 we
> would
> need to duplicate the code from adsp_assign_memory_region into
> adsp_unassign_memory_region.
Thanks got it.
>
>>
>>> - ret = qcom_scm_assign_mem(adsp->region_assign_phys,
>>> - adsp->region_assign_size,
>>> - &adsp->region_assign_perms,
>>> - &perm, 1);
>>> - if (ret < 0) {
>>> - dev_err(adsp->dev, "assign memory failed\n");
>>> - return ret;
>>> + ret = qcom_scm_assign_mem(adsp->region_assign_phys[offset],
>>> + adsp->region_assign_size[offset],
>>> + &adsp->region_assign_perms[offset],
>>> + perm, perm_size);
>>> + if (ret < 0) {
>>> + dev_err(adsp->dev, "assign memory %d failed\n", offset);
>>> + return ret;
>>> + }
>>> }
>>> return 0;
>>> @@ -629,20 +652,22 @@ static int adsp_assign_memory_region(struct
>>> qcom_adsp *adsp)
>>> static void adsp_unassign_memory_region(struct qcom_adsp *adsp)
>>> {
>>> struct qcom_scm_vmperm perm;
>>> - int ret;
>>> + int offset, ret;
>>> - if (!adsp->region_assign_idx)
>>> + if (!adsp->region_assign_idx || adsp->region_assign_shared)
>>> return;
>>> - perm.vmid = QCOM_SCM_VMID_HLOS;
>>> - perm.perm = QCOM_SCM_PERM_RW;
>>> + for (offset = 0; offset < adsp->region_assign_count; ++offset) {
>>> + perm.vmid = QCOM_SCM_VMID_HLOS;
>>> + perm.perm = QCOM_SCM_PERM_RW;
>>
>>> - ret = qcom_scm_assign_mem(adsp->region_assign_phys,
>>> - adsp->region_assign_size,
>>> - &adsp->region_assign_perms,
>>> - &perm, 1);
>>> - if (ret < 0)
>>> - dev_err(adsp->dev, "unassign memory failed\n");
>>> + ret = qcom_scm_assign_mem(adsp->region_assign_phys[offset],
>>> + adsp->region_assign_size[offset],
>>> + &adsp->region_assign_perms[offset],
>>> + &perm, 1);
>>> + if (ret < 0)
>>> + dev_err(adsp->dev, "unassign memory failed\n");
>>> + }
>>> }
>>> static int adsp_probe(struct platform_device *pdev)
>>> @@ -696,6 +721,9 @@ static int adsp_probe(struct platform_device *pdev)
>>> adsp->info_name = desc->sysmon_name;
>>> adsp->decrypt_shutdown = desc->decrypt_shutdown;
>>> adsp->region_assign_idx = desc->region_assign_idx;
Should this also need
min_t(int, MAX_ASSIGN_COUNT - 1, desc->region_assign_idx);
as no where boundary check is being done.
-Mukesh
>>> + adsp->region_assign_count = min_t(int, MAX_ASSIGN_COUNT,
>>> desc->region_assign_count);
>>> + adsp->region_assign_vmid = desc->region_assign_vmid;
>>> + adsp->region_assign_shared = desc->region_assign_shared;
>>> if (dtb_fw_name) {
>>> adsp->dtb_firmware_name = dtb_fw_name;
>>> adsp->dtb_pas_id = desc->dtb_pas_id;
>>> @@ -1163,6 +1191,8 @@ static const struct adsp_data
>>> sm8550_mpss_resource = {
>>> .sysmon_name = "modem",
>>> .ssctl_id = 0x12,
>>> .region_assign_idx = 2,
>>> + .region_assign_count = 1,
>>> + .region_assign_vmid = QCOM_SCM_VMID_MSS_MSA,
>>> };
>>> static const struct of_device_id adsp_of_match[] = {
>>>
>>
>> -Mukesh
>
> Thanks,
> Neil
>
On 01/11/2023 15:42, Mukesh Ojha wrote:
>
>
> On 10/31/2023 10:36 PM, Neil Armstrong wrote:
>> Hi,
>>
>> On 30/10/2023 14:10, Mukesh Ojha wrote:
>>>
>>>
>>> On 10/30/2023 3:33 PM, Neil Armstrong wrote:
>>>> The current memory region assign only supports a single
>>>> memory region.
>>>>
>>>> But new platforms introduces more regions to make the
>>>> memory requirements more flexible for various use cases.
>>>> Those new platforms also shares the memory region between the
>>>> DSP and HLOS.
>>>>
>>>> To handle this, make the region assign more generic in order
>>>> to support more than a single memory region and also permit
>>>> setting the regions permissions as shared.
>>>>
>>>> Signed-off-by: Neil Armstrong <[email protected]>
>>>> ---
>>>> drivers/remoteproc/qcom_q6v5_pas.c | 102 ++++++++++++++++++++++++-------------
>>>> 1 file changed, 66 insertions(+), 36 deletions(-)
>>>>
>>>> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
>>>> index 913a5d2068e8..4829fd26e17d 100644
>>>> --- a/drivers/remoteproc/qcom_q6v5_pas.c
>>>> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
>>>> @@ -33,6 +33,8 @@
>>>> #define ADSP_DECRYPT_SHUTDOWN_DELAY_MS 100
>>>> +#define MAX_ASSIGN_COUNT 2
>>>> +
>>>> struct adsp_data {
>>>> int crash_reason_smem;
>>>> const char *firmware_name;
>>>> @@ -51,6 +53,9 @@ struct adsp_data {
>>>> int ssctl_id;
>>>> int region_assign_idx;
>>>> + int region_assign_count;
>>>> + bool region_assign_shared;
>>>> + int region_assign_vmid;
>>>> };
>>>> struct qcom_adsp {
>>>> @@ -87,15 +92,18 @@ struct qcom_adsp {
>>>> phys_addr_t dtb_mem_phys;
>>>> phys_addr_t mem_reloc;
>>>> phys_addr_t dtb_mem_reloc;
>>>> - phys_addr_t region_assign_phys;
>>>> + phys_addr_t region_assign_phys[MAX_ASSIGN_COUNT];
>>>> void *mem_region;
>>>> void *dtb_mem_region;
>>>> size_t mem_size;
>>>> size_t dtb_mem_size;
>>>> - size_t region_assign_size;
>>>> + size_t region_assign_size[MAX_ASSIGN_COUNT];
>>>> int region_assign_idx;
>>>> - u64 region_assign_perms;
>>>> + int region_assign_count;
>>>> + bool region_assign_shared;
>>>> + int region_assign_vmid;
>>>> + u64 region_assign_perms[MAX_ASSIGN_COUNT];
>>>> struct qcom_rproc_glink glink_subdev;
>>>> struct qcom_rproc_subdev smd_subdev;
>>>> @@ -590,37 +598,52 @@ static int adsp_alloc_memory_region(struct qcom_adsp *adsp)
>>>> static int adsp_assign_memory_region(struct qcom_adsp *adsp)
>>>> {
>>>> - struct reserved_mem *rmem = NULL;
>>>> - struct qcom_scm_vmperm perm;
>>>> + struct qcom_scm_vmperm perm[MAX_ASSIGN_COUNT];
>>>> + unsigned int perm_size = 1;
>>>
>>> AFAICS, not need of initialization.
>>
>> Indeed, removed
>>
>>>
>>>> struct device_node *node;
>>>> - int ret;
>>>> + int offset, ret;
>>>
>>> Nit: one variable per line.
>>
>> Done
>>
>>>
>>>> if (!adsp->region_assign_idx)
>>>
>>> Not related to this patch..
>>> Should not this be valid only for > 1 ?
>>
>> I don't understand, only region_assign_idx > 1 triggers a memory_assign,
>> and this check discards configurations with region_assign_idx == 0 as
>> expected.
>
> Ah, you can ignore the comments, I got the intention after commenting
> here ..
>
>>
>>>
>>>
>>>> return 0;
>>>> - node = of_parse_phandle(adsp->dev->of_node, "memory-region", adsp->region_assign_idx);
>>>> - if (node)
>>>> - rmem = of_reserved_mem_lookup(node);
>>>> - of_node_put(node);
>>>> - if (!rmem) {
>>>> - dev_err(adsp->dev, "unable to resolve shareable memory-region\n");
>>>> - return -EINVAL;
>>>> - }
>>>> + for (offset = 0; offset < adsp->region_assign_count; ++offset) {
>>>> + struct reserved_mem *rmem = NULL;
>>>> +
>>>> + node = of_parse_phandle(adsp->dev->of_node, "memory-region",
>>>> + adsp->region_assign_idx + offset);
>>>> + if (node)
>>>> + rmem = of_reserved_mem_lookup(node);
>>>> + of_node_put(node);
>>>> + if (!rmem) {
>>>> + dev_err(adsp->dev, "unable to resolve shareable memory-region index %d\n",
>>>> + offset);
>>>> + return -EINVAL; > + }
>>>
>>>
>>>> - perm.vmid = QCOM_SCM_VMID_MSS_MSA;
>>>> - perm.perm = QCOM_SCM_PERM_RW;
>>>> + if (adsp->region_assign_shared) {
>>>> + perm[0].vmid = QCOM_SCM_VMID_HLOS;
>>>> + perm[0].perm = QCOM_SCM_PERM_RW;
>>>> + perm[1].vmid = adsp->region_assign_vmid;
>>>> + perm[1].perm = QCOM_SCM_PERM_RW;
>>>> + perm_size = 2;
>>>> + } else {
>>>> + perm[0].vmid = adsp->region_assign_vmid;
>>>> + perm[0].perm = QCOM_SCM_PERM_RW;
>>>> + perm_size = 1;
>>>> + }
>>>> - adsp->region_assign_phys = rmem->base;
>>>> - adsp->region_assign_size = rmem->size;
>>>> - adsp->region_assign_perms = BIT(QCOM_SCM_VMID_HLOS);
>>>> + adsp->region_assign_phys[offset] = rmem->base;
>>>> + adsp->region_assign_size[offset] = rmem->size;
>>>> + adsp->region_assign_perms[offset] = BIT(QCOM_SCM_VMID_HLOS);
>>>
>>> Do we need array for this, is this changing ?
>>
>> We need to keep region_assign_perms for unassign, but for the other 2 we would
>> need to duplicate the code from adsp_assign_memory_region into
>> adsp_unassign_memory_region.
>
> Thanks got it.
>
>>
>>>
>>>> - ret = qcom_scm_assign_mem(adsp->region_assign_phys,
>>>> - adsp->region_assign_size,
>>>> - &adsp->region_assign_perms,
>>>> - &perm, 1);
>>>> - if (ret < 0) {
>>>> - dev_err(adsp->dev, "assign memory failed\n");
>>>> - return ret;
>>>> + ret = qcom_scm_assign_mem(adsp->region_assign_phys[offset],
>>>> + adsp->region_assign_size[offset],
>>>> + &adsp->region_assign_perms[offset],
>>>> + perm, perm_size);
>>>> + if (ret < 0) {
>>>> + dev_err(adsp->dev, "assign memory %d failed\n", offset);
>>>> + return ret;
>>>> + }
>>>> }
>>>> return 0;
>>>> @@ -629,20 +652,22 @@ static int adsp_assign_memory_region(struct qcom_adsp *adsp)
>>>> static void adsp_unassign_memory_region(struct qcom_adsp *adsp)
>>>> {
>>>> struct qcom_scm_vmperm perm;
>>>> - int ret;
>>>> + int offset, ret;
>>>> - if (!adsp->region_assign_idx)
>>>> + if (!adsp->region_assign_idx || adsp->region_assign_shared)
>>>> return;
>>>> - perm.vmid = QCOM_SCM_VMID_HLOS;
>>>> - perm.perm = QCOM_SCM_PERM_RW;
>>>> + for (offset = 0; offset < adsp->region_assign_count; ++offset) {
>>>> + perm.vmid = QCOM_SCM_VMID_HLOS;
>>>> + perm.perm = QCOM_SCM_PERM_RW;
>>>
>>>> - ret = qcom_scm_assign_mem(adsp->region_assign_phys,
>>>> - adsp->region_assign_size,
>>>> - &adsp->region_assign_perms,
>>>> - &perm, 1);
>>>> - if (ret < 0)
>>>> - dev_err(adsp->dev, "unassign memory failed\n");
>>>> + ret = qcom_scm_assign_mem(adsp->region_assign_phys[offset],
>>>> + adsp->region_assign_size[offset],
>>>> + &adsp->region_assign_perms[offset],
>>>> + &perm, 1);
>>>> + if (ret < 0)
>>>> + dev_err(adsp->dev, "unassign memory failed\n");
>>>> + }
>>>> }
>>>> static int adsp_probe(struct platform_device *pdev)
>>>> @@ -696,6 +721,9 @@ static int adsp_probe(struct platform_device *pdev)
>>>> adsp->info_name = desc->sysmon_name;
>>>> adsp->decrypt_shutdown = desc->decrypt_shutdown;
>>>> adsp->region_assign_idx = desc->region_assign_idx;
>
> Should this also need
> min_t(int, MAX_ASSIGN_COUNT - 1, desc->region_assign_idx);
> as no where boundary check is being done.
region_idx is the offset in the memory-region DT property where assigned memory starts,
so for example there's 2 memory regions on SM8650 CDSP, but only a single shared memory region
so we have the following:
- region_assign_idx = 2
- region_assign_count = 1
and in DT:
memory-region = <&cdsp_mem>, <&q6_cdsp_dtb_mem>, <&global_sync_mem>;
-------------------------------------------------/\
region_assign_idx
------------------------------------------------[ ]
region_assign_count
and for MPSS, there's 2 of both:
- region_assign_idx = 2
- region_assign_count = 2
and in DT:
memory-region = <&mpss_mem>, <&q6_mpss_dtb_mem>, <&mpss_dsm_mem>, <&mpss_dsm_mem_2>;
-------------------------------------------------/\
region_assign_idx
------------------------------------------------[ ]
region_assign_count
so we cannot add a bounday check.
In any case of_parse_phandle() will do the boundary check if DT has less phandles than expected.
Neil
>
> -Mukesh
>>>> + adsp->region_assign_count = min_t(int, MAX_ASSIGN_COUNT, desc->region_assign_count);
>>>> + adsp->region_assign_vmid = desc->region_assign_vmid;
>>>> + adsp->region_assign_shared = desc->region_assign_shared;
>>>> if (dtb_fw_name) {
>>>> adsp->dtb_firmware_name = dtb_fw_name;
>>>> adsp->dtb_pas_id = desc->dtb_pas_id;
>>>> @@ -1163,6 +1191,8 @@ static const struct adsp_data sm8550_mpss_resource = {
>>>> .sysmon_name = "modem",
>>>> .ssctl_id = 0x12,
>>>> .region_assign_idx = 2,
>>>> + .region_assign_count = 1,
>>>> + .region_assign_vmid = QCOM_SCM_VMID_MSS_MSA,
>>>> };
>>>> static const struct of_device_id adsp_of_match[] = {
>>>>
>>>
>>> -Mukesh
>>
>> Thanks,
>> Neil
>>
On 11/2/2023 3:56 PM, [email protected] wrote:
> On 01/11/2023 15:42, Mukesh Ojha wrote:
>>
>>
>> On 10/31/2023 10:36 PM, Neil Armstrong wrote:
>>> Hi,
>>>
>>> On 30/10/2023 14:10, Mukesh Ojha wrote:
>>>>
>>>>
>>>> On 10/30/2023 3:33 PM, Neil Armstrong wrote:
>>>>> The current memory region assign only supports a single
>>>>> memory region.
>>>>>
>>>>> But new platforms introduces more regions to make the
>>>>> memory requirements more flexible for various use cases.
>>>>> Those new platforms also shares the memory region between the
>>>>> DSP and HLOS.
>>>>>
>>>>> To handle this, make the region assign more generic in order
>>>>> to support more than a single memory region and also permit
>>>>> setting the regions permissions as shared.
>>>>>
>>>>> Signed-off-by: Neil Armstrong <[email protected]>
>>>>> ---
>>>>> drivers/remoteproc/qcom_q6v5_pas.c | 102
>>>>> ++++++++++++++++++++++++-------------
>>>>> 1 file changed, 66 insertions(+), 36 deletions(-)
>>>>>
>>>>> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c
>>>>> b/drivers/remoteproc/qcom_q6v5_pas.c
>>>>> index 913a5d2068e8..4829fd26e17d 100644
>>>>> --- a/drivers/remoteproc/qcom_q6v5_pas.c
>>>>> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
>>>>> @@ -33,6 +33,8 @@
>>>>> #define ADSP_DECRYPT_SHUTDOWN_DELAY_MS 100
>>>>> +#define MAX_ASSIGN_COUNT 2
>>>>> +
>>>>> struct adsp_data {
>>>>> int crash_reason_smem;
>>>>> const char *firmware_name;
>>>>> @@ -51,6 +53,9 @@ struct adsp_data {
>>>>> int ssctl_id;
>>>>> int region_assign_idx;
>>>>> + int region_assign_count;
>>>>> + bool region_assign_shared;
>>>>> + int region_assign_vmid;
>>>>> };
>>>>> struct qcom_adsp {
>>>>> @@ -87,15 +92,18 @@ struct qcom_adsp {
>>>>> phys_addr_t dtb_mem_phys;
>>>>> phys_addr_t mem_reloc;
>>>>> phys_addr_t dtb_mem_reloc;
>>>>> - phys_addr_t region_assign_phys;
>>>>> + phys_addr_t region_assign_phys[MAX_ASSIGN_COUNT];
>>>>> void *mem_region;
>>>>> void *dtb_mem_region;
>>>>> size_t mem_size;
>>>>> size_t dtb_mem_size;
>>>>> - size_t region_assign_size;
>>>>> + size_t region_assign_size[MAX_ASSIGN_COUNT];
>>>>> int region_assign_idx;
>>>>> - u64 region_assign_perms;
>>>>> + int region_assign_count;
>>>>> + bool region_assign_shared;
>>>>> + int region_assign_vmid;
>>>>> + u64 region_assign_perms[MAX_ASSIGN_COUNT];
>>>>> struct qcom_rproc_glink glink_subdev;
>>>>> struct qcom_rproc_subdev smd_subdev;
>>>>> @@ -590,37 +598,52 @@ static int adsp_alloc_memory_region(struct
>>>>> qcom_adsp *adsp)
>>>>> static int adsp_assign_memory_region(struct qcom_adsp *adsp)
>>>>> {
>>>>> - struct reserved_mem *rmem = NULL;
>>>>> - struct qcom_scm_vmperm perm;
>>>>> + struct qcom_scm_vmperm perm[MAX_ASSIGN_COUNT];
>>>>> + unsigned int perm_size = 1;
>>>>
>>>> AFAICS, not need of initialization.
>>>
>>> Indeed, removed
>>>
>>>>
>>>>> struct device_node *node;
>>>>> - int ret;
>>>>> + int offset, ret;
>>>>
>>>> Nit: one variable per line.
>>>
>>> Done
>>>
>>>>
>>>>> if (!adsp->region_assign_idx)
>>>>
>>>> Not related to this patch..
>>>> Should not this be valid only for > 1 ?
>>>
>>> I don't understand, only region_assign_idx > 1 triggers a memory_assign,
>>> and this check discards configurations with region_assign_idx == 0 as
>>> expected.
>>
>> Ah, you can ignore the comments, I got the intention after commenting
>> here ..
>>
>>>
>>>>
>>>>
>>>>> return 0;
>>>>> - node = of_parse_phandle(adsp->dev->of_node, "memory-region",
>>>>> adsp->region_assign_idx);
>>>>> - if (node)
>>>>> - rmem = of_reserved_mem_lookup(node);
>>>>> - of_node_put(node);
>>>>> - if (!rmem) {
>>>>> - dev_err(adsp->dev, "unable to resolve shareable
>>>>> memory-region\n");
>>>>> - return -EINVAL;
>>>>> - }
>>>>> + for (offset = 0; offset < adsp->region_assign_count; ++offset) {
>>>>> + struct reserved_mem *rmem = NULL;
>>>>> +
>>>>> + node = of_parse_phandle(adsp->dev->of_node, "memory-region",
>>>>> + adsp->region_assign_idx + offset);
>>>>> + if (node)
>>>>> + rmem = of_reserved_mem_lookup(node);
>>>>> + of_node_put(node);
>>>>> + if (!rmem) {
>>>>> + dev_err(adsp->dev, "unable to resolve shareable
>>>>> memory-region index %d\n",
>>>>> + offset);
>>>>> + return -EINVAL; > + }
>>>>
>>>>
>>>>> - perm.vmid = QCOM_SCM_VMID_MSS_MSA;
>>>>> - perm.perm = QCOM_SCM_PERM_RW;
>>>>> + if (adsp->region_assign_shared) {
>>>>> + perm[0].vmid = QCOM_SCM_VMID_HLOS;
>>>>> + perm[0].perm = QCOM_SCM_PERM_RW;
>>>>> + perm[1].vmid = adsp->region_assign_vmid;
>>>>> + perm[1].perm = QCOM_SCM_PERM_RW;
>>>>> + perm_size = 2;
>>>>> + } else {
>>>>> + perm[0].vmid = adsp->region_assign_vmid;
>>>>> + perm[0].perm = QCOM_SCM_PERM_RW;
>>>>> + perm_size = 1;
>>>>> + }
>>>>> - adsp->region_assign_phys = rmem->base;
>>>>> - adsp->region_assign_size = rmem->size;
>>>>> - adsp->region_assign_perms = BIT(QCOM_SCM_VMID_HLOS);
>>>>> + adsp->region_assign_phys[offset] = rmem->base;
>>>>> + adsp->region_assign_size[offset] = rmem->size;
>>>>> + adsp->region_assign_perms[offset] = BIT(QCOM_SCM_VMID_HLOS);
>>>>
>>>> Do we need array for this, is this changing ?
>>>
>>> We need to keep region_assign_perms for unassign, but for the other 2
>>> we would
>>> need to duplicate the code from adsp_assign_memory_region into
>>> adsp_unassign_memory_region.
>>
>> Thanks got it.
>>
>>>
>>>>
>>>>> - ret = qcom_scm_assign_mem(adsp->region_assign_phys,
>>>>> - adsp->region_assign_size,
>>>>> - &adsp->region_assign_perms,
>>>>> - &perm, 1);
>>>>> - if (ret < 0) {
>>>>> - dev_err(adsp->dev, "assign memory failed\n");
>>>>> - return ret;
>>>>> + ret = qcom_scm_assign_mem(adsp->region_assign_phys[offset],
>>>>> + adsp->region_assign_size[offset],
>>>>> + &adsp->region_assign_perms[offset],
>>>>> + perm, perm_size);
>>>>> + if (ret < 0) {
>>>>> + dev_err(adsp->dev, "assign memory %d failed\n", offset);
>>>>> + return ret;
>>>>> + }
>>>>> }
>>>>> return 0;
>>>>> @@ -629,20 +652,22 @@ static int adsp_assign_memory_region(struct
>>>>> qcom_adsp *adsp)
>>>>> static void adsp_unassign_memory_region(struct qcom_adsp *adsp)
>>>>> {
>>>>> struct qcom_scm_vmperm perm;
>>>>> - int ret;
>>>>> + int offset, ret;
>>>>> - if (!adsp->region_assign_idx)
>>>>> + if (!adsp->region_assign_idx || adsp->region_assign_shared)
>>>>> return;
>>>>> - perm.vmid = QCOM_SCM_VMID_HLOS;
>>>>> - perm.perm = QCOM_SCM_PERM_RW;
>>>>> + for (offset = 0; offset < adsp->region_assign_count; ++offset) {
>>>>> + perm.vmid = QCOM_SCM_VMID_HLOS;
>>>>> + perm.perm = QCOM_SCM_PERM_RW;
>>>>
>>>>> - ret = qcom_scm_assign_mem(adsp->region_assign_phys,
>>>>> - adsp->region_assign_size,
>>>>> - &adsp->region_assign_perms,
>>>>> - &perm, 1);
>>>>> - if (ret < 0)
>>>>> - dev_err(adsp->dev, "unassign memory failed\n");
>>>>> + ret = qcom_scm_assign_mem(adsp->region_assign_phys[offset],
>>>>> + adsp->region_assign_size[offset],
>>>>> + &adsp->region_assign_perms[offset],
>>>>> + &perm, 1);
>>>>> + if (ret < 0)
>>>>> + dev_err(adsp->dev, "unassign memory failed\n");
>>>>> + }
>>>>> }
>>>>> static int adsp_probe(struct platform_device *pdev)
>>>>> @@ -696,6 +721,9 @@ static int adsp_probe(struct platform_device
>>>>> *pdev)
>>>>> adsp->info_name = desc->sysmon_name;
>>>>> adsp->decrypt_shutdown = desc->decrypt_shutdown;
>>>>> adsp->region_assign_idx = desc->region_assign_idx;
>>
>> Should this also need
>> min_t(int, MAX_ASSIGN_COUNT - 1, desc->region_assign_idx);
>> as no where boundary check is being done.
I was wrong here.. MAX_ASSIGN_COUNT was relative to assign index.
>
> region_idx is the offset in the memory-region DT property where assigned
> memory starts,
> so for example there's 2 memory regions on SM8650 CDSP, but only a
> single shared memory region
> so we have the following:
> - region_assign_idx = 2
> - region_assign_count = 1
> and in DT:
> memory-region = <&cdsp_mem>, <&q6_cdsp_dtb_mem>, <&global_sync_mem>;
> -------------------------------------------------/\
> region_assign_idx
> ------------------------------------------------[ ]
> region_assign_count
>
> and for MPSS, there's 2 of both:
> - region_assign_idx = 2
> - region_assign_count = 2
> and in DT:
> memory-region = <&mpss_mem>, <&q6_mpss_dtb_mem>, <&mpss_dsm_mem>,
> <&mpss_dsm_mem_2>;
> -------------------------------------------------/\
> region_assign_idx
>
> ------------------------------------------------[ ]
> region_assign_count
>
> so we cannot add a bounday check.
>
> In any case of_parse_phandle() will do the boundary check if DT has less
> phandles than expected.
Thanks for explaining.
-Mukesh
>
> Neil
>
>>
>> -Mukesh
>>>>> + adsp->region_assign_count = min_t(int, MAX_ASSIGN_COUNT,
>>>>> desc->region_assign_count);
>>>>> + adsp->region_assign_vmid = desc->region_assign_vmid;
>>>>> + adsp->region_assign_shared = desc->region_assign_shared;
>>>>> if (dtb_fw_name) {
>>>>> adsp->dtb_firmware_name = dtb_fw_name;
>>>>> adsp->dtb_pas_id = desc->dtb_pas_id;
>>>>> @@ -1163,6 +1191,8 @@ static const struct adsp_data
>>>>> sm8550_mpss_resource = {
>>>>> .sysmon_name = "modem",
>>>>> .ssctl_id = 0x12,
>>>>> .region_assign_idx = 2,
>>>>> + .region_assign_count = 1,
>>>>> + .region_assign_vmid = QCOM_SCM_VMID_MSS_MSA,
>>>>> };
>>>>> static const struct of_device_id adsp_of_match[] = {
>>>>>
>>>>
>>>> -Mukesh
>>>
>>> Thanks,
>>> Neil
>>>
>