2017-06-23 10:12:05

by Arvind Yadav

Subject: [PATCH] irqchip: irq-gic-v3-its-pci-msi: make of_device_ids const

of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/irqchip/irq-gic-v3-its-pci-msi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v3-its-pci-msi.c b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
index aee1c60..44f80ec 100644
--- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c
+++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
@@ -102,7 +102,7 @@ static int its_pci_msi_prepare(struct irq_domain *domain, struct device *dev,
.chip = &its_msi_irq_chip,
};

-static struct of_device_id its_device_id[] = {
+static const struct of_device_id its_device_id[] = {
{ .compatible = "arm,gic-v3-its", },
{},
};
--
1.9.1

2017-06-23 10:24:57

by Marc Zyngier

Subject: Re: [PATCH] irqchip: irq-gic-v3-its-pci-msi: make of_device_ids const

On 23/06/17 11:11, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <[email protected]>
> ---
> drivers/irqchip/irq-gic-v3-its-pci-msi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-gic-v3-its-pci-msi.c b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
> index aee1c60..44f80ec 100644
> --- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c
> +++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
> @@ -102,7 +102,7 @@ static int its_pci_msi_prepare(struct irq_domain *domain, struct device *dev,
> .chip = &its_msi_irq_chip,
> };
>
> -static struct of_device_id its_device_id[] = {
> +static const struct of_device_id its_device_id[] = {
> { .compatible = "arm,gic-v3-its", },
> {},
> };
>

I already sent the pull request to Thomas, so this one will have to
wait. In general, it'd be better if you sent these fixes as a series for
a given subsystem rather than one or two patches every other day.

Thanks,

M.
--
Jazz is not dead. It just smells funny...

2017-06-23 10:30:32

by Arvind Yadav

Subject: Re: [PATCH] irqchip: irq-gic-v3-its-pci-msi: make of_device_ids const

Hi,

Ok, Next time I will push all fixes patch together,

Thanks,
~arvind


On Friday 23 June 2017 03:54 PM, Marc Zyngier wrote:
> On 23/06/17 11:11, Arvind Yadav wrote:
>> of_device_ids are not supposed to change at runtime. All functions
>> working with of_device_ids provided by <linux/of.h> work with const
>> of_device_ids. So mark the non-const structs as const.
>>
>> Signed-off-by: Arvind Yadav <[email protected]>
>> ---
>> drivers/irqchip/irq-gic-v3-its-pci-msi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/irq-gic-v3-its-pci-msi.c b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
>> index aee1c60..44f80ec 100644
>> --- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c
>> +++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
>> @@ -102,7 +102,7 @@ static int its_pci_msi_prepare(struct irq_domain *domain, struct device *dev,
>> .chip = &its_msi_irq_chip,
>> };
>>
>> -static struct of_device_id its_device_id[] = {
>> +static const struct of_device_id its_device_id[] = {
>> { .compatible = "arm,gic-v3-its", },
>> {},
>> };
>>
> I already sent the pull request to Thomas, so this one will have to
> wait. In general, it'd be better if you sent these fixes as a series for
> a given subsystem rather than one or two patches every other day.
>
> Thanks,
>
> M.