Subject: [PATCH] platform: x86: pcengines-apuv2: detect apuv4 board

GPIO stuff on APUv4 seems to be the same as on APUv2, so we just
need to match on DMI data.

Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe
---
drivers/platform/x86/pcengines-apuv2.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)

diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
index e4c68ef..ea0c6bb 100644
--- a/drivers/platform/x86/pcengines-apuv2.c
+++ b/drivers/platform/x86/pcengines-apuv2.c
@@ -178,6 +178,33 @@
},
.driver_data = (void *)&board_apu2,
},
+ /* APU4 w/ legacy bios < 4.0.8 */
+ {
+ .ident = "apu4",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
+ DMI_MATCH(DMI_BOARD_NAME, "APU4")
+ },
+ .driver_data = (void *)&board_apu2,
+ },
+ /* APU4 w/ legacy bios >= 4.0.8 */
+ {
+ .ident = "apu4",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
+ DMI_MATCH(DMI_BOARD_NAME, "apu4")
+ },
+ .driver_data = (void *)&board_apu2,
+ },
+ /* APU4 w/ mainline bios */
+ {
+ .ident = "apu4",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
+ DMI_MATCH(DMI_BOARD_NAME, "PC Engines apu4")
+ },
+ .driver_data = (void *)&board_apu2,
+ },
{}
};

--
1.9.1


2019-08-23 13:11:53

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH] platform: x86: pcengines-apuv2: detect apuv4 board

On Tue, Aug 20, 2019 at 12:56 PM Enrico Weigelt, metux IT consult
<[email protected]> wrote:
>
> GPIO stuff on APUv4 seems to be the same as on APUv2, so we just
> need to match on DMI data.
>

> Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe

Wrong format.

W/o SoB tag I can't take it.

--
With Best Regards,
Andy Shevchenko

Subject: Re: [PATCH] platform: x86: pcengines-apuv2: detect apuv4 board

On 22.08.19 21:47, Andy Shevchenko wrote:

>> Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe
>
> Wrong format.
>
> W/o SoB tag I can't take it.

What's the correct format (what command shall I use to
create it correctly ?)


--mtx

--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
[email protected] -- +49-151-27565287

2019-09-09 03:37:42

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH] platform: x86: pcengines-apuv2: detect apuv4 board

On Wed, Aug 28, 2019 at 2:37 PM Enrico Weigelt, metux IT consult
<[email protected]> wrote:
>
> On 22.08.19 21:47, Andy Shevchenko wrote:
>
> >> Fixes: f8eb0235f65989fc5521c40c78d1261e7f25cdbe
> >
> > Wrong format.
> >
> > W/o SoB tag I can't take it.
>
> What's the correct format (what command shall I use to
> create it correctly ?)

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Section 11

And for this one Fixes is not needed. The APUv4 never worked before, correct?


--
With Best Regards,
Andy Shevchenko