2023-06-02 11:43:26

by Geert Uytterhoeven

[permalink] [raw]

Subject: [PATCH] drm/todo: Fix corrupted duplicate in defio section

---

Part of the paragraph was accidentally duplicated.

Fixes: be5cadc7e7b4cee8 ("drm/todo: Better defio support in the generic fbdev emulation")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
Documentation/gpu/todo.rst | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 66736db00e6d182d..c25e3cdbe964967a 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -312,8 +312,7 @@ everything after it has done the write-protect/mkwrite trickery:

- Set the mkwrite and fsync callbacks with similar implementions to the core
fbdev defio stuff. These should all work on plain ptes, they don't actually
- require a struct page. uff. These should all work on plain ptes, they don't
- actually require a struct page.
+ require a struct page.

- Track the dirty pages in a separate structure (bitfield with one bit per page
should work) to avoid clobbering struct page.
--
2.34.1

2023-06-02 12:17:49

by Thomas Zimmermann

[permalink] [raw]

Subject: Re: [PATCH] drm/todo: Fix corrupted duplicate in defio section

---

Hi

Am 02.06.23 um 13:30 schrieb Geert Uytterhoeven:
> Part of the paragraph was accidentally duplicated.

This TODO item is mostly obsolete. It should be removed.

Best regards
Thomas

>
> Fixes: be5cadc7e7b4cee8 ("drm/todo: Better defio support in the generic fbdev emulation")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> Documentation/gpu/todo.rst | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 66736db00e6d182d..c25e3cdbe964967a 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -312,8 +312,7 @@ everything after it has done the write-protect/mkwrite trickery:
>
> - Set the mkwrite and fsync callbacks with similar implementions to the core
> fbdev defio stuff. These should all work on plain ptes, they don't actually
> - require a struct page. uff. These should all work on plain ptes, they don't
> - actually require a struct page.
> + require a struct page.
>
> - Track the dirty pages in a separate structure (bitfield with one bit per page
> should work) to avoid clobbering struct page.

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

---

Attachments:

OpenPGP_signature (855.00 B)
OpenPGP digital signature