2018-06-12 23:25:44

by Shuah Khan

Subject: [PATCH] selftests: sparc64: delete RUN_TESTS and EMIT_TESTS overrides

Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
lib.mk. Common defines work just fine and there is no need to define
custom overrides.

Signed-off-by: Shuah Khan (Samsung OSG) <[email protected]>
---
tools/testing/selftests/sparc64/Makefile | 8 --------
1 file changed, 8 deletions(-)

diff --git a/tools/testing/selftests/sparc64/Makefile b/tools/testing/selftests/sparc64/Makefile
index 442f0ca45441..76b2206932c3 100644
--- a/tools/testing/selftests/sparc64/Makefile
+++ b/tools/testing/selftests/sparc64/Makefile
@@ -28,10 +28,6 @@ all:
fi \
done

-override define RUN_TESTS
- @cd $(OUTPUT); ./run.sh
-endef
-
override define INSTALL_RULE
mkdir -p $(INSTALL_PATH)
install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)
@@ -43,10 +39,6 @@ override define INSTALL_RULE
done;
endef

-override define EMIT_TESTS
- echo "./run.sh"
-endef
-
override define CLEAN
@for DIR in $(SUBDIRS); do \
BUILD_TARGET=$(OUTPUT)/$$DIR; \
--
2.17.0

2018-06-13 17:19:35

by Tom Hromatka

Subject: Re: [PATCH] selftests: sparc64: delete RUN_TESTS and EMIT_TESTS overrides

Thanks for the clean up, Shuah.  Looks good to me.

Tom



On 06/12/2018 05:24 PM, Shuah Khan (Samsung OSG) wrote:
> Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
> lib.mk. Common defines work just fine and there is no need to define
> custom overrides.
>
> Signed-off-by: Shuah Khan (Samsung OSG) <[email protected]>

Reviewed-by: Tom Hromatka <[email protected]>

2018-06-15 16:40:02

by Shuah Khan

Subject: Re: [PATCH] selftests: sparc64: delete RUN_TESTS and EMIT_TESTS overrides

On 06/13/2018 11:18 AM, Tom Hromatka wrote:
> Thanks for the clean up, Shuah.  Looks good to me.
>
> Tom
>
>
>
> On 06/12/2018 05:24 PM, Shuah Khan (Samsung OSG) wrote:
>> Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
>> lib.mk. Common defines work just fine and there is no need to define
>> custom overrides.
>>
>> Signed-off-by: Shuah Khan (Samsung OSG) <[email protected]>
>
> Reviewed-by: Tom Hromatka <[email protected]>
>
>

get_maintainers didn't include your name for this patch. Would you like to
take this fix through sparc tree? This is cleanup fix would be good candidate
for 4.18-rc2

If so, please let me know if you would like me to resend the patch
with Tom's Reviewed-by tag.

thanks,
-- Shuah