2023-07-28 14:26:18

by Yue Haibing

Subject: [PATCH -next] mfd: max77686: Remove unused extern declarations

max77686_irq_init() and max77686_irq_exit() are not used since
commit 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq").
And max77686_irq_resume() never be implemented since introduced in
commit dae8a969d512 ("mfd: Add Maxim 77686 driver").

Signed-off-by: Yue Haibing <[email protected]>
---
include/linux/mfd/max77686-private.h | 4 ----
1 file changed, 4 deletions(-)

diff --git a/include/linux/mfd/max77686-private.h b/include/linux/mfd/max77686-private.h
index 3acceeedbaba..ea635d12a741 100644
--- a/include/linux/mfd/max77686-private.h
+++ b/include/linux/mfd/max77686-private.h
@@ -441,8 +441,4 @@ enum max77686_types {
TYPE_MAX77802,
};

-extern int max77686_irq_init(struct max77686_dev *max77686);
-extern void max77686_irq_exit(struct max77686_dev *max77686);
-extern int max77686_irq_resume(struct max77686_dev *max77686);
-
#endif /* __LINUX_MFD_MAX77686_PRIV_H */
--
2.34.1

2023-07-28 15:33:34

by Krzysztof Kozlowski

Subject: Re: [PATCH -next] mfd: max77686: Remove unused extern declarations

On 28/07/2023 15:27, Yue Haibing wrote:
> max77686_irq_init() and max77686_irq_exit() are not used since
> commit 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq").
> And max77686_irq_resume() never be implemented since introduced in
> commit dae8a969d512 ("mfd: Add Maxim 77686 driver").
>
> Signed-off-by: Yue Haibing <[email protected]>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-07-28 23:25:51

by Chanwoo Choi

Subject: Re: [PATCH -next] mfd: max77686: Remove unused extern declarations

On 23. 7. 28. 22:27, Yue Haibing wrote:
> max77686_irq_init() and max77686_irq_exit() are not used since
> commit 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq").
> And max77686_irq_resume() never be implemented since introduced in
> commit dae8a969d512 ("mfd: Add Maxim 77686 driver").
>
> Signed-off-by: Yue Haibing <[email protected]>
> ---
> include/linux/mfd/max77686-private.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/linux/mfd/max77686-private.h b/include/linux/mfd/max77686-private.h
> index 3acceeedbaba..ea635d12a741 100644
> --- a/include/linux/mfd/max77686-private.h
> +++ b/include/linux/mfd/max77686-private.h
> @@ -441,8 +441,4 @@ enum max77686_types {
> TYPE_MAX77802,
> };
>
> -extern int max77686_irq_init(struct max77686_dev *max77686);
> -extern void max77686_irq_exit(struct max77686_dev *max77686);
> -extern int max77686_irq_resume(struct max77686_dev *max77686);
> -
> #endif /* __LINUX_MFD_MAX77686_PRIV_H */

Reviewed-by: Chanwoo Choi <[email protected]>
--
Best Regards,
Samsung Electronics
Chanwoo Choi

2023-08-17 22:13:52

by Lee Jones

Subject: Re: (subset) [PATCH -next] mfd: max77686: Remove unused extern declarations

On Fri, 28 Jul 2023 21:27:09 +0800, Yue Haibing wrote:
> max77686_irq_init() and max77686_irq_exit() are not used since
> commit 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq").
> And max77686_irq_resume() never be implemented since introduced in
> commit dae8a969d512 ("mfd: Add Maxim 77686 driver").
>
>

Applied, thanks!

[1/1] mfd: max77686: Remove unused extern declarations
commit: 23f033eb371762d7f8d78172ab0bddd4d3bec626

--
Lee Jones [李琼斯]