2024-02-27 14:37:18

by Krzysztof Kozlowski

Subject: [PATCH 1/3] arm64: dts: qcom: x1e80100: correct SWR1 pack mode

Correct the SWR1 Soundwire controller port block pack mode to match
reference code. Not sure if this has any impact.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/x1e80100.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index c6b025503f4f..be4d2674151a 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -3430,7 +3430,7 @@ swr1: soundwire@6ad0000 {
qcom,ports-hstart = /bits/ 8 <0xff 0x03 0x00 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff>;
qcom,ports-hstop = /bits/ 8 <0xff 0x06 0x0f 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff>;
qcom,ports-word-length = /bits/ 8 <0x01 0x07 0x04 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff>;
- qcom,ports-block-pack-mode = /bits/ 8 <0xff 0x00 0x01 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff>;
+ qcom,ports-block-pack-mode = /bits/ 8 <0xff 0xff 0x01 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff>;
qcom,ports-block-group-count = /bits/ 8 <0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff>;
qcom,ports-lane-control = /bits/ 8 <0x01 0x00 0x00 0x00 0x00 0xff 0xff 0xff 0xff 0xff 0xff 0xff>;

--
2.34.1

2024-02-27 14:57:42

by Krzysztof Kozlowski

Subject: [PATCH 3/3] arm64: defconfig: enable reset-gpio driver as module

Qualcomm X1E80100-CRD board uses shared reset GPIOs for speakers: each
pair out of four speakers share the GPIO. Enable the reset-gpio driver
which handles such case seamlessly.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 3f44aebafda8..746ea4499e72 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1473,6 +1473,7 @@ CONFIG_PWM_VISCONTI=m
CONFIG_SL28CPLD_INTC=y
CONFIG_QCOM_PDC=y
CONFIG_QCOM_MPM=y
+CONFIG_RESET_GPIO=m
CONFIG_RESET_IMX7=y
CONFIG_RESET_QCOM_AOSS=y
CONFIG_RESET_QCOM_PDC=m
--
2.34.1

2024-03-02 00:02:26

by Konrad Dybcio

Subject: Re: [PATCH 1/3] arm64: dts: qcom: x1e80100: correct SWR1 pack mode

On 27.02.2024 15:27, Krzysztof Kozlowski wrote:
> Correct the SWR1 Soundwire controller port block pack mode to match
> reference code. Not sure if this has any impact.

Probably it falls into the "undebuggable if present" kind of issues..

>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

I'm assuming your new source is correct-er

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad

2024-03-02 00:02:50

by Konrad Dybcio

Subject: Re: [PATCH 3/3] arm64: defconfig: enable reset-gpio driver as module

On 27.02.2024 15:27, Krzysztof Kozlowski wrote:
> Qualcomm X1E80100-CRD board uses shared reset GPIOs for speakers: each
> pair out of four speakers share the GPIO. Enable the reset-gpio driver
> which handles such case seamlessly.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad

2024-03-19 02:51:19

by Bjorn Andersson

Subject: Re: (subset) [PATCH 1/3] arm64: dts: qcom: x1e80100: correct SWR1 pack mode

On Tue, 27 Feb 2024 15:27:23 +0100, Krzysztof Kozlowski wrote:
> Correct the SWR1 Soundwire controller port block pack mode to match
> reference code. Not sure if this has any impact.
>
>

Applied, thanks!

[3/3] arm64: defconfig: enable reset-gpio driver as module
commit: cf30987a9ae9a8a430f957f8516b2092f6bab29d

Best regards,
--
Bjorn Andersson <[email protected]>