2018-11-25 23:13:12

by Colin King

Subject: [PATCH] ALSA: usb-audio: fix spelling mistake "Frequence" -> "Frequency"

From: Colin Ian King <[email protected]>

There are spelling mistakes in equalizer name fields, fix them.

Signed-off-by: Colin Ian King <[email protected]>
---
sound/usb/mixer_us16x08.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/usb/mixer_us16x08.c b/sound/usb/mixer_us16x08.c
index 26ed23b18b77..4f594f9552a8 100644
--- a/sound/usb/mixer_us16x08.c
+++ b/sound/usb/mixer_us16x08.c
@@ -1119,7 +1119,7 @@ static const struct snd_us16x08_control_params eq_controls[] = {
.control_id = SND_US16X08_ID_EQLOWFREQ,
.type = USB_MIXER_U8,
.num_channels = 16,
- .name = "EQ Low Frequence",
+ .name = "EQ Low Frequency",
},
{ /* EQ mid low gain */
.kcontrol_new = &snd_us16x08_eq_gain_ctl,
@@ -1133,7 +1133,7 @@ static const struct snd_us16x08_control_params eq_controls[] = {
.control_id = SND_US16X08_ID_EQLOWMIDFREQ,
.type = USB_MIXER_U8,
.num_channels = 16,
- .name = "EQ MidLow Frequence",
+ .name = "EQ MidLow Frequency",
},
{ /* EQ mid low Q */
.kcontrol_new = &snd_us16x08_eq_mid_width_ctl,
@@ -1154,7 +1154,7 @@ static const struct snd_us16x08_control_params eq_controls[] = {
.control_id = SND_US16X08_ID_EQHIGHMIDFREQ,
.type = USB_MIXER_U8,
.num_channels = 16,
- .name = "EQ MidHigh Frequence",
+ .name = "EQ MidHigh Frequency",
},
{ /* EQ mid high Q */
.kcontrol_new = &snd_us16x08_eq_mid_width_ctl,
@@ -1175,7 +1175,7 @@ static const struct snd_us16x08_control_params eq_controls[] = {
.control_id = SND_US16X08_ID_EQHIGHFREQ,
.type = USB_MIXER_U8,
.num_channels = 16,
- .name = "EQ High Frequence",
+ .name = "EQ High Frequency",
},
};

--
2.19.1

2018-11-26 08:28:22

by Takashi Iwai

Subject: Re: [PATCH] ALSA: usb-audio: fix spelling mistake "Frequence" -> "Frequency"

On Mon, 26 Nov 2018 00:12:08 +0100,
Colin King wrote:
>
> From: Colin Ian King <[email protected]>
>
> There are spelling mistakes in equalizer name fields, fix them.
>
> Signed-off-by: Colin Ian King <[email protected]>

In general, it's not good to rename the control names even if they are
fixes. But these are rather device-specific ones, and they are EQ's,
which aren't too fatal to change, so I took it as-is now.


thanks,

Takashi


> ---
> sound/usb/mixer_us16x08.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/usb/mixer_us16x08.c b/sound/usb/mixer_us16x08.c
> index 26ed23b18b77..4f594f9552a8 100644
> --- a/sound/usb/mixer_us16x08.c
> +++ b/sound/usb/mixer_us16x08.c
> @@ -1119,7 +1119,7 @@ static const struct snd_us16x08_control_params eq_controls[] = {
> .control_id = SND_US16X08_ID_EQLOWFREQ,
> .type = USB_MIXER_U8,
> .num_channels = 16,
> - .name = "EQ Low Frequence",
> + .name = "EQ Low Frequency",
> },
> { /* EQ mid low gain */
> .kcontrol_new = &snd_us16x08_eq_gain_ctl,
> @@ -1133,7 +1133,7 @@ static const struct snd_us16x08_control_params eq_controls[] = {
> .control_id = SND_US16X08_ID_EQLOWMIDFREQ,
> .type = USB_MIXER_U8,
> .num_channels = 16,
> - .name = "EQ MidLow Frequence",
> + .name = "EQ MidLow Frequency",
> },
> { /* EQ mid low Q */
> .kcontrol_new = &snd_us16x08_eq_mid_width_ctl,
> @@ -1154,7 +1154,7 @@ static const struct snd_us16x08_control_params eq_controls[] = {
> .control_id = SND_US16X08_ID_EQHIGHMIDFREQ,
> .type = USB_MIXER_U8,
> .num_channels = 16,
> - .name = "EQ MidHigh Frequence",
> + .name = "EQ MidHigh Frequency",
> },
> { /* EQ mid high Q */
> .kcontrol_new = &snd_us16x08_eq_mid_width_ctl,
> @@ -1175,7 +1175,7 @@ static const struct snd_us16x08_control_params eq_controls[] = {
> .control_id = SND_US16X08_ID_EQHIGHFREQ,
> .type = USB_MIXER_U8,
> .num_channels = 16,
> - .name = "EQ High Frequence",
> + .name = "EQ High Frequency",
> },
> };
>
> --
> 2.19.1
>
>

2020-10-02 09:27:59

by Jaroslav Kysela

Subject: Re: [PATCH] ALSA: usb-audio: fix spelling mistake "Frequence" -> "Frequency"

Dne 26. 11. 18 v 9:27 Takashi Iwai napsal(a):
> On Mon, 26 Nov 2018 00:12:08 +0100,
> Colin King wrote:
>>
>> From: Colin Ian King <[email protected]>
>>
>> There are spelling mistakes in equalizer name fields, fix them.
>>
>> Signed-off-by: Colin Ian King <[email protected]>
>
> In general, it's not good to rename the control names even if they are
> fixes. But these are rather device-specific ones, and they are EQ's,
> which aren't too fatal to change, so I took it as-is now.

It seems that this patch has not found a way to kernel. It is present
in #master at git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git,
but it is not present in linux-next.

Thanks,
Jaroslav

>
>
> thanks,
>
> Takashi
>
>
>> ---
>> sound/usb/mixer_us16x08.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/sound/usb/mixer_us16x08.c b/sound/usb/mixer_us16x08.c
>> index 26ed23b18b77..4f594f9552a8 100644
>> --- a/sound/usb/mixer_us16x08.c
>> +++ b/sound/usb/mixer_us16x08.c
>> @@ -1119,7 +1119,7 @@ static const struct snd_us16x08_control_params eq_controls[] = {
>> .control_id = SND_US16X08_ID_EQLOWFREQ,
>> .type = USB_MIXER_U8,
>> .num_channels = 16,
>> - .name = "EQ Low Frequence",
>> + .name = "EQ Low Frequency",
>> },
>> { /* EQ mid low gain */
>> .kcontrol_new = &snd_us16x08_eq_gain_ctl,
>> @@ -1133,7 +1133,7 @@ static const struct snd_us16x08_control_params eq_controls[] = {
>> .control_id = SND_US16X08_ID_EQLOWMIDFREQ,
>> .type = USB_MIXER_U8,
>> .num_channels = 16,
>> - .name = "EQ MidLow Frequence",
>> + .name = "EQ MidLow Frequency",
>> },
>> { /* EQ mid low Q */
>> .kcontrol_new = &snd_us16x08_eq_mid_width_ctl,
>> @@ -1154,7 +1154,7 @@ static const struct snd_us16x08_control_params eq_controls[] = {
>> .control_id = SND_US16X08_ID_EQHIGHMIDFREQ,
>> .type = USB_MIXER_U8,
>> .num_channels = 16,
>> - .name = "EQ MidHigh Frequence",
>> + .name = "EQ MidHigh Frequency",
>> },
>> { /* EQ mid high Q */
>> .kcontrol_new = &snd_us16x08_eq_mid_width_ctl,
>> @@ -1175,7 +1175,7 @@ static const struct snd_us16x08_control_params eq_controls[] = {
>> .control_id = SND_US16X08_ID_EQHIGHFREQ,
>> .type = USB_MIXER_U8,
>> .num_channels = 16,
>> - .name = "EQ High Frequence",
>> + .name = "EQ High Frequency",
>> },
>> };
>>
>> --
>> 2.19.1
>>
>>


--
Jaroslav Kysela <[email protected]>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

2020-10-02 09:28:57

by Takashi Iwai

Subject: Re: [PATCH] ALSA: usb-audio: fix spelling mistake "Frequence" -> "Frequency"

On Fri, 02 Oct 2020 11:18:46 +0200,
Jaroslav Kysela wrote:
>
> Dne 26. 11. 18 v 9:27 Takashi Iwai napsal(a):
> > On Mon, 26 Nov 2018 00:12:08 +0100,
> > Colin King wrote:
> >>
> >> From: Colin Ian King <[email protected]>
> >>
> >> There are spelling mistakes in equalizer name fields, fix them.
> >>
> >> Signed-off-by: Colin Ian King <[email protected]>
> >
> > In general, it's not good to rename the control names even if they are
> > fixes. But these are rather device-specific ones, and they are EQ's,
> > which aren't too fatal to change, so I took it as-is now.
>
> It seems that this patch has not found a way to kernel. It is present
> in #master at git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git,
> but it is not present in linux-next.

Indeed, it was applied to a wrong branch. I cherry-picked now.
Thanks!


Takashi