2022-01-07 10:09:23

by Hui Su

[permalink] [raw]
Subject: [PATCH] kernel/sched: remove dl_boosted flag comment

since commit 2279f540ea7d ("sched/deadline: Fix priority
inheritance with multiple scheduling classes"), we should not
keep it here.

Signed-off-by: Hui Su <[email protected]>
---
include/linux/sched.h | 4 ----
1 file changed, 4 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index 78c351e35fec..64426351d424 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -610,10 +610,6 @@ struct sched_dl_entity {
* task has to wait for a replenishment to be performed at the
* next firing of dl_timer.
*
- * @dl_boosted tells if we are boosted due to DI. If so we are
- * outside bandwidth enforcement mechanism (but only until we
- * exit the critical section);
- *
* @dl_yielded tells if task gave up the CPU before consuming
* all its available runtime during the last job.
*
--
2.25.1



Subject: Re: [PATCH] kernel/sched: remove dl_boosted flag comment

On 1/7/22 10:52, Hui Su wrote:
> since commit 2279f540ea7d ("sched/deadline: Fix priority
> inheritance with multiple scheduling classes"), we should not
> keep it here.
>
> Signed-off-by: Hui Su <[email protected]>

Reviewed-by: Daniel Bristot de Oliveira <[email protected]>

Thanks!

-- Daniel

> ---
> include/linux/sched.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index 78c351e35fec..64426351d424 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -610,10 +610,6 @@ struct sched_dl_entity {
> * task has to wait for a replenishment to be performed at the
> * next firing of dl_timer.
> *
> - * @dl_boosted tells if we are boosted due to DI. If so we are
> - * outside bandwidth enforcement mechanism (but only until we
> - * exit the critical section);
> - *
> * @dl_yielded tells if task gave up the CPU before consuming
> * all its available runtime during the last job.
> *


Subject: [tip: sched/urgent] kernel/sched: Remove dl_boosted flag comment

The following commit has been merged into the sched/urgent branch of tip:

Commit-ID: 0e3872499de1a1230cef5221607d71aa09264bd5
Gitweb: https://git.kernel.org/tip/0e3872499de1a1230cef5221607d71aa09264bd5
Author: Hui Su <[email protected]>
AuthorDate: Fri, 07 Jan 2022 17:52:54 +08:00
Committer: Peter Zijlstra <[email protected]>
CommitterDate: Tue, 18 Jan 2022 12:10:00 +01:00

kernel/sched: Remove dl_boosted flag comment

since commit 2279f540ea7d ("sched/deadline: Fix priority
inheritance with multiple scheduling classes"), we should not
keep it here.

Signed-off-by: Hui Su <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Reviewed-by: Daniel Bristot de Oliveira <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
include/linux/sched.h | 4 ----
1 file changed, 4 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index 7a1f16d..7f8b449 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -614,10 +614,6 @@ struct sched_dl_entity {
* task has to wait for a replenishment to be performed at the
* next firing of dl_timer.
*
- * @dl_boosted tells if we are boosted due to DI. If so we are
- * outside bandwidth enforcement mechanism (but only until we
- * exit the critical section);
- *
* @dl_yielded tells if task gave up the CPU before consuming
* all its available runtime during the last job.
*