2023-06-03 00:09:58

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH net-next 0/2] Move KSZ9477 errata handling to PHY driver

On Fri, Jun 02, 2023 at 05:40:17PM -0600, Robert Hancock wrote:
> Patches to move handling for KSZ9477 PHY errata register fixes from
> the DSA switch driver into the corresponding PHY driver, for more
> proper layering and ordering.


Hi Robert

Is it an issue when it is performed twice, both in the PHY and the DSA
driver? This could happen if somebody was doing a git bisect and
landed in the middle of these two.

Andrew


2023-06-03 00:28:59

by Robert Hancock

[permalink] [raw]
Subject: Re: [PATCH net-next 0/2] Move KSZ9477 errata handling to PHY driver

On Sat, 2023-06-03 at 02:04 +0200, Andrew Lunn wrote:
> On Fri, Jun 02, 2023 at 05:40:17PM -0600, Robert Hancock wrote:
> > Patches to move handling for KSZ9477 PHY errata register fixes from
> > the DSA switch driver into the corresponding PHY driver, for more
> > proper layering and ordering.
>
>
> Hi Robert
>
> Is it an issue when it is performed twice, both in the PHY and the
> DSA
> driver? This could happen if somebody was doing a git bisect and
> landed in the middle of these two.
>
>        Andrew

I don't think you'd really end up in a worse position than without
either patch, it would just be doing some redundant register writes.

--
Robert Hancock <[email protected]>