2008-02-25 20:57:37

by Michael S. Tsirkin

[permalink] [raw]
Subject: new regression in 2.6.25-rc3: can't resume from suspend to ram, ata1 errors

On my T61p, 2.6.25-rc2 seems to wake up fine from suspend to ram.
Not so 2.6.25-rc3: it hangs on suspend to ram, with a blank screen.

At one point I got lucky and got this on console (wrote down by hand,
there could be typos):
ata1: COMRESET failed (errno=-16)
ata1: COMRESET failed (errno=-16)
end_request: I/O error, dev sda sector 200554
Buffer I/O error on device dm-0, logical block 256
Buffer I/O error on device dm-0, logical block 15695875
Buffer I/O error on device dm-0, logical block 15695878
Buffer I/O error on device dm-0, logical block 15695887
Buffer I/O error on device dm-0, logical block 15695896
Buffer I/O error on device dm-0, logical block 15695914
Buffer I/O error on device dm-0, logical block 15958028
Buffer I/O error on device dm-0, logical block 22118530
Buffer I/O error on device dm-0, logical block 22315068
Buffer I/O error on device dm-0, logical block 22347824

git bisect points at this commit:
commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
power_state: get rid of write-only variable in SATA

After reverting 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2
on top of 2.6.25-rc3 the kernel again resumes from suspend to ram.


2008-02-25 21:02:32

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: new regression in 2.6.25-rc3: can't resume from suspend to ram, ata1 errors

On Monday, 25 of February 2008, Michael S. Tsirkin wrote:
> On my T61p, 2.6.25-rc2 seems to wake up fine from suspend to ram.
> Not so 2.6.25-rc3: it hangs on suspend to ram, with a blank screen.

Thanks for the report.

> At one point I got lucky and got this on console (wrote down by hand,
> there could be typos):
> ata1: COMRESET failed (errno=-16)
> ata1: COMRESET failed (errno=-16)
> end_request: I/O error, dev sda sector 200554
> Buffer I/O error on device dm-0, logical block 256
> Buffer I/O error on device dm-0, logical block 15695875
> Buffer I/O error on device dm-0, logical block 15695878
> Buffer I/O error on device dm-0, logical block 15695887
> Buffer I/O error on device dm-0, logical block 15695896
> Buffer I/O error on device dm-0, logical block 15695914
> Buffer I/O error on device dm-0, logical block 15958028
> Buffer I/O error on device dm-0, logical block 22118530
> Buffer I/O error on device dm-0, logical block 22315068
> Buffer I/O error on device dm-0, logical block 22347824
>
> git bisect points at this commit:
> commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
> power_state: get rid of write-only variable in SATA

Jeff, could you revert it, please?

Thanks,
Rafael

2008-02-25 21:04:23

by Jeff Garzik

[permalink] [raw]
Subject: Re: new regression in 2.6.25-rc3: can't resume from suspend to ram, ata1 errors

Michael S. Tsirkin wrote:
> git bisect points at this commit:
> commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
> power_state: get rid of write-only variable in SATA


Hello Pavel --

It looks like this not a write-only variable after all...

Jeff

Subject: Re: new regression in 2.6.25-rc3: can't resume from suspend to ram, ata1 errors

On Monday 25 February 2008, Rafael J. Wysocki wrote:
> On Monday, 25 of February 2008, Michael S. Tsirkin wrote:
> > On my T61p, 2.6.25-rc2 seems to wake up fine from suspend to ram.
> > Not so 2.6.25-rc3: it hangs on suspend to ram, with a blank screen.
>
> Thanks for the report.
>
> > At one point I got lucky and got this on console (wrote down by hand,
> > there could be typos):
> > ata1: COMRESET failed (errno=-16)
> > ata1: COMRESET failed (errno=-16)
> > end_request: I/O error, dev sda sector 200554
> > Buffer I/O error on device dm-0, logical block 256
> > Buffer I/O error on device dm-0, logical block 15695875
> > Buffer I/O error on device dm-0, logical block 15695878
> > Buffer I/O error on device dm-0, logical block 15695887
> > Buffer I/O error on device dm-0, logical block 15695896
> > Buffer I/O error on device dm-0, logical block 15695914
> > Buffer I/O error on device dm-0, logical block 15958028
> > Buffer I/O error on device dm-0, logical block 22118530
> > Buffer I/O error on device dm-0, logical block 22315068
> > Buffer I/O error on device dm-0, logical block 22347824
> >
> > git bisect points at this commit:
> > commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
> > power_state: get rid of write-only variable in SATA
>
> Jeff, could you revert it, please?

Jeff, this was applied between -rc2 and -rc3.

100% cleanup patches which change behavior are potentialy
risky and shouldn't be considered as a -rc material.

Thanks,
Bart

2008-02-25 22:35:04

by Pavel Machek

[permalink] [raw]
Subject: Re: new regression in 2.6.25-rc3: can't resume from suspend to ram, ata1 errors

On Mon 2008-02-25 16:04:08, Jeff Garzik wrote:
> Michael S. Tsirkin wrote:
>> git bisect points at this commit:
>> commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2.
>> power_state: get rid of write-only variable in SATA
>
>
> Hello Pavel --
>
> It looks like this not a write-only variable after all...

Yep, right and sorry.

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html