2021-01-21 09:48:42

by Lee Jones

Subject: [PATCH 03/30] RDMA/hw/efa/efa_com: Stop using param description notation for non-params

Fixes the following W=1 kernel build warning(s):

drivers/infiniband/hw/efa/efa_com.c:801: warning: Excess function parameter 'note' description in 'efa_com_admin_q_comp_intr_handler'

Cc: Gal Pressman <[email protected]>
Cc: Yossi Leybovich <[email protected]>
Cc: Doug Ledford <[email protected]>
Cc: Jason Gunthorpe <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/infiniband/hw/efa/efa_com.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/efa/efa_com.c b/drivers/infiniband/hw/efa/efa_com.c
index 336bc2c57bb1d..f7242188a8434 100644
--- a/drivers/infiniband/hw/efa/efa_com.c
+++ b/drivers/infiniband/hw/efa/efa_com.c
@@ -795,7 +795,7 @@ int efa_com_admin_init(struct efa_com_dev *edev,
* This method goes over the admin completion queue and wakes up
* all the pending threads that wait on the commands wait event.
*
- * @note: Should be called after MSI-X interrupt.
+ * Note: Should be called after MSI-X interrupt.
*/
void efa_com_admin_q_comp_intr_handler(struct efa_com_dev *edev)
{
--
2.25.1

2021-01-21 13:17:42

by Gal Pressman

Subject: Re: [PATCH 03/30] RDMA/hw/efa/efa_com: Stop using param description notation for non-params

On 21/01/2021 11:44, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/infiniband/hw/efa/efa_com.c:801: warning: Excess function parameter 'note' description in 'efa_com_admin_q_comp_intr_handler'
>
> Cc: Gal Pressman <[email protected]>
> Cc: Yossi Leybovich <[email protected]>
> Cc: Doug Ledford <[email protected]>
> Cc: Jason Gunthorpe <[email protected]>
> Cc: [email protected]
> Signed-off-by: Lee Jones <[email protected]>

I would change the subject's prefix to 'RDMA/efa', but other than that looks good:
Acked-by: Gal Pressman <[email protected]>

Thanks Lee.