2021-01-11 14:58:11

by Ricardo Ribalda

Subject: [PATCH] media: staging/intel-ipu3 : Do not zero reserved fields

Core code already clears reserved fields of struct
v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero
v4l2_plane_pix_format reserved fields").

Cc: Sakari Ailus <[email protected]>
Signed-off-by: Ricardo Ribalda <[email protected]>
---
drivers/staging/media/ipu3/ipu3-v4l2.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
index 4dc8d9165f63..60aa02eb7d2a 100644
--- a/drivers/staging/media/ipu3/ipu3-v4l2.c
+++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
@@ -773,9 +773,6 @@ static int imgu_try_fmt(struct file *file, void *fh, struct v4l2_format *f)

pixm->pixelformat = fmt->fourcc;

- memset(pixm->plane_fmt[0].reserved, 0,
- sizeof(pixm->plane_fmt[0].reserved));
-
return 0;
}

--
2.30.0.284.gd98b1dd5eaa7-goog

2021-01-12 13:05:55

by Kieran Bingham

Subject: Re: [PATCH] media: staging/intel-ipu3 : Do not zero reserved fields

Hi Ricardo,

On 11/01/2021 14:54, Ricardo Ribalda wrote:
> Core code already clears reserved fields of struct
> v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero
> v4l2_plane_pix_format reserved fields").
>
> Cc: Sakari Ailus <[email protected]>
> Signed-off-by: Ricardo Ribalda <[email protected]>

This is just 9/9 of the series right ? ;-)
--
Kieran

> ---
> drivers/staging/media/ipu3/ipu3-v4l2.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
> index 4dc8d9165f63..60aa02eb7d2a 100644
> --- a/drivers/staging/media/ipu3/ipu3-v4l2.c
> +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
> @@ -773,9 +773,6 @@ static int imgu_try_fmt(struct file *file, void *fh, struct v4l2_format *f)
>
> pixm->pixelformat = fmt->fourcc;
>
> - memset(pixm->plane_fmt[0].reserved, 0,
> - sizeof(pixm->plane_fmt[0].reserved));
> -
> return 0;
> }
>
>

2021-01-12 13:06:42

by Ricardo Ribalda

Subject: Re: [PATCH] media: staging/intel-ipu3 : Do not zero reserved fields

Hi Kieran

On Tue, Jan 12, 2021 at 12:59 PM Kieran Bingham
<[email protected]> wrote:
>
> Hi Ricardo,
>
> On 11/01/2021 14:54, Ricardo Ribalda wrote:
> > Core code already clears reserved fields of struct
> > v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero
> > v4l2_plane_pix_format reserved fields").
> >
> > Cc: Sakari Ailus <[email protected]>
> > Signed-off-by: Ricardo Ribalda <[email protected]>
>
> This is just 9/9 of the series right ? ;-)

I was just testing that you were doing a good review :P

My bad, I sent the mails with git email-send 00* and I forgot to clean
before :(. I already marked the patch as obsolete in patchwork. Sorry
for wasting your time

Best regards!

> --
> Kieran
>
> > ---
> > drivers/staging/media/ipu3/ipu3-v4l2.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
> > index 4dc8d9165f63..60aa02eb7d2a 100644
> > --- a/drivers/staging/media/ipu3/ipu3-v4l2.c
> > +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
> > @@ -773,9 +773,6 @@ static int imgu_try_fmt(struct file *file, void *fh, struct v4l2_format *f)
> >
> > pixm->pixelformat = fmt->fourcc;
> >
> > - memset(pixm->plane_fmt[0].reserved, 0,
> > - sizeof(pixm->plane_fmt[0].reserved));
> > -
> > return 0;
> > }
> >
> >
>


--
Ricardo Ribalda