2023-12-01 01:47:04

by CK Hu (胡俊光)

[permalink] [raw]
Subject: Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

Hi, Mac:

On Fri, 2023-11-24 at 16:53 +0800, mac.shen wrote:
> Add tee client application, HDCP 1.x and 2.x authentication for
> DisplayPort
> to support the HDCP feature.
>
> Signed-off-by: mac.shen <[email protected]>
> ---
> drivers/gpu/drm/mediatek/Makefile | 7 +-
> drivers/gpu/drm/mediatek/ca/tci.h | 143 +++
> drivers/gpu/drm/mediatek/ca/tlDPHdcpCMD.h | 36 +

Use lower case for file name.

> drivers/gpu/drm/mediatek/ca/tlcDpHdcp.c | 638 +++++++++++++
> drivers/gpu/drm/mediatek/ca/tlcDpHdcp.h | 305 +++++++

Why need a ca folder?

> drivers/gpu/drm/mediatek/mtk_dp.c | 159 +++-
> drivers/gpu/drm/mediatek/mtk_dp.h | 17 +
> drivers/gpu/drm/mediatek/mtk_dp_hdcp.h | 154 ++++
> drivers/gpu/drm/mediatek/mtk_dp_hdcp1x.c | 646 +++++++++++++
> drivers/gpu/drm/mediatek/mtk_dp_hdcp1x.h | 55 ++
> drivers/gpu/drm/mediatek/mtk_dp_hdcp2.c | 1008
> +++++++++++++++++++++
> drivers/gpu/drm/mediatek/mtk_dp_hdcp2.h | 75 ++
> drivers/gpu/drm/mediatek/mtk_dp_reg.h | 6 +-
> 13 files changed, 3233 insertions(+), 16 deletions(-)
> create mode 100644 drivers/gpu/drm/mediatek/ca/tci.h
> create mode 100644 drivers/gpu/drm/mediatek/ca/tlDPHdcpCMD.h
> create mode 100644 drivers/gpu/drm/mediatek/ca/tlcDpHdcp.c
> create mode 100644 drivers/gpu/drm/mediatek/ca/tlcDpHdcp.h
> create mode 100644 drivers/gpu/drm/mediatek/mtk_dp.h
> create mode 100644 drivers/gpu/drm/mediatek/mtk_dp_hdcp.h
> create mode 100644 drivers/gpu/drm/mediatek/mtk_dp_hdcp1x.c
> create mode 100644 drivers/gpu/drm/mediatek/mtk_dp_hdcp1x.h
> create mode 100644 drivers/gpu/drm/mediatek/mtk_dp_hdcp2.c
> create mode 100644 drivers/gpu/drm/mediatek/mtk_dp_hdcp2.h
>

This is large patch, so I would like you to separate this patch. Maybe
ca, hdcp1, and hdcp2.

Regards,
CK