2024-04-11 22:53:27

by Judith Mendez

[permalink] [raw]
Subject: [PATCH 7/7] arm64: dts: ti: k3-j784s4-evm: Remove HS400 mode support for eMMC

From: Udit Kumar <[email protected]>

The eMMC fails to enumerate intermittently on HS400 mode. Also
observing multiple CQE recovery warnings.

Update the sdhci0 node to disable HS400.

Cc: Vignesh Raghavendra <[email protected]>
Cc: Bhavya Kapoor <[email protected]>
Cc: Siddharth Vadapalli <[email protected]>
Signed-off-by: Udit Kumar <[email protected]>
Signed-off-by: Vignesh Raghavendra <[email protected]>
[Judith: Reword commit]
Signed-off-by: Judith Mendez <[email protected]>
---
arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
index 81fd7afac8c57..04a241a91e6b8 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
@@ -791,6 +791,7 @@ &main_sdhci0 {
non-removable;
ti,driver-strength-ohm = <50>;
disable-wp;
+ no-mmc-hs400;
};

&main_sdhci1 {
--
2.43.2



2024-04-12 04:53:07

by Kumar, Udit

[permalink] [raw]
Subject: Re: [PATCH 7/7] arm64: dts: ti: k3-j784s4-evm: Remove HS400 mode support for eMMC

Hi Judith

On 4/12/2024 4:22 AM, Judith Mendez wrote:
> From: Udit Kumar <[email protected]>
>
> The eMMC fails to enumerate intermittently on HS400 mode. Also
> observing multiple CQE recovery warnings.
>
> Update the sdhci0 node to disable HS400.
>
> Cc: Vignesh Raghavendra <[email protected]>
> Cc: Bhavya Kapoor <[email protected]>
> Cc: Siddharth Vadapalli <[email protected]>
> Signed-off-by: Udit Kumar <[email protected]>
> Signed-off-by: Vignesh Raghavendra <[email protected]>
> [Judith: Reword commit]
> Signed-off-by: Judith Mendez <[email protected]>
> ---
> arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> index 81fd7afac8c57..04a241a91e6b8 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> @@ -791,6 +791,7 @@ &main_sdhci0 {
> non-removable;
> ti,driver-strength-ohm = <50>;
> disable-wp;
> + no-mmc-hs400;

This is just WA to get rid of CQE errors. I prefer to hold this patch
under debug from hardware side is not complete.

Moreover, CQE errors are seen with 32GB variant not with 16GB, So we can
not blame controller for this


> };
>
> &main_sdhci1 {

2024-04-12 22:15:24

by Judith Mendez

[permalink] [raw]
Subject: Re: [PATCH 7/7] arm64: dts: ti: k3-j784s4-evm: Remove HS400 mode support for eMMC

Hi Udit,

On 4/11/24 11:52 PM, Kumar, Udit wrote:
> Hi Judith
>
> On 4/12/2024 4:22 AM, Judith Mendez wrote:
>> From: Udit Kumar <[email protected]>
>>
>> The eMMC fails to enumerate intermittently on HS400 mode. Also
>> observing multiple CQE recovery warnings.
>>
>> Update the sdhci0 node to disable HS400.
>>
>> Cc: Vignesh Raghavendra <[email protected]>
>> Cc: Bhavya Kapoor <[email protected]>
>> Cc: Siddharth Vadapalli <[email protected]>
>> Signed-off-by: Udit Kumar <[email protected]>
>> Signed-off-by: Vignesh Raghavendra <[email protected]>
>> [Judith: Reword commit]
>> Signed-off-by: Judith Mendez <[email protected]>
>> ---
>>   arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
>> b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
>> index 81fd7afac8c57..04a241a91e6b8 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
>> @@ -791,6 +791,7 @@ &main_sdhci0 {
>>       non-removable;
>>       ti,driver-strength-ohm = <50>;
>>       disable-wp;
>> +    no-mmc-hs400;
>
> This is just WA to get rid of CQE errors. I prefer to hold this patch
> under debug from hardware side is not complete.
>
> Moreover, CQE errors are seen with 32GB variant not with 16GB, So we can
> not blame controller for this

Will drop, thanks.

~ Judith

>
>
>>   };
>>   &main_sdhci1 {