Hi,
On 25/02/2022 07:44, Shunzhou Jiang wrote:
> Add the bindings for the Amlogic Secure power domains, controlling the
> secure power domains.
>
> The bindings targets the Amlogic s4, in which the power domains registers
> are in secure world.
>
> Signed-off-by: Shunzhou Jiang <[email protected]>
Please keep along revisions the Reviewed-by/Acked-by/Tested-by from previous reviews like the one from https://lore.kernel.org/r/CAFBinCBN-QoA-e9JzfUq-Wc4Chu=x6cVoP2SYf=q-GrnLdLGKg@mail.gmail.com
And please CC [email protected] to have a proper review from the Rob Herring, without a proper review from Rob I can't take it.
Neil
> ---
> .../power/amlogic,meson-sec-pwrc.yaml | 3 ++-
> include/dt-bindings/power/meson-s4-power.h | 19 +++++++++++++++++++
> 2 files changed, 21 insertions(+), 1 deletion(-)
> create mode 100644 include/dt-bindings/power/meson-s4-power.h
>
> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> index 5dae04d2936c..7657721a4e96 100644
> --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> @@ -12,13 +12,14 @@ maintainers:
> - Jianxin Pan <[email protected]>
>
> description: |+
> - Secure Power Domains used in Meson A1/C1 SoCs, and should be the child node
> + Secure Power Domains used in Meson A1/C1/S4 SoCs, and should be the child node
> of secure-monitor.
>
> properties:
> compatible:
> enum:
> - amlogic,meson-a1-pwrc
> + - amlogic,meson-s4-pwrc
>
> "#power-domain-cells":
> const: 1
> diff --git a/include/dt-bindings/power/meson-s4-power.h b/include/dt-bindings/power/meson-s4-power.h
> new file mode 100644
> index 000000000000..462dd2cb938b
> --- /dev/null
> +++ b/include/dt-bindings/power/meson-s4-power.h
> @@ -0,0 +1,19 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ or MIT) */
> +/*
> + * Copyright (c) 2021 Amlogic, Inc.
> + * Author: Shunzhou Jiang <[email protected]>
> + */
> +
> +#ifndef _DT_BINDINGS_MESON_S4_POWER_H
> +#define _DT_BINDINGS_MESON_S4_POWER_H
> +
> +#define PWRC_S4_DOS_HEVC_ID 0
> +#define PWRC_S4_DOS_VDEC_ID 1
> +#define PWRC_S4_VPU_HDMI_ID 2
> +#define PWRC_S4_USB_COMB_ID 3
> +#define PWRC_S4_GE2D_ID 4
> +#define PWRC_S4_ETH_ID 5
> +#define PWRC_S4_DEMOD_ID 6
> +#define PWRC_S4_AUDIO_ID 7
> +
> +#endif