2022-09-19 11:27:59

by Astrid Rost

Subject: [PATCH v3 2/3] dt-bindings: sound: ti,s3a227e: add control of debounce

Add devicetree parameters to control the insertion, release and press
debounce times.

Signed-off-by: Astrid Rost <[email protected]>
---
.../bindings/sound/ti,ts3a227e.yaml | 29 +++++++++++++++++++
1 file changed, 29 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
index 327d204cf957..76ce323ce965 100644
--- a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
+++ b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
@@ -41,6 +41,35 @@ properties:
- 7 # 2.8 V
default: 1

+ ti,debounce-release-ms:
+ description: key release debounce time in ms (datasheet section 9.6.7).
+ enum:
+ - 0 # 0 ms
+ - 20 # 20 ms
+ default: 20
+
+ ti,debounce-press-ms:
+ description: key press debounce time in ms (datasheet section 9.6.7).
+ enum:
+ - 2 # 2 ms
+ - 40 # 40 ms
+ - 80 # 80 ms
+ - 120 # 120 ms
+ default: 80
+
+ ti,debounce-insertion-ms:
+ description: headset insertion debounce time in ms (datasheet section 9.6.5).
+ enum:
+ - 2 # 2 ms
+ - 30 # 30 ms
+ - 60 # 60 ms
+ - 90 # 90 ms
+ - 120 # 120 ms
+ - 150 # 150 ms
+ - 1000 # 1 s
+ - 2000 # 2 s
+ default: 90
+
required:
- compatible
- reg
--
2.20.1

2022-09-20 16:04:02

by Krzysztof Kozlowski

Subject: Re: [PATCH v3 2/3] dt-bindings: sound: ti,s3a227e: add control of debounce

On 19/09/2022 13:12, Astrid Rost wrote:
> Add devicetree parameters to control the insertion, release and press
> debounce times.
>
> Signed-off-by: Astrid Rost <[email protected]>
> ---
> .../bindings/sound/ti,ts3a227e.yaml | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
> index 327d204cf957..76ce323ce965 100644
> --- a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml
> @@ -41,6 +41,35 @@ properties:
> - 7 # 2.8 V
> default: 1
>
> + ti,debounce-release-ms:
> + description: key release debounce time in ms (datasheet section 9.6.7).
> + enum:
> + - 0 # 0 ms
> + - 20 # 20 ms

I don't see any improvements here.

Best regards,
Krzysztof

2022-09-21 08:14:36

by Astrid Rost

Subject: Re: [PATCH v3 2/3] dt-bindings: sound: ti,s3a227e: add control of debounce

>> +  ti,debounce-release-ms:
>> +    description: key release debounce time in ms (datasheet section 9.6.7).
>> +    enum:
>> +      - 0  #  0 ms
>> +      - 20 # 20 ms
>
> I don't see any improvements here.

Sorry, I miss understood. I have now just kept the enum values.

Astrid