Hi all,
Commit
bba074f926d1 ("platform/x86: silead_dmi: Add entry for Chuwi Hi8 S806_206 tablet touchscreen")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
On Fri, Jun 1, 2018 at 2:36 PM, Stephen Rothwell <[email protected]> wrote:
> Hi all,
>
> Commit
>
> bba074f926d1 ("platform/x86: silead_dmi: Add entry for Chuwi Hi8 S806_206 tablet touchscreen")
>
> is missing a Signed-off-by from its author.
Oops. What is the proposed fix for that? It seems we can't rebase
published branches.
--
With Best Regards,
Andy Shevchenko
Hi Andy,
On Fri, 1 Jun 2018 14:40:35 +0300 Andy Shevchenko <[email protected]> wrote:
>
> Oops. What is the proposed fix for that? It seems we can't rebase
> published branches.
It's unfixable without a rebase, so you could instead consider it an
opportunity to improve your processes for the future. :-)
--
Cheers,
Stephen Rothwell
On June 1, 2018 5:08:32 AM PDT, Stephen Rothwell <[email protected]> wrote:
>Hi Andy,
>
>On Fri, 1 Jun 2018 14:40:35 +0300 Andy Shevchenko
><[email protected]> wrote:
>>
>> Oops. What is the proposed fix for that? It seems we can't rebase
>> published branches.
>
>It's unfixable without a rebase, so you could instead consider it an
>opportunity to improve your processes for the future. :-)
Yeah, in this case we have to do a rebase.
Andy, I've been wanting to look at using some simple bots and tags for this kind of thing. GitHub makes this really easy, might be time to move. We'll continue this offline.
For now, please rebase next to correct the error as this change is on top of any of my commits, we won't make things worse by you recommitting my commits.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
On June 1, 2018 5:08:32 AM PDT, Stephen Rothwell <[email protected]> wrote:
>Hi Andy,
>
>On Fri, 1 Jun 2018 14:40:35 +0300 Andy Shevchenko
><[email protected]> wrote:
>>
>> Oops. What is the proposed fix for that? It seems we can't rebase
>> published branches.
>
>It's unfixable without a rebase, so you could instead consider it an
>opportunity to improve your processes for the future. :-)
Stephen, are the tests you use available publicly?
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
On Fri, Jun 1, 2018 at 3:08 PM, Stephen Rothwell <[email protected]> wrote:
> Hi Andy,
>
> On Fri, 1 Jun 2018 14:40:35 +0300 Andy Shevchenko <[email protected]> wrote:
>>
>> Oops. What is the proposed fix for that? It seems we can't rebase
>> published branches.
>
> It's unfixable without a rebase, so you could instead consider it an
> opportunity to improve your processes for the future. :-)
Do you have some already cooked scripts to perform such checks on
given repository?
Can you share?
--
With Best Regards,
Andy Shevchenko
On Fri, Jun 1, 2018 at 5:33 PM, <[email protected]> wrote:
> On June 1, 2018 5:08:32 AM PDT, Stephen Rothwell <[email protected]> wrote:
>>On Fri, 1 Jun 2018 14:40:35 +0300 Andy Shevchenko
>><[email protected]> wrote:
>>>
>>> Oops. What is the proposed fix for that? It seems we can't rebase
>>> published branches.
>>
>>It's unfixable without a rebase, so you could instead consider it an
>>opportunity to improve your processes for the future. :-)
>
> Yeah, in this case we have to do a rebase.
>
> Andy, I've been wanting to look at using some simple bots and tags for this kind of thing. GitHub makes this really easy, might be time to move. We'll continue this offline.
>
> For now, please rebase next to correct the error as this change is on top of any of my commits, we won't make things worse by you recommitting my commits.
Done.
Author has been informed.
--
With Best Regards,
Andy Shevchenko
Hi,
On Fri, 01 Jun 2018 07:38:42 -0700 [email protected] wrote:
>
> Stephen, are the tests you use available publicly?
I use the script below when I am fetching trees. You don't want the
"gitk" invocation if you are doing this automatically, of course. The
script just takes a commit range.
--
Cheers,
Stephen Rothwell
-------------------------------------------------------------
#!/bin/bash
if [ "$#" -lt 1 ]; then
printf "Usage: %s <commit range>\n", "$0" 1>&2
exit 1
fi
commits=$(git rev-list --no-merges "$@")
if [ -z "$commits" ]; then
printf "No commits\n"
exit 0
fi
for c in $commits; do
ae=$(git log -1 --format='%ae' "$c")
aE=$(git log -1 --format='%aE' "$c")
an=$(git log -1 --format='%an' "$c")
aN=$(git log -1 --format='%aN' "$c")
ce=$(git log -1 --format='%ce' "$c")
cE=$(git log -1 --format='%cE' "$c")
cn=$(git log -1 --format='%cn' "$c")
cN=$(git log -1 --format='%cN' "$c")
sob=$(git log -1 --format='%b' "$c" | grep -i '^[[:space:]]*Signed-off-by:')
am=false
cm=false
grep -i -q "<$ae>" <<<"$sob" ||
grep -i -q "<$aE>" <<<"$sob" ||
grep -i -q ":[[:space:]]*$an[[:space:]]*<" <<<"$sob" ||
grep -i -q ":[[:space:]]*$aN[[:space:]]*<" <<<"$sob" ||
am=true
grep -i -q "<$ce>" <<<"$sob" ||
grep -i -q "<$cE>" <<<"$sob" ||
grep -i -q ":[[:space:]]*$cn[[:space:]]*<" <<<"$sob" ||
grep -i -q ":[[:space:]]*$cN[[:space:]]*<" <<<"$sob" ||
cm=true
if "$am" || "$cm"; then
printf "Commit %s\n" "$c"
"$am" && printf "\tauthor SOB missing\n"
"$cm" && printf "\tcommitter SOB missing\n"
printf "%s %s\n%s\n" "$ae" "$ce" "$sob"
fi
done
exec gitk "$@"
-------------------------------------------------------------
On Sat, Jun 02, 2018 at 01:26:46AM +1000, Stephen Rothwell wrote:
> Hi,
>
> On Fri, 01 Jun 2018 07:38:42 -0700 [email protected] wrote:
> >
> > Stephen, are the tests you use available publicly?
>
> I use the script below when I am fetching trees. You don't want the
> "gitk" invocation if you are doing this automatically, of course. The
> script just takes a commit range.
Thanks for sharing Stephen.
--
Darren Hart
VMware Open Source Technology Center