2018-09-10 20:13:30

by Alexandre Belloni

[permalink] [raw]
Subject: [PATCH] usb: gadget: udc: atmel: handle at91sam9rl PMC

The at91sam9rl PMC is not quite the same as the at91sam9g45 one and now has
its own compatible string. Add support for that.

Fixes: 217bace8e548 ("ARM: dts: fix PMC compatible")
Signed-off-by: Alexandre Belloni <[email protected]>
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 17147b8c771e..8f267be1745d 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
@@ -2017,6 +2017,8 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,

udc->errata = match->data;
udc->pmc = syscon_regmap_lookup_by_compatible("atmel,at91sam9g45-pmc");
+ if (IS_ERR(udc->pmc))
+ udc->pmc = syscon_regmap_lookup_by_compatible("atmel,at91sam9rl-pmc");
if (IS_ERR(udc->pmc))
udc->pmc = syscon_regmap_lookup_by_compatible("atmel,at91sam9x5-pmc");
if (udc->errata && IS_ERR(udc->pmc))
--
2.19.0.rc2



2018-09-14 17:16:21

by Cristian Birsan

[permalink] [raw]
Subject: Re: [PATCH] usb: gadget: udc: atmel: handle at91sam9rl PMC



On 10.09.2018 23:12, Alexandre Belloni wrote:
> The at91sam9rl PMC is not quite the same as the at91sam9g45 one and now has
> its own compatible string. Add support for that.
>
> Fixes: 217bace8e548 ("ARM: dts: fix PMC compatible")
> Signed-off-by: Alexandre Belloni <[email protected]>

It looks good to me.

Acked-by: Cristian Birsan <[email protected]>

> ---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 17147b8c771e..8f267be1745d 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -2017,6 +2017,8 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
>
> udc->errata = match->data;
> udc->pmc = syscon_regmap_lookup_by_compatible("atmel,at91sam9g45-pmc");
> + if (IS_ERR(udc->pmc))
> + udc->pmc = syscon_regmap_lookup_by_compatible("atmel,at91sam9rl-pmc");
> if (IS_ERR(udc->pmc))
> udc->pmc = syscon_regmap_lookup_by_compatible("atmel,at91sam9x5-pmc");
> if (udc->errata && IS_ERR(udc->pmc))
>