2021-06-07 04:02:35

by Mark-PK Tsai (蔡沛剛)

Subject: [PATCH] irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ

Only TV SoCs of Mediatek products have this controller
which inherit from MStar TV SoCs.
Don't enable it by default if ARCH_MEDIATEK is selected.
Instead, use ARCH_MSTARV7 as default value.

Signed-off-by: Mark-PK Tsai <[email protected]>
---
drivers/irqchip/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 62543a4eccc0..30f578e18a11 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -576,7 +576,7 @@ config LOONGSON_PCH_MSI
config MST_IRQ
bool "MStar Interrupt Controller"
depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST
- default ARCH_MEDIATEK
+ default ARCH_MSTARV7
select IRQ_DOMAIN
select IRQ_DOMAIN_HIERARCHY
help
--
2.18.0

2021-06-08 02:51:47

by Mark-PK Tsai (蔡沛剛)

Subject: [PATCH] irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ

+ Daniel

> Only TV SoCs of Mediatek products have this controller
> which inherit from MStar TV SoCs.
> Don't enable it by default if ARCH_MEDIATEK is selected.
> Instead, use ARCH_MSTARV7 as default value.
>
> Signed-off-by: Mark-PK Tsai <[email protected]>
> ---
> drivers/irqchip/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 62543a4eccc0..30f578e18a11 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -576,7 +576,7 @@ config LOONGSON_PCH_MSI
> config MST_IRQ
> bool "MStar Interrupt Controller"
> depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST
> - default ARCH_MEDIATEK
> + default ARCH_MSTARV7
> select IRQ_DOMAIN
> select IRQ_DOMAIN_HIERARCHY
> help
> --
> 2.18.0

2021-06-09 01:39:16

by Matthias Brugger

Subject: Re: [PATCH] irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ

On 07/06/2021 05:59, Mark-PK Tsai wrote:
> Only TV SoCs of Mediatek products have this controller
> which inherit from MStar TV SoCs.
> Don't enable it by default if ARCH_MEDIATEK is selected.
> Instead, use ARCH_MSTARV7 as default value.
>
> Signed-off-by: Mark-PK Tsai <[email protected]>
> ---
> drivers/irqchip/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 62543a4eccc0..30f578e18a11 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -576,7 +576,7 @@ config LOONGSON_PCH_MSI
> config MST_IRQ
> bool "MStar Interrupt Controller"
> depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST

We should also delete ARCH_MEDIATEK dependency.

Regards,
Matthias

> - default ARCH_MEDIATEK
> + default ARCH_MSTARV7
> select IRQ_DOMAIN
> select IRQ_DOMAIN_HIERARCHY
> help
>

2021-06-09 06:43:27

by Mark-PK Tsai (蔡沛剛)

Subject: Re: [PATCH] irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ

> On 07/06/2021 05:59, Mark-PK Tsai wrote:
> > Only TV SoCs of Mediatek products have this controller
> > which inherit from MStar TV SoCs.
> > Don't enable it by default if ARCH_MEDIATEK is selected.
> > Instead, use ARCH_MSTARV7 as default value.
> >
> > Signed-off-by: Mark-PK Tsai <[email protected]>
> > ---
> > drivers/irqchip/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> > index 62543a4eccc0..30f578e18a11 100644
> > --- a/drivers/irqchip/Kconfig
> > +++ b/drivers/irqchip/Kconfig
> > @@ -576,7 +576,7 @@ config LOONGSON_PCH_MSI
> > config MST_IRQ
> > bool "MStar Interrupt Controller"
> > depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST
>
> We should also delete ARCH_MEDIATEK dependency.

Actually what I want to do is decouple the MST_IRQ from
ARCH_MEDIATEK, because there are only TV SoCs have this.
But if I remove the ARCH_MEDIATEK dependency, then all the
Mediatek TV SoCs kernel have to select ARCH_MSTARV7 too.
It's kind of weird.

Though it may ask some Mediatek users about MST_IRQ,
I just change the default config to prevent that all
the Mediatek kernel include this driver by default.

What would you suggest for this?

>
> Regards,
> Matthias
>
> > - default ARCH_MEDIATEK
> > + default ARCH_MSTARV7
> > select IRQ_DOMAIN
> > select IRQ_DOMAIN_HIERARCHY
> > help
> >
>