2021-02-08 10:30:18

by Yafang Shao

Subject: [PATCH v3 1/3] mm, slub: use pGp to print page flags

As pGp has been already introduced in printk, we'd better use it to make
the output human readable.

Before this change, the output is,
[ 6155.716018] INFO: Slab 0x000000004027dd4f objects=33 used=3 fp=0x000000008cd1579c flags=0x17ffffc0010200

While after this change, the output is,
[ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head)

Reviewed-by: David Hildenbrand <[email protected]>
Reviewed-by: Vlastimil Babka <[email protected]>
Acked-by: David Rientjes <[email protected]>
Acked-by: Christoph Lameter <[email protected]>
Signed-off-by: Yafang Shao <[email protected]>
---
mm/slub.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index 34dcc09e2ec9..87ff086e68a4 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -638,8 +638,9 @@ void print_tracking(struct kmem_cache *s, void *object)

static void print_page_info(struct page *page)
{
- pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=0x%04lx\n",
- page, page->objects, page->inuse, page->freelist, page->flags);
+ pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n",
+ page, page->objects, page->inuse, page->freelist,
+ page->flags, &page->flags);

}

--
2.17.1

2021-02-08 12:36:27

by Matthew Wilcox

Subject: Re: [PATCH v3 1/3] mm, slub: use pGp to print page flags

On Mon, Feb 08, 2021 at 06:14:37PM +0800, Yafang Shao wrote:
> As pGp has been already introduced in printk, we'd better use it to make
> the output human readable.
>
> Before this change, the output is,
> [ 6155.716018] INFO: Slab 0x000000004027dd4f objects=33 used=3 fp=0x000000008cd1579c flags=0x17ffffc0010200
>
> While after this change, the output is,
> [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head)
>
> Reviewed-by: David Hildenbrand <[email protected]>
> Reviewed-by: Vlastimil Babka <[email protected]>
> Acked-by: David Rientjes <[email protected]>
> Acked-by: Christoph Lameter <[email protected]>
> Signed-off-by: Yafang Shao <[email protected]>

Reviewed-by: Matthew Wilcox (Oracle) <[email protected]>

2021-02-09 01:06:33

by Miaohe Lin

Subject: Re: [PATCH v3 1/3] mm, slub: use pGp to print page flags

On 2021/2/8 18:14, Yafang Shao wrote:
> As pGp has been already introduced in printk, we'd better use it to make
> the output human readable.
>
> Before this change, the output is,
> [ 6155.716018] INFO: Slab 0x000000004027dd4f objects=33 used=3 fp=0x000000008cd1579c flags=0x17ffffc0010200
>
> While after this change, the output is,
> [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head)
>
> Reviewed-by: David Hildenbrand <[email protected]>
> Reviewed-by: Vlastimil Babka <[email protected]>
> Acked-by: David Rientjes <[email protected]>
> Acked-by: Christoph Lameter <[email protected]>
> Signed-off-by: Yafang Shao <[email protected]>

LGTM. Thanks.
Reviewed-by: Miaohe Lin <[email protected]>

> ---
> mm/slub.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 34dcc09e2ec9..87ff086e68a4 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -638,8 +638,9 @@ void print_tracking(struct kmem_cache *s, void *object)
>
> static void print_page_info(struct page *page)
> {
> - pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=0x%04lx\n",
> - page, page->objects, page->inuse, page->freelist, page->flags);
> + pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n",
> + page, page->objects, page->inuse, page->freelist,
> + page->flags, &page->flags);
>
> }
>
>