2022-12-09 17:48:45

by Alvin Šipraga

Subject: [PATCH] usb: gadget: u_ether: remove obnoxious warning messages

From: Alvin Šipraga <[email protected]>

There is really no need for the driver to unconditionally emit warnings
like this on every usage:

[ 6.967283] using random self ethernet address
[ 6.967294] using random host ethernet address

Since this is normal behaviour, just remove the messages altogether.

Signed-off-by: Alvin Šipraga <[email protected]>
---
drivers/usb/gadget/function/u_ether.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
index 8f12f3f8f6ee..3fdc913ef262 100644
--- a/drivers/usb/gadget/function/u_ether.c
+++ b/drivers/usb/gadget/function/u_ether.c
@@ -845,13 +845,11 @@ struct net_device *gether_setup_name_default(const char *netname)
snprintf(net->name, sizeof(net->name), "%s%%d", netname);

eth_random_addr(dev->dev_mac);
- pr_warn("using random %s ethernet address\n", "self");

/* by default we always have a random MAC address */
net->addr_assign_type = NET_ADDR_RANDOM;

eth_random_addr(dev->host_mac);
- pr_warn("using random %s ethernet address\n", "host");

net->netdev_ops = &eth_netdev_ops;

--
2.37.3

2022-12-12 08:47:28

by Andrzej Pietrasiewicz

Subject: Re: [PATCH] usb: gadget: u_ether: remove obnoxious warning messages

W dniu 9.12.2022 o 18:28, Alvin Šipraga pisze:
> From: Alvin Šipraga <[email protected]>
>
> There is really no need for the driver to unconditionally emit warnings
> like this on every usage:
>
> [ 6.967283] using random self ethernet address
> [ 6.967294] using random host ethernet address
>
> Since this is normal behaviour, just remove the messages altogether.
> > Signed-off-by: Alvin Šipraga <[email protected]>

Reviewed-by: Andrzej Pietrasiewicz <[email protected]>

> ---
> drivers/usb/gadget/function/u_ether.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
> index 8f12f3f8f6ee..3fdc913ef262 100644
> --- a/drivers/usb/gadget/function/u_ether.c
> +++ b/drivers/usb/gadget/function/u_ether.c
> @@ -845,13 +845,11 @@ struct net_device *gether_setup_name_default(const char *netname)
> snprintf(net->name, sizeof(net->name), "%s%%d", netname);
>
> eth_random_addr(dev->dev_mac);
> - pr_warn("using random %s ethernet address\n", "self");
>
> /* by default we always have a random MAC address */
> net->addr_assign_type = NET_ADDR_RANDOM;
>
> eth_random_addr(dev->host_mac);
> - pr_warn("using random %s ethernet address\n", "host");
>
> net->netdev_ops = &eth_netdev_ops;
>

2023-01-17 15:53:18

by Greg KH

Subject: Re: [PATCH] usb: gadget: u_ether: remove obnoxious warning messages

On Fri, Dec 09, 2022 at 06:28:53PM +0100, Alvin Šipraga wrote:
> From: Alvin Šipraga <[email protected]>
>
> There is really no need for the driver to unconditionally emit warnings
> like this on every usage:
>
> [ 6.967283] using random self ethernet address
> [ 6.967294] using random host ethernet address
>
> Since this is normal behaviour, just remove the messages altogether.
>
> Signed-off-by: Alvin Šipraga <[email protected]>
> ---
> drivers/usb/gadget/function/u_ether.c | 2 --
> 1 file changed, 2 deletions(-)

Please see the thread at:
https://lore.kernel.org/r/[email protected]

for more details.

This should use dev_warn() or better yet, just dev_dbg().

thanks,

greg k-h