2022-05-05 23:58:55

by Eric DeVolder

Subject: [PATCH v8 1/7] x86/crash: fix minor typo/bug in debug message

The pr_debug() intends to display the memsz member, but the
parameter is actually the bufsz member (which is already
displayed). Correct this to display memsz value.

Signed-off-by: Eric DeVolder <[email protected]>
Reviewed-by: David Hildenbrand <[email protected]>
Acked-by: Baoquan He <[email protected]>
---
arch/x86/kernel/crash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
index e8326a8d1c5d..9730c88530fc 100644
--- a/arch/x86/kernel/crash.c
+++ b/arch/x86/kernel/crash.c
@@ -407,7 +407,7 @@ int crash_load_segments(struct kimage *image)
}
image->elf_load_addr = kbuf.mem;
pr_debug("Loaded ELF headers at 0x%lx bufsz=0x%lx memsz=0x%lx\n",
- image->elf_load_addr, kbuf.bufsz, kbuf.bufsz);
+ image->elf_load_addr, kbuf.bufsz, kbuf.memsz);

return ret;
}
--
2.27.0

2022-05-09 11:28:49

by Baoquan He

Subject: Re: [PATCH v8 1/7] x86/crash: fix minor typo/bug in debug message

On 05/09/22 at 10:46am, Sourabh Jain wrote:
>
> On 06/05/22 00:15, Eric DeVolder wrote:
> > The pr_debug() intends to display the memsz member, but the
> > parameter is actually the bufsz member (which is already
> > displayed). Correct this to display memsz value.
> >
> > Signed-off-by: Eric DeVolder<[email protected]>
> > Reviewed-by: David Hildenbrand<[email protected]>
> > Acked-by: Baoquan He<[email protected]>
> > ---
> > arch/x86/kernel/crash.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
> > index e8326a8d1c5d..9730c88530fc 100644
> > --- a/arch/x86/kernel/crash.c
> > +++ b/arch/x86/kernel/crash.c
> > @@ -407,7 +407,7 @@ int crash_load_segments(struct kimage *image)
> > }
> > image->elf_load_addr = kbuf.mem;
> > pr_debug("Loaded ELF headers at 0x%lx bufsz=0x%lx memsz=0x%lx\n",
> > - image->elf_load_addr, kbuf.bufsz, kbuf.bufsz);
> > + image->elf_load_addr, kbuf.bufsz, kbuf.memsz);
> >
> I think we can push this patch separately.

Boris has taken this into tip/x86/kdump.

2022-05-09 15:50:27

by Eric DeVolder

Subject: Re: [PATCH v8 1/7] x86/crash: fix minor typo/bug in debug message

On 5/9/22 00:26, Baoquan He wrote:
> On 05/09/22 at 10:46am, Sourabh Jain wrote:
>>
>> On 06/05/22 00:15, Eric DeVolder wrote:
>>> The pr_debug() intends to display the memsz member, but the
>>> parameter is actually the bufsz member (which is already
>>> displayed). Correct this to display memsz value.
>>>
>>> Signed-off-by: Eric DeVolder<[email protected]>
>>> Reviewed-by: David Hildenbrand<[email protected]>
>>> Acked-by: Baoquan He<[email protected]>
>>> ---
>>> arch/x86/kernel/crash.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
>>> index e8326a8d1c5d..9730c88530fc 100644
>>> --- a/arch/x86/kernel/crash.c
>>> +++ b/arch/x86/kernel/crash.c
>>> @@ -407,7 +407,7 @@ int crash_load_segments(struct kimage *image)
>>> }
>>> image->elf_load_addr = kbuf.mem;
>>> pr_debug("Loaded ELF headers at 0x%lx bufsz=0x%lx memsz=0x%lx\n",
>>> - image->elf_load_addr, kbuf.bufsz, kbuf.bufsz);
>>> + image->elf_load_addr, kbuf.bufsz, kbuf.memsz);
>>>
>> I think we can push this patch separately.
>
> Boris has taken this into tip/x86/kdump.
>
Excellent, I'll remove this patch going forward.
Eric