2019-05-14 10:04:23

by Pankaj Gupta

[permalink] [raw]
Subject: Re: [PATCH v8 2/6] virtio-pmem: Add virtio pmem driver


> >>
> >> I think you should do the same here, vdev->priv is allocated in
> >> virtio_pmem_probe.
> >>
> >> But maybe I am missing something important here :)
> >
> > Because virtio_balloon use "kzalloc" for allocation and needs to be freed.
> > But virtio pmem uses "devm_kzalloc" which takes care of automatically
> > deleting
> > the device memory when associated device is detached.
>
> Hehe, thanks, that was the part that I was missing!

Thank you for the review.

Best regards,
Pankaj
>
> --
>
> Thanks,
>
> David / dhildenb
>