2020-04-09 12:52:17

by Maninder Singh

Subject: [PATCH 1/1] smack: remove redundant structure variable from header.

commit afb1cbe37440 ("LSM: Infrastructure management
of the inode security") removed usage of smk_rcu,
thus removing it from structure.

Signed-off-by: Maninder Singh <[email protected]>
Signed-off-by: Vaneet Narang <[email protected]>
---
security/smack/smack.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/security/smack/smack.h b/security/smack/smack.h
index 62529f3..5ebd0bb 100644
--- a/security/smack/smack.h
+++ b/security/smack/smack.h
@@ -111,7 +111,6 @@ struct inode_smack {
struct smack_known *smk_mmap; /* label of the mmap domain */
struct mutex smk_lock; /* initialization lock */
int smk_flags; /* smack inode flags */
- struct rcu_head smk_rcu; /* for freeing inode_smack */
};

struct task_smack {
--
1.9.1

2020-04-09 21:02:43

by Casey Schaufler

Subject: Re: [PATCH 1/1] smack: remove redundant structure variable from header.

On 4/9/2020 5:39 AM, Maninder Singh wrote:
> commit afb1cbe37440 ("LSM: Infrastructure management
> of the inode security") removed usage of smk_rcu,
> thus removing it from structure.
>
> Signed-off-by: Maninder Singh <[email protected]>
> Signed-off-by: Vaneet Narang <[email protected]>

Thank you. I will take this.

> ---
> security/smack/smack.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/security/smack/smack.h b/security/smack/smack.h
> index 62529f3..5ebd0bb 100644
> --- a/security/smack/smack.h
> +++ b/security/smack/smack.h
> @@ -111,7 +111,6 @@ struct inode_smack {
> struct smack_known *smk_mmap; /* label of the mmap domain */
> struct mutex smk_lock; /* initialization lock */
> int smk_flags; /* smack inode flags */
> - struct rcu_head smk_rcu; /* for freeing inode_smack */
> };
>
> struct task_smack {