2023-12-22 09:53:27

by Stefan Eichenberger

[permalink] [raw]
Subject: [PATCH v2 1/2] dt-bindings: input: atmel,maxtouch: add poweroff-sleep property

From: Stefan Eichenberger <[email protected]>

Add a new property to indicate that the device should power off rather
than use deep sleep. Deep sleep is a feature of the controller that
expects the controller to remain powered in suspend. However, if a
display shares its regulator with the touch controller, we may want to
do a power off so that the display and touch controller do not use any
power.

Signed-off-by: Stefan Eichenberger <[email protected]>
---
Documentation/devicetree/bindings/input/atmel,maxtouch.yaml | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml b/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
index c40799355ed7..8de5f539b30e 100644
--- a/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
+++ b/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml
@@ -87,6 +87,12 @@ properties:
- 2 # ATMEL_MXT_WAKEUP_GPIO
default: 0

+ atmel,poweroff-sleep:
+ description: |
+ Instead of using the deep sleep feature of the maXTouch controller,
+ poweroff the regulators.
+ type: boolean
+
wakeup-source:
type: boolean

--
2.40.1



2023-12-22 17:53:04

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: input: atmel,maxtouch: add poweroff-sleep property

On Fri, Dec 22, 2023 at 10:53 AM Stefan Eichenberger <[email protected]> wrote:

> From: Stefan Eichenberger <[email protected]>
>
> Add a new property to indicate that the device should power off rather
> than use deep sleep. Deep sleep is a feature of the controller that
> expects the controller to remain powered in suspend. However, if a
> display shares its regulator with the touch controller, we may want to
> do a power off so that the display and touch controller do not use any
> power.
>
> Signed-off-by: Stefan Eichenberger <[email protected]>

This LGTM:
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2023-12-23 13:55:00

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: input: atmel,maxtouch: add poweroff-sleep property

On 22/12/2023 10:52, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <[email protected]>
>
> Add a new property to indicate that the device should power off rather
> than use deep sleep. Deep sleep is a feature of the controller that
> expects the controller to remain powered in suspend. However, if a
> display shares its regulator with the touch controller, we may want to
> do a power off so that the display and touch controller do not use any
> power.
>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof