2019-06-18 18:52:10

by Mauro Carvalho Chehab

Subject: [PATCH 2/6] docs: trace: add a missing blank line

Sphinx expects a blank line after a literal block markup.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---
Documentation/trace/kprobetrace.rst | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/trace/kprobetrace.rst b/Documentation/trace/kprobetrace.rst
index 3d162d432a3c..caa0a8ba081e 100644
--- a/Documentation/trace/kprobetrace.rst
+++ b/Documentation/trace/kprobetrace.rst
@@ -228,6 +228,7 @@ events, you need to enable it.

Use the following command to start tracing in an interval.
::
+
# echo 1 > tracing_on
Open something...
# echo 0 > tracing_on
--
2.21.0

2019-06-18 19:00:31

by Steven Rostedt

Subject: Re: [PATCH 2/6] docs: trace: add a missing blank line

On Tue, 18 Jun 2019 15:51:18 -0300
Mauro Carvalho Chehab <[email protected]> wrote:

> Sphinx expects a blank line after a literal block markup.
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

For the two tracing patches (1 and 2).

Acked-by: Steven Rostedt (VMware) <[email protected]>

-- Steve

> ---
> Documentation/trace/kprobetrace.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/trace/kprobetrace.rst b/Documentation/trace/kprobetrace.rst
> index 3d162d432a3c..caa0a8ba081e 100644
> --- a/Documentation/trace/kprobetrace.rst
> +++ b/Documentation/trace/kprobetrace.rst
> @@ -228,6 +228,7 @@ events, you need to enable it.
>
> Use the following command to start tracing in an interval.
> ::
> +
> # echo 1 > tracing_on
> Open something...
> # echo 0 > tracing_on

2019-06-19 15:10:07

by Masami Hiramatsu

Subject: Re: [PATCH 2/6] docs: trace: add a missing blank line

On Tue, 18 Jun 2019 15:51:18 -0300
Mauro Carvalho Chehab <[email protected]> wrote:

> Sphinx expects a blank line after a literal block markup.
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Looks good to me, thanks!

Acked-by: Masami Hiramatsu <[email protected]>

> ---
> Documentation/trace/kprobetrace.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/trace/kprobetrace.rst b/Documentation/trace/kprobetrace.rst
> index 3d162d432a3c..caa0a8ba081e 100644
> --- a/Documentation/trace/kprobetrace.rst
> +++ b/Documentation/trace/kprobetrace.rst
> @@ -228,6 +228,7 @@ events, you need to enable it.
>
> Use the following command to start tracing in an interval.
> ::
> +
> # echo 1 > tracing_on
> Open something...
> # echo 0 > tracing_on
> --
> 2.21.0
>


--
Masami Hiramatsu <[email protected]>

2019-06-20 20:08:06

by Jonathan Corbet

Subject: Re: [PATCH 2/6] docs: trace: add a missing blank line

On Tue, 18 Jun 2019 15:51:18 -0300
Mauro Carvalho Chehab <[email protected]> wrote:

> Sphinx expects a blank line after a literal block markup.
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> ---
> Documentation/trace/kprobetrace.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/trace/kprobetrace.rst b/Documentation/trace/kprobetrace.rst
> index 3d162d432a3c..caa0a8ba081e 100644
> --- a/Documentation/trace/kprobetrace.rst
> +++ b/Documentation/trace/kprobetrace.rst
> @@ -228,6 +228,7 @@ events, you need to enable it.
>
> Use the following command to start tracing in an interval.
> ::
> +

Applied, thanks.

jon