2023-01-13 03:47:07

by Judy Hsiao

Subject: [PATCH v1] arm64: dts: qcom: sc7280: add display port audio

Add DisplayPort sound node and lpass_cpu node
in sc7280-herobrine-audio-rt5682.dtsi.

Signed-off-by: Judy Hsiao <[email protected]>

---
Changes Since v1:
-- Fix the commit message.


.../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
index af685bc35e10..69e7aa7b2f6c 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
@@ -33,9 +33,22 @@ codec {
};

dai-link@1 {
- link-name = "ALC5682";
+ link-name = "DisplayPort";
reg = <1>;

+ cpu {
+ sound-dai = <&lpass_cpu LPASS_DP_RX>;
+ };
+
+ codec {
+ sound-dai = <&mdss_dp>;
+ };
+ };
+
+ dai-link@2 {
+ link-name = "ALC5682";
+ reg = <2>;
+
cpu {
sound-dai = <&lpass_cpu MI2S_PRIMARY>;
};
@@ -92,6 +105,10 @@ dai-link@1 {
reg = <MI2S_SECONDARY>;
qcom,playback-sd-lines = <0>;
};
+
+ dai-link@5 {
+ reg = <LPASS_DP_RX>;
+ };
};

/* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */
--
2.39.0.314.g84b9a713c41-goog

2023-01-13 03:48:53

by Konrad Dybcio

Subject: Re: [PATCH v1] arm64: dts: qcom: sc7280: add display port audio

Subject: this is not the first revision that you've sent, the
versions are 1-indexed, so [PATCH] is implicitly [PATCH v1],
this should have been a v2....

On 13.01.2023 04:25, Judy Hsiao wrote:
> Add DisplayPort sound node and lpass_cpu node
> in sc7280-herobrine-audio-rt5682.dtsi.
>
> Signed-off-by: Judy Hsiao <[email protected]>
>
> ---
> Changes Since v1:
..because otherwise this doesn't make sense, as the subject
suggests *this* is the v1.

Konrad
> -- Fix the commit message.
>
>
> .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> index af685bc35e10..69e7aa7b2f6c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> @@ -33,9 +33,22 @@ codec {
> };
>
> dai-link@1 {
> - link-name = "ALC5682";
> + link-name = "DisplayPort";
> reg = <1>;
>
> + cpu {
> + sound-dai = <&lpass_cpu LPASS_DP_RX>;
> + };
> +
> + codec {
> + sound-dai = <&mdss_dp>;
> + };
> + };
> +
> + dai-link@2 {
> + link-name = "ALC5682";
> + reg = <2>;
> +
> cpu {
> sound-dai = <&lpass_cpu MI2S_PRIMARY>;
> };
> @@ -92,6 +105,10 @@ dai-link@1 {
> reg = <MI2S_SECONDARY>;
> qcom,playback-sd-lines = <0>;
> };
> +
> + dai-link@5 {
> + reg = <LPASS_DP_RX>;
> + };
> };
>
> /* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */