2021-01-19 05:01:30

by Enzo Matsumiya

Subject: [PATCH] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit

Parameter ql2xenforce_iocb_limit is enabled by default.

Fixes: 89c72f4245a8 ("scsi: qla2xxx: Add IOCB resource tracking")
Signed-off-by: Enzo Matsumiya <[email protected]>
---
drivers/scsi/qla2xxx/qla_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index f80abe28f35a..0e0fe5b09496 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -42,7 +42,7 @@ MODULE_PARM_DESC(ql2xfulldump_on_mpifail,
int ql2xenforce_iocb_limit = 1;
module_param(ql2xenforce_iocb_limit, int, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(ql2xenforce_iocb_limit,
- "Enforce IOCB throttling, to avoid FW congestion. (default: 0)");
+ "Enforce IOCB throttling, to avoid FW congestion. (default: 1)");

/*
* CT6 CTX allocation cache
--
2.29.2

2021-01-19 08:58:36

by Daniel Wagner

Subject: Re: [PATCH] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit

On Mon, Jan 18, 2021 at 03:49:22PM -0300, Enzo Matsumiya wrote:
> Parameter ql2xenforce_iocb_limit is enabled by default.
>
> Fixes: 89c72f4245a8 ("scsi: qla2xxx: Add IOCB resource tracking")
> Signed-off-by: Enzo Matsumiya <[email protected]>

Reviewed-by: Daniel Wagner <[email protected]>

2021-01-19 15:50:35

by Himanshu Madhani

Subject: Re: [PATCH] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit

> On Jan 18, 2021, at 12:49 PM, Enzo Matsumiya <[email protected]> wrote:
>
> Parameter ql2xenforce_iocb_limit is enabled by default.
>
> Fixes: 89c72f4245a8 ("scsi: qla2xxx: Add IOCB resource tracking")
> Signed-off-by: Enzo Matsumiya <[email protected]>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index f80abe28f35a..0e0fe5b09496 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -42,7 +42,7 @@ MODULE_PARM_DESC(ql2xfulldump_on_mpifail,
> int ql2xenforce_iocb_limit = 1;
> module_param(ql2xenforce_iocb_limit, int, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(ql2xenforce_iocb_limit,
> - "Enforce IOCB throttling, to avoid FW congestion. (default: 0)");
> + "Enforce IOCB throttling, to avoid FW congestion. (default: 1)");
>
> /*
> * CT6 CTX allocation cache
> --
> 2.29.2
>

Good Catch.

Reviewed-by: Himanshu Madhani <[email protected]>

--
Himanshu Madhani Oracle Linux Engineering

2021-01-21 04:06:00

by Martin K. Petersen

Subject: Re: [PATCH] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit

On Mon, 18 Jan 2021 15:49:22 -0300, Enzo Matsumiya wrote:

> Parameter ql2xenforce_iocb_limit is enabled by default.

Applied to 5.11/scsi-fixes, thanks!

[1/1] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit
https://git.kernel.org/mkp/scsi/c/aa2c24e7f415

--
Martin K. Petersen Oracle Linux Engineering