2020-04-04 18:46:24

by Markus Elfring

Subject: [PATCH] PM / devfreq: tegra30: Delete an error message in tegra_devfreq_probe()

From: Markus Elfring <[email protected]>
Date: Sat, 4 Apr 2020 20:34:02 +0200

The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/devfreq/tegra30-devfreq.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
index 28b2c7ca416e..93e6f4b25b04 100644
--- a/drivers/devfreq/tegra30-devfreq.c
+++ b/drivers/devfreq/tegra30-devfreq.c
@@ -807,10 +807,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
}

err = platform_get_irq(pdev, 0);
- if (err < 0) {
- dev_err(&pdev->dev, "Failed to get IRQ: %d\n", err);
+ if (err < 0)
return err;
- }
+
tegra->irq = err;

irq_set_status_flags(tegra->irq, IRQ_NOAUTOEN);
--
2.26.0

2020-04-04 21:42:23

by Dmitry Osipenko

Subject: Re: [PATCH] PM / devfreq: tegra30: Delete an error message in tegra_devfreq_probe()

04.04.2020 21:45, Markus Elfring пишет:
> From: Markus Elfring <[email protected]>
> Date: Sat, 4 Apr 2020 20:34:02 +0200
>
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/devfreq/tegra30-devfreq.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index 28b2c7ca416e..93e6f4b25b04 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -807,10 +807,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
> }
>
> err = platform_get_irq(pdev, 0);
> - if (err < 0) {
> - dev_err(&pdev->dev, "Failed to get IRQ: %d\n", err);
> + if (err < 0)
> return err;
> - }
> +
> tegra->irq = err;
>
> irq_set_status_flags(tegra->irq, IRQ_NOAUTOEN);
> --
> 2.26.0
>

Thanks,

Reviewed-by: Dmitry Osipenko <[email protected]>

2020-04-05 06:01:57

by Markus Elfring

Subject: Re: PM / devfreq: tegra30: Delete an error message in tegra_devfreq_probe()

> Reviewed-by: Dmitry Osipenko <[email protected]>

Thanks for your positive feedback.

Will the logging of error codes need any more clarification
around such function calls?

Regards,
Markus

2020-04-05 13:51:16

by Dmitry Osipenko

Subject: Re: PM / devfreq: tegra30: Delete an error message in tegra_devfreq_probe()

05.04.2020 09:00, Markus Elfring пишет:
>> Reviewed-by: Dmitry Osipenko <[email protected]>
>
> Thanks for your positive feedback.
>
> Will the logging of error codes need any more clarification
> around such function calls?

In general no, but it could be different for some (more complex) drivers.

2020-04-05 23:51:59

by Chanwoo Choi

Subject: Re: [PATCH] PM / devfreq: tegra30: Delete an error message in tegra_devfreq_probe()

On 4/5/20 3:45 AM, Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Sat, 4 Apr 2020 20:34:02 +0200
>
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/devfreq/tegra30-devfreq.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index 28b2c7ca416e..93e6f4b25b04 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -807,10 +807,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
> }
>
> err = platform_get_irq(pdev, 0);
> - if (err < 0) {
> - dev_err(&pdev->dev, "Failed to get IRQ: %d\n", err);
> + if (err < 0)
> return err;
> - }
> +
> tegra->irq = err;
>
> irq_set_status_flags(tegra->irq, IRQ_NOAUTOEN);
> --
> 2.26.0
>
>
>

Applied it. Thanks.

--
Best Regards,
Chanwoo Choi
Samsung Electronics