2024-03-23 16:09:51

by Alexandru Gagniuc

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: net: ipq4019-mdio: add IPQ9574 compatible

Add a compatible property specific to IPQ9574. This should be used
along with the IPQ4019 compatible. This second compatible serves the
same purpose as the ipq{5,6,8} compatibles. This is to indicate that
the clocks properties are required.

Signed-off-by: Alexandru Gagniuc <[email protected]>
---
Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
index 0029e197a825..a94480e819ac 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
@@ -20,6 +20,7 @@ properties:
- enum:
- qcom,ipq6018-mdio
- qcom,ipq8074-mdio
+ - qcom,ipq9574-mdio
- const: qcom,ipq4019-mdio

"#address-cells":
@@ -76,6 +77,7 @@ allOf:
- qcom,ipq5018-mdio
- qcom,ipq6018-mdio
- qcom,ipq8074-mdio
+ - qcom,ipq9574-mdio
then:
required:
- clocks
--
2.40.1



2024-03-23 16:10:59

by Alexandru Gagniuc

[permalink] [raw]
Subject: [PATCH 2/2] arm64: dts: qcom: ipq9574: add MDIO bus

The IPQ95xx uses an IPQ4019 compatible MDIO controller that is already
supported. Add a DT node to expose it.

Signed-off-by: Alexandru Gagniuc <[email protected]>
---
arch/arm64/boot/dts/qcom/ipq9574.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
index 7f2e5cbf3bbb..4ab9da9fffb6 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
@@ -232,6 +232,16 @@ rng: rng@e3000 {
clock-names = "core";
};

+ mdio: mdio@90000 {
+ compatible = "qcom,ipq9574-mdio", "qcom,ipq4019-mdio";
+ reg = <0x90000 0x64>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&gcc GCC_MDIO_AHB_CLK>;
+ clock-names = "gcc_mdio_ahb_clk";
+ status = "disabled";
+ };
+
qfprom: efuse@a4000 {
compatible = "qcom,ipq9574-qfprom", "qcom,qfprom";
reg = <0x000a4000 0x5a1>;
--
2.40.1


2024-03-23 19:00:00

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: net: ipq4019-mdio: add IPQ9574 compatible

On Sat, Mar 23, 2024 at 11:09:34AM -0500, Alexandru Gagniuc wrote:
> Add a compatible property specific to IPQ9574. This should be used
> along with the IPQ4019 compatible. This second compatible serves the
> same purpose as the ipq{5,6,8} compatibles. This is to indicate that
> the clocks properties are required.
>
> Signed-off-by: Alexandru Gagniuc <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Cheers,
Conor.

> ---
> Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
> index 0029e197a825..a94480e819ac 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
> @@ -20,6 +20,7 @@ properties:
> - enum:
> - qcom,ipq6018-mdio
> - qcom,ipq8074-mdio
> + - qcom,ipq9574-mdio
> - const: qcom,ipq4019-mdio
>
> "#address-cells":
> @@ -76,6 +77,7 @@ allOf:
> - qcom,ipq5018-mdio
> - qcom,ipq6018-mdio
> - qcom,ipq8074-mdio
> + - qcom,ipq9574-mdio
> then:
> required:
> - clocks
> --
> 2.40.1
>

Attachments:
(No filename) (1.36 kB)
 signature.asc (235.00 B)
 Download all attachments

2024-04-23 12:23:23

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq9574: add MDIO bus



On 3/23/24 17:09, Alexandru Gagniuc wrote:
> The IPQ95xx uses an IPQ4019 compatible MDIO controller that is already
> supported. Add a DT node to expose it.
>
> Signed-off-by: Alexandru Gagniuc <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/ipq9574.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index 7f2e5cbf3bbb..4ab9da9fffb6 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -232,6 +232,16 @@ rng: rng@e3000 {
> clock-names = "core";
> };
>
> + mdio: mdio@90000 {
> + compatible = "qcom,ipq9574-mdio", "qcom,ipq4019-mdio";
> + reg = <0x90000 0x64>;

Please pad the size part to 8 hex digits with leading zeroes

Konrad