2022-11-15 19:54:36

by Giulio Benetti

Subject: [PATCH v2 1/4] clk: imx: imxrt1050: fix IMXRT1050_CLK_LCDIF_APB offsets

Cc: Jesse Taube <[email protected]>
Signed-off-by: Giulio Benetti <[email protected]>
---
V1->V2:
* nothing done
---
drivers/clk/imx/clk-imxrt1050.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c
index 9539d35588ee..26108e9f7e67 100644
--- a/drivers/clk/imx/clk-imxrt1050.c
+++ b/drivers/clk/imx/clk-imxrt1050.c
@@ -140,7 +140,7 @@ static int imxrt1050_clocks_probe(struct platform_device *pdev)
hws[IMXRT1050_CLK_USDHC1] = imx_clk_hw_gate2("usdhc1", "usdhc1_podf", ccm_base + 0x80, 2);
hws[IMXRT1050_CLK_USDHC2] = imx_clk_hw_gate2("usdhc2", "usdhc2_podf", ccm_base + 0x80, 4);
hws[IMXRT1050_CLK_LPUART1] = imx_clk_hw_gate2("lpuart1", "lpuart_podf", ccm_base + 0x7c, 24);
- hws[IMXRT1050_CLK_LCDIF_APB] = imx_clk_hw_gate2("lcdif", "lcdif_podf", ccm_base + 0x74, 10);
+ hws[IMXRT1050_CLK_LCDIF_APB] = imx_clk_hw_gate2("lcdif", "lcdif_podf", ccm_base + 0x70, 28);
hws[IMXRT1050_CLK_DMA] = imx_clk_hw_gate("dma", "ipg", ccm_base + 0x7C, 6);
hws[IMXRT1050_CLK_DMA_MUX] = imx_clk_hw_gate("dmamux0", "ipg", ccm_base + 0x7C, 7);
imx_check_clk_hws(hws, IMXRT1050_CLK_END);
--
2.34.1

2022-11-15 19:57:03

by Giulio Benetti

Subject: [PATCH v2 4/4] ARM: dts: imx: prepend a 0 in the memory address to make it clear it's 32MB

Cc: Jesse Taube <[email protected]>
Signed-off-by: Giulio Benetti <[email protected]>
---
V1->V2:
* nothing done
---
arch/arm/boot/dts/imxrt1050-evk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imxrt1050-evk.dts b/arch/arm/boot/dts/imxrt1050-evk.dts
index 1d339f48899f..3de392d014fe 100644
--- a/arch/arm/boot/dts/imxrt1050-evk.dts
+++ b/arch/arm/boot/dts/imxrt1050-evk.dts
@@ -28,7 +28,7 @@ aliases {

memory@80000000 {
device_type = "memory";
- reg = <0x80000000 0x2000000>;
+ reg = <0x80000000 0x02000000>;
};

panel {
--
2.34.1

2022-11-15 21:46:25

by Jesse T

Subject: Re: [PATCH v2 4/4] ARM: dts: imx: prepend a 0 in the memory address to make it clear it's 32MB

On 11/15/22 14:32, Giulio Benetti wrote:
> Cc: Jesse Taube <[email protected]>
> Signed-off-by: Giulio Benetti <[email protected]>
Again I'm not sure if this is necessary but I think there should be a
commit description. Otherwise
Acked-by: Jesse Taube <[email protected]>
> ---
> V1->V2:
> * nothing done
> ---
> arch/arm/boot/dts/imxrt1050-evk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imxrt1050-evk.dts b/arch/arm/boot/dts/imxrt1050-evk.dts
> index 1d339f48899f..3de392d014fe 100644
> --- a/arch/arm/boot/dts/imxrt1050-evk.dts
> +++ b/arch/arm/boot/dts/imxrt1050-evk.dts
> @@ -28,7 +28,7 @@ aliases {
>
> memory@80000000 {
> device_type = "memory";
> - reg = <0x80000000 0x2000000>;
> + reg = <0x80000000 0x02000000>;
> };
>
> panel {

2022-11-21 20:21:54

by Abel Vesa

Subject: Re: [PATCH v2 1/4] clk: imx: imxrt1050: fix IMXRT1050_CLK_LCDIF_APB offsets

On 22-11-15 20:32:41, Giulio Benetti wrote:
> Cc: Jesse Taube <[email protected]>
> Signed-off-by: Giulio Benetti <[email protected]>

Missing commit message. Same for patch #2 and #4.

> ---
> V1->V2:
> * nothing done
> ---
> drivers/clk/imx/clk-imxrt1050.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c
> index 9539d35588ee..26108e9f7e67 100644
> --- a/drivers/clk/imx/clk-imxrt1050.c
> +++ b/drivers/clk/imx/clk-imxrt1050.c
> @@ -140,7 +140,7 @@ static int imxrt1050_clocks_probe(struct platform_device *pdev)
> hws[IMXRT1050_CLK_USDHC1] = imx_clk_hw_gate2("usdhc1", "usdhc1_podf", ccm_base + 0x80, 2);
> hws[IMXRT1050_CLK_USDHC2] = imx_clk_hw_gate2("usdhc2", "usdhc2_podf", ccm_base + 0x80, 4);
> hws[IMXRT1050_CLK_LPUART1] = imx_clk_hw_gate2("lpuart1", "lpuart_podf", ccm_base + 0x7c, 24);
> - hws[IMXRT1050_CLK_LCDIF_APB] = imx_clk_hw_gate2("lcdif", "lcdif_podf", ccm_base + 0x74, 10);
> + hws[IMXRT1050_CLK_LCDIF_APB] = imx_clk_hw_gate2("lcdif", "lcdif_podf", ccm_base + 0x70, 28);
> hws[IMXRT1050_CLK_DMA] = imx_clk_hw_gate("dma", "ipg", ccm_base + 0x7C, 6);
> hws[IMXRT1050_CLK_DMA_MUX] = imx_clk_hw_gate("dmamux0", "ipg", ccm_base + 0x7C, 7);
> imx_check_clk_hws(hws, IMXRT1050_CLK_END);
> --
> 2.34.1
>