2023-03-08 13:30:09

by Hans de Goede

[permalink] [raw]
Subject: Re: [PATCH] staging: r8188eu: delete driver

Hi All,

> Now that the same hardware that the r8188eu driver supported is
> supported by the real wireless driver rtl8xxxu, the r8188eu driver can
> be deleted.
>
> Also the rtl8xxxu driver supports way more devices, and is a fraction of
> the overall size, making this a much better overall solution.
>
> Thanks to the r8188eu developers and maintainers and reviewers over the
> years, your work allowed Linux users to use their hardware before the
> real driver was implemented properly.
>
> Reported-by: Hans de Goede <[email protected]>
> Cc: Martin Kaiser <[email protected]>
> Cc: Larry Finger <[email protected]>
> Cc: Phillip Potter <[email protected]>
> Cc: Pavel Skripkin <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>

Thank you for doing this, I agree that this is the best solution
moving forward:

Acked-by: Hans de Goede <[email protected]>

Regards,

Hans



2023-03-08 13:45:54

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging: r8188eu: delete driver

On Wed, Mar 08, 2023 at 02:26:39PM +0100, Hans de Goede wrote:
> Hi All,
>
> > Now that the same hardware that the r8188eu driver supported is
> > supported by the real wireless driver rtl8xxxu, the r8188eu driver can
> > be deleted.
> >
> > Also the rtl8xxxu driver supports way more devices, and is a fraction of
> > the overall size, making this a much better overall solution.
> >
> > Thanks to the r8188eu developers and maintainers and reviewers over the
> > years, your work allowed Linux users to use their hardware before the
> > real driver was implemented properly.
> >
> > Reported-by: Hans de Goede <[email protected]>
> > Cc: Martin Kaiser <[email protected]>
> > Cc: Larry Finger <[email protected]>
> > Cc: Phillip Potter <[email protected]>
> > Cc: Pavel Skripkin <[email protected]>
> > Signed-off-by: Greg Kroah-Hartman <[email protected]>
>
> Thank you for doing this, I agree that this is the best solution
> moving forward:
>
> Acked-by: Hans de Goede <[email protected]>

Great!

Also, to verify the "these devices are supported", I compared the list
of module aliases exported by both drivers. The r8188eu is a tiny
subset of the rtl8xxxu driver, with no devices listed in the r8188eu
that are not in the rtl8xxxu driver.

Attached are the lists of the vendor/product USB ids for each driver as
proof.

thanks,

greg k-h


Attachments:
(No filename) (1.34 kB)
r8188eu.devices (165.00 B)
rtl8xxxu.devices (1.05 kB)
Download all attachments