2023-03-13 15:42:58

by Joel Selvaraj

Subject: [PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: add notification LED

The Poco F1 has a single color white notification LED. Enable the
Qualcomm Light Pulse Generator (LPG) driver based notification LED.

Signed-off-by: Joel Selvaraj <[email protected]>
---
Changes in v2: (No functional changes)
- Fixed the inconsistency in the commit title prefix
- Minor update to commit message.

.../boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
index e0fda4d754fe..9d11502e5e0e 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
@@ -2,6 +2,7 @@

/dts-v1/;

+#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
#include <dt-bindings/sound/qcom,q6afe.h>
@@ -322,6 +323,16 @@ vol_up_pin_a: vol-up-active-state {
};
};

+&pmi8998_lpg {
+ status = "okay";
+
+ led@5 {
+ reg = <5>;
+ color = <LED_COLOR_ID_WHITE>;
+ function = LED_FUNCTION_STATUS;
+ };
+};
+
&pmi8998_wled {
status = "okay";
qcom,current-boost-limit = <970>;
--
2.39.2

2023-03-13 15:45:32

by Konrad Dybcio

Subject: Re: [PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: add notification LED

On 13.03.2023 16:42, Joel Selvaraj wrote:
> The Poco F1 has a single color white notification LED. Enable the
> Qualcomm Light Pulse Generator (LPG) driver based notification LED.
>
> Signed-off-by: Joel Selvaraj <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> Changes in v2: (No functional changes)
> - Fixed the inconsistency in the commit title prefix
> - Minor update to commit message.
>
> .../boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> index e0fda4d754fe..9d11502e5e0e 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> @@ -2,6 +2,7 @@
>
> /dts-v1/;
>
> +#include <dt-bindings/leds/common.h>
> #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> #include <dt-bindings/sound/qcom,q6afe.h>
> @@ -322,6 +323,16 @@ vol_up_pin_a: vol-up-active-state {
> };
> };
>
> +&pmi8998_lpg {
> + status = "okay";
> +
> + led@5 {
> + reg = <5>;
> + color = <LED_COLOR_ID_WHITE>;
> + function = LED_FUNCTION_STATUS;
> + };
> +};
> +
> &pmi8998_wled {
> status = "okay";
> qcom,current-boost-limit = <970>;

2023-04-05 04:07:25

by Bjorn Andersson

Subject: Re: [PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: add notification LED

On Mon, 13 Mar 2023 10:42:26 -0500, Joel Selvaraj wrote:
> The Poco F1 has a single color white notification LED. Enable the
> Qualcomm Light Pulse Generator (LPG) driver based notification LED.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: sdm845-xiaomi-beryllium: add notification LED
commit: d20ad168b7d024d8cbe6b54e9c029537aa412576

Best regards,
--
Bjorn Andersson <[email protected]>