2022-04-16 01:41:23

by Larry Finger

[permalink] [raw]
Subject: Re: [PATCH 0/7] staging: r8188eu: fix and clean up some firmware code

On 4/14/22 03:38, Michael Straube wrote:
> This series fixes wrong size of struct rt_firmware_hdr in the first
> patch and does some cleanups in rtl8188e_firmware_download() in the
> other patches.
>
> Tested on x86_64 with Inter-Tech DMG-02.
>
> Michael Straube (7):
> staging: r8188eu: fix struct rt_firmware_hdr
> staging: r8188eu: clean up comments in struct rt_firmware_hdr
> staging: r8188eu: rename fields of struct rt_firmware_hdr
> staging: r8188eu: use sizeof instead of hardcoded firmware header size
> staging: r8188eu: remove variables from rtl8188e_firmware_download()
> staging: r8188eu: always log firmware info
> staging: r8188eu: check firmware header existence before access

Acked-by: Larry Finger <[email protected]> for 2/7 through 5/7. Patch
1/7 has a typo in the commit message, and I have objection to the logging
changes in 6/7 and 7/7.

Larry