2010-11-29 00:42:16

by Thiago Farina

[permalink] [raw]
Subject: [PATCH] apic/io_apic.c: Remove unused variable 'desc'.

This fix the following warning:

arch/x86/kernel/apic/io_apic.c: In function ‘ack_apic_level’:
arch/x86/kernel/apic/io_apic.c:2433: warning: unused variable ‘desc’

Signed-off-by: Thiago Farina <[email protected]>
---
arch/x86/kernel/apic/io_apic.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 7cc0a72..31c493d 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -2430,7 +2430,6 @@ static void ack_apic_level(struct irq_data *data)
{
struct irq_cfg *cfg = data->chip_data;
int i, do_unmask_irq = 0, irq = data->irq;
- struct irq_desc *desc = irq_to_desc(irq);
unsigned long v;

irq_complete_move(cfg);
--
1.7.3.2.343.g7d43d


2010-11-29 00:58:33

by Thiago Farina

[permalink] [raw]
Subject: Re: [PATCH] apic/io_apic.c: Remove unused variable 'desc'.

On Sun, Nov 28, 2010 at 10:42 PM, Thiago Farina <[email protected]> wrote:
> This fix the following warning:
>
> arch/x86/kernel/apic/io_apic.c: In function ‘ack_apic_level’:
> arch/x86/kernel/apic/io_apic.c:2433: warning: unused variable ‘desc’
>
> Signed-off-by: Thiago Farina <[email protected]>
> ---
>  arch/x86/kernel/apic/io_apic.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 7cc0a72..31c493d 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -2430,7 +2430,6 @@ static void ack_apic_level(struct irq_data *data)
>  {
>        struct irq_cfg *cfg = data->chip_data;
>        int i, do_unmask_irq = 0, irq = data->irq;
> -       struct irq_desc *desc = irq_to_desc(irq);
>        unsigned long v;
>
>        irq_complete_move(cfg);
> --
> 1.7.3.2.343.g7d43d
>
>

Please, disregard this. This variable is used in the #ifdef
CONFIG_GENERIC_PENDING_IRQ. Sorry for the noise.