2017-09-07 21:17:30

by Tristram.Ha

[permalink] [raw]
Subject: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile

From: Tristram Ha <[email protected]>

Add KSZ8795 switch support with SPI access.

Signed-off-by: Tristram Ha <[email protected]>
---
diff --git a/drivers/net/dsa/microchip/Makefile b/drivers/net/dsa/microchip/Makefile
index 0961c30..0d8ba48 100644
--- a/drivers/net/dsa/microchip/Makefile
+++ b/drivers/net/dsa/microchip/Makefile
@@ -1,2 +1,4 @@
obj-$(CONFIG_MICROCHIP_KSZ) += ksz9477.o ksz_common.o
obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER) += ksz_spi.o
+obj-$(CONFIG_MICROCHIP_KSZ8795) += ksz8795.o ksz_common.o
+obj-$(CONFIG_MICROCHIP_KSZ8795_SPI_DRIVER) += ksz8795_spi.o


2017-09-07 21:55:54

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile

On Thu, Sep 07, 2017 at 09:17:10PM +0000, [email protected] wrote:
> From: Tristram Ha <[email protected]>
>
> Add KSZ8795 switch support with SPI access.
>
> Signed-off-by: Tristram Ha <[email protected]>
> ---
> diff --git a/drivers/net/dsa/microchip/Makefile b/drivers/net/dsa/microchip/Makefile
> index 0961c30..0d8ba48 100644
> --- a/drivers/net/dsa/microchip/Makefile
> +++ b/drivers/net/dsa/microchip/Makefile
> @@ -1,2 +1,4 @@
> obj-$(CONFIG_MICROCHIP_KSZ) += ksz9477.o ksz_common.o
> obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER) += ksz_spi.o
> +obj-$(CONFIG_MICROCHIP_KSZ8795) += ksz8795.o ksz_common.o
> +obj-$(CONFIG_MICROCHIP_KSZ8795_SPI_DRIVER) += ksz8795_spi.o

I've not tried it, but i think this breaks the build

Andrew

2017-09-07 22:30:22

by Tristram.Ha

[permalink] [raw]
Subject: RE: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile

> -----Original Message-----
> From: Andrew Lunn [mailto:[email protected]]
> Sent: Thursday, September 07, 2017 2:56 PM
> To: Tristram Ha - C24268
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; Woojung Huh - C21699
> Subject: Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile
>
> On Thu, Sep 07, 2017 at 09:17:10PM +0000, [email protected] wrote:
> > From: Tristram Ha <[email protected]>
> >
> > Add KSZ8795 switch support with SPI access.
> >
> > Signed-off-by: Tristram Ha <[email protected]>
> > ---
> > diff --git a/drivers/net/dsa/microchip/Makefile
> b/drivers/net/dsa/microchip/Makefile
> > index 0961c30..0d8ba48 100644
> > --- a/drivers/net/dsa/microchip/Makefile
> > +++ b/drivers/net/dsa/microchip/Makefile
> > @@ -1,2 +1,4 @@
> > obj-$(CONFIG_MICROCHIP_KSZ) += ksz9477.o ksz_common.o
> > obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER) += ksz_spi.o
> > +obj-$(CONFIG_MICROCHIP_KSZ8795) += ksz8795.o ksz_common.o
> > +obj-$(CONFIG_MICROCHIP_KSZ8795_SPI_DRIVER) += ksz8795_spi.o
>
> I've not tried it, but i think this breaks the build
>
> Andrew

So you would like to have all 5 patches in 1 patch file?

2017-09-07 22:43:12

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile

On Thu, Sep 07, 2017 at 10:29:34PM +0000, [email protected] wrote:
> > -----Original Message-----
> > From: Andrew Lunn [mailto:[email protected]]
> > Sent: Thursday, September 07, 2017 2:56 PM
> > To: Tristram Ha - C24268
> > Cc: [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected];
> > [email protected]; [email protected]; Woojung Huh - C21699
> > Subject: Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile
> >
> > On Thu, Sep 07, 2017 at 09:17:10PM +0000, [email protected] wrote:
> > > From: Tristram Ha <[email protected]>
> > >
> > > Add KSZ8795 switch support with SPI access.
> > >
> > > Signed-off-by: Tristram Ha <[email protected]>
> > > ---
> > > diff --git a/drivers/net/dsa/microchip/Makefile
> > b/drivers/net/dsa/microchip/Makefile
> > > index 0961c30..0d8ba48 100644
> > > --- a/drivers/net/dsa/microchip/Makefile
> > > +++ b/drivers/net/dsa/microchip/Makefile
> > > @@ -1,2 +1,4 @@
> > > obj-$(CONFIG_MICROCHIP_KSZ) += ksz9477.o ksz_common.o
> > > obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER) += ksz_spi.o
> > > +obj-$(CONFIG_MICROCHIP_KSZ8795) += ksz8795.o ksz_common.o
> > > +obj-$(CONFIG_MICROCHIP_KSZ8795_SPI_DRIVER) += ksz8795_spi.o
> >
> > I've not tried it, but i think this breaks the build
> >
> > Andrew
>
> So you would like to have all 5 patches in 1 patch file?

Or maybe this one last? Would that stop the build from breaking?

Andrew

2017-09-08 09:06:34

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile

On Fri 2017-09-08 00:43:09, Andrew Lunn wrote:
> On Thu, Sep 07, 2017 at 10:29:34PM +0000, [email protected] wrote:
> > > -----Original Message-----
> > > From: Andrew Lunn [mailto:[email protected]]
> > > Sent: Thursday, September 07, 2017 2:56 PM
> > > To: Tristram Ha - C24268
> > > Cc: [email protected]; [email protected]; [email protected];
> > > [email protected]; [email protected];
> > > [email protected]; [email protected]; Woojung Huh - C21699
> > > Subject: Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile
> > >
> > > On Thu, Sep 07, 2017 at 09:17:10PM +0000, [email protected] wrote:
> > > > From: Tristram Ha <[email protected]>
> > > >
> > > > Add KSZ8795 switch support with SPI access.
> > > >
> > > > Signed-off-by: Tristram Ha <[email protected]>
> > > > ---
> > > > diff --git a/drivers/net/dsa/microchip/Makefile
> > > b/drivers/net/dsa/microchip/Makefile
> > > > index 0961c30..0d8ba48 100644
> > > > --- a/drivers/net/dsa/microchip/Makefile
> > > > +++ b/drivers/net/dsa/microchip/Makefile
> > > > @@ -1,2 +1,4 @@
> > > > obj-$(CONFIG_MICROCHIP_KSZ) += ksz9477.o ksz_common.o
> > > > obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER) += ksz_spi.o
> > > > +obj-$(CONFIG_MICROCHIP_KSZ8795) += ksz8795.o ksz_common.o
> > > > +obj-$(CONFIG_MICROCHIP_KSZ8795_SPI_DRIVER) += ksz8795_spi.o
> > >
> > > I've not tried it, but i think this breaks the build
> > >
> > > Andrew
> >
> > So you would like to have all 5 patches in 1 patch file?
>
> Or maybe this one last? Would that stop the build from breaking?

This and Kconfig change should come together.. and probably last.
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


Attachments:
(No filename) (1.81 kB)
signature.asc (181.00 B)
Digital signature
Download all attachments