2019-06-18 06:43:23

by Jon Hunter

Subject: Re: [PATCH V1] i2c: tegra: disable irq in tegra_i2c_xfer_msg

On 18/06/2019 06:23, Bitan Biswas wrote:
> Synchronize ISR and tegra_i2c_xfer_msg execution
> by disabling interrupt. This avoids spinlock usage
> for same purpose.

I think that you need to explain the motivation/benefit of this. It is
not immediately clear to me. Sorry if I have missed some previous
discussion.

Jon

--
nvpublic

2019-06-18 08:54:01

by Bitan Biswas

Subject: Re: [PATCH V1] i2c: tegra: disable irq in tegra_i2c_xfer_msg

On 6/17/19 11:32 PM, Jon Hunter wrote:
>
> On 18/06/2019 06:23, Bitan Biswas wrote:
>> Synchronize ISR and tegra_i2c_xfer_msg execution
>> by disabling interrupt. This avoids spinlock usage
>> for same purpose.
>
> I think that you need to explain the motivation/benefit of this. It is
> not immediately clear to me. Sorry if I have missed some previous
> discussion.
I updated the commit description with details and benefit. Please review
Patch V2.

-regards,
Bitan