2023-10-16 15:56:20

by Rob Herring (Arm)

[permalink] [raw]
Subject: [PATCH] dt-bindings: ata: tegra: Disallow undefined properties

Device specific bindings should not allow undefined properties. This is
accomplished in json-schema with 'additionalProperties: false'.

Signed-off-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
index 3c7a2425f3e6..a17297cbefcb 100644
--- a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
+++ b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
@@ -151,7 +151,7 @@ allOf:
- interconnects
- power-domains

-additionalProperties: true
+additionalProperties: false

examples:
- |
--
2.42.0


2023-10-17 10:51:18

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: ata: tegra: Disallow undefined properties

On Mon, Oct 16, 2023 at 10:55:54AM -0500, Rob Herring wrote:
> Device specific bindings should not allow undefined properties. This is
> accomplished in json-schema with 'additionalProperties: false'.
>
> Signed-off-by: Rob Herring <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Thanks,
Conor.

> ---
> Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
> index 3c7a2425f3e6..a17297cbefcb 100644
> --- a/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
> +++ b/Documentation/devicetree/bindings/ata/nvidia,tegra-ahci.yaml
> @@ -151,7 +151,7 @@ allOf:
> - interconnects
> - power-domains
>
> -additionalProperties: true
> +additionalProperties: false
>
> examples:
> - |
> --
> 2.42.0
>
>

Attachments:
(No filename) (996.00 B)
 signature.asc (235.00 B)
 Download all attachments

2023-10-17 23:09:01

by Damien Le Moal

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: ata: tegra: Disallow undefined properties

On 10/17/23 00:55, Rob Herring wrote:
> Device specific bindings should not allow undefined properties. This is
> accomplished in json-schema with 'additionalProperties: false'.
>
> Signed-off-by: Rob Herring <[email protected]>

Applied to for-6.7. Thanks !

--
Damien Le Moal
Western Digital Research