2022-11-19 02:28:53

by Dmitry Torokhov

[permalink] [raw]
Subject: [git pull] Input updates for v6.1-rc5

Hi Linus,

Please pull from:

git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git tags/input-for-v6.1-rc5

to receive updates for the input subsystem. You will get:

- a fix for 8042 to stop leaking platform device on unload
- a fix for Goodix touchscreens on devices like Nanote UMPC-01 where we
need to reset controller to load config from firmware
- a workaround for Acer Switch to avoid interrupt storm from home and
power buttons
- a workaround for more ASUS ZenBook models to detect keyboard cnotroller
- a fix for iforce driver to properly handle communication errors
- touchpad on HP Laptop 15-da3001TU switched to RMI mode

Changelog:
---------

Aman Dhoot (1):
Input: synaptics - switch touchpad on HP Laptop 15-da3001TU to RMI mode

Chen Jun (1):
Input: i8042 - fix leaking of platform device on module removal

Hans de Goede (3):
Input: goodix - try resetting the controller when no config is set
Input: soc_button_array - add use_low_level_irq module parameter
Input: soc_button_array - add Acer Switch V 10 to dmi_use_low_level_irq[]

Sheng-Liang Pan (1):
dt-bindings: input: touchscreen: Add compatible for Goodix GT7986U chip

Takashi Iwai (1):
Input: i8042 - apply probe defer to more ASUS ZenBook models

Tetsuo Handa (1):
Input: iforce - invert valid length check when fetching device IDs

Diffstat:
--------

.../devicetree/bindings/input/goodix,gt7375p.yaml | 5 ++++-
drivers/input/joystick/iforce/iforce-main.c | 8 ++++----
drivers/input/misc/soc_button_array.c | 14 +++++++++++++-
drivers/input/mouse/synaptics.c | 1 +
drivers/input/serio/i8042-acpipnpio.h | 8 ++++----
drivers/input/serio/i8042.c | 4 ----
drivers/input/touchscreen/goodix.c | 11 +++++++++++
7 files changed, 37 insertions(+), 14 deletions(-)

Thanks.


--
Dmitry


2022-12-13 11:52:16

by Jiri Slaby

[permalink] [raw]
Subject: Re: [git pull] Input updates for v6.1-rc5

Hi,

On 19. 11. 22, 2:26, Dmitry Torokhov wrote:
> to receive updates for the input subsystem. You will get:
>
> - a fix for 8042 to stop leaking platform device on unload
> - a fix for Goodix touchscreens on devices like Nanote UMPC-01 where we
> need to reset controller to load config from firmware
> - a workaround for Acer Switch to avoid interrupt storm from home and
> power buttons
> - a workaround for more ASUS ZenBook models to detect keyboard cnotroller
> - a fix for iforce driver to properly handle communication errors
> - touchpad on HP Laptop 15-da3001TU switched to RMI mode
>
> Changelog:
> ---------
>
> Aman Dhoot (1):
> Input: synaptics - switch touchpad on HP Laptop 15-da3001TU to RMI mode

This appears to break keyboard on HP's 15-da1xxx which appears to have
the same ID: SYN3286. This happens on 6.0.12.

synaptics excerpt from dmesg:
psmouse serio1: synaptics: Trying to set up SMBus access
psmouse serio1: synaptics: SMbus companion is not ready yet
...
psmouse serio1: synaptics: queried max coordinates: x [..5648], y [..4826]
psmouse serio1: synaptics: queried min coordinates: x [1292..], y [1026..]
psmouse serio1: synaptics: Trying to set up SMBus access
rmi4_smbus 6-002c: registering SMbus-connected sensor
rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics,
product: TM3320-003, fw id: 2659795
input: Synaptics TM3320-003 as
/devices/pci0000:00/0000:00:1f.4/i2c-6/6-002c/rmi4-00/input/input21




This was reported downstream as a regression between 6.0.10 and 6.0.12:
https://bugzilla.suse.com/show_bug.cgi?id=1206358

Full dmesgs available there too.


6.0.10 has this instead of the above:
psmouse serio1: synaptics: queried max coordinates: x [..5648], y [..4826]
psmouse serio1: synaptics: queried min coordinates: x [1292..], y [1026..]
psmouse serio1: synaptics: Your touchpad (PNP: SYN3286 PNP0f13) says it
can support a different bus. If i2c-hid and hid-rmi are not used, you
might want to try setting psmouse.synaptics_intertouch to 1 and report
this to [email protected].
psmouse serio1: synaptics: Touchpad model: 1, fw: 8.16, id: 0x1e2b1,
caps: 0xf00323/0x840300/0x2e800/0x400000, board id: 3320, fw id: 2659795



thanks,
--
js
suse labs

2022-12-15 08:07:52

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: [git pull] Input updates for v6.1-rc5

Hi, this is your Linux kernel regression tracker.

On 13.12.22 12:41, Jiri Slaby wrote:
> On 19. 11. 22, 2:26, Dmitry Torokhov wrote:
>> to receive updates for the input subsystem. You will get:
>>
>> - a fix for 8042 to stop leaking platform device on unload
>> - a fix for Goodix touchscreens on devices like Nanote UMPC-01 where we
>>    need to reset controller to load config from firmware
>> - a workaround for Acer Switch to avoid interrupt storm from home and
>>    power buttons
>> - a workaround for more ASUS ZenBook models to detect keyboard cnotroller
>> - a fix for iforce driver to properly handle communication errors
>> - touchpad on HP Laptop 15-da3001TU switched to RMI mode
>>
>> Changelog:
>> ---------
>>
>> Aman Dhoot (1):
>>        Input: synaptics - switch touchpad on HP Laptop 15-da3001TU to
>> RMI mode
>
> This appears to break keyboard on HP's 15-da1xxx which appears to have
> the same ID: SYN3286. This happens on 6.0.12.

Thx for forwarding that report. CCing Aman, who authored that commit
(ac5408991ea6 in mainline, but it was backported to many stable kernels,
too)

Aman, could you look at this? If there is no easy fix in sight I wonder
if it might be the best to revert this soonish, so that Greg can pick up
that revert to stable quickly afterwards.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.

> synaptics excerpt from dmesg:
> psmouse serio1: synaptics: Trying to set up SMBus access
> psmouse serio1: synaptics: SMbus companion is not ready yet
> ...
> psmouse serio1: synaptics: queried max coordinates: x [..5648], y [..4826]
> psmouse serio1: synaptics: queried min coordinates: x [1292..], y [1026..]
> psmouse serio1: synaptics: Trying to set up SMBus access
> rmi4_smbus 6-002c: registering SMbus-connected sensor
> rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics,
> product: TM3320-003, fw id: 2659795
> input: Synaptics TM3320-003 as
> /devices/pci0000:00/0000:00:1f.4/i2c-6/6-002c/rmi4-00/input/input21
>
> This was reported downstream as a regression between 6.0.10 and 6.0.12:
> https://bugzilla.suse.com/show_bug.cgi?id=1206358
>
> Full dmesgs available there too.
>
>
> 6.0.10 has this instead of the above:
> psmouse serio1: synaptics: queried max coordinates: x [..5648], y [..4826]
> psmouse serio1: synaptics: queried min coordinates: x [1292..], y [1026..]
> psmouse serio1: synaptics: Your touchpad (PNP: SYN3286 PNP0f13) says it
> can support a different bus. If i2c-hid and hid-rmi are not used, you
> might want to try setting psmouse.synaptics_intertouch to 1 and report
> this to [email protected].
> psmouse serio1: synaptics: Touchpad model: 1, fw: 8.16, id: 0x1e2b1,
> caps: 0xf00323/0x840300/0x2e800/0x400000, board id: 3320, fw id: 2659795

P.P.S.: I for now assume that it's a problem that also is present in
mainline and thus will track it as such.

#regzbot introduced ac5408991ea6
https://bugzilla.suse.com/show_bug.cgi?id=1206358
#regzbot title input: synaptics: keyboard broken on HP's 15-da1xxx
#regzbot ignore-activity

2022-12-20 10:36:12

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: [git pull] Input updates for v6.1-rc5 #forregzbot

[Note: this mail contains only information for Linux kernel regression
tracking. Mails like these contain '#forregzbot' in the subject to make
then easy to spot and filter out. The author also tried to remove most
or all individuals from the list of recipients to spare them the hassle.]

On 15.12.22 08:39, Thorsten Leemhuis wrote:

>> This was reported downstream as a regression between 6.0.10 and 6.0.12:
>> https://bugzilla.suse.com/show_bug.cgi?id=1206358
>>
>> Full dmesgs available there too.
>>
>>
>> 6.0.10 has this instead of the above:
>> psmouse serio1: synaptics: queried max coordinates: x [..5648], y [..4826]
>> psmouse serio1: synaptics: queried min coordinates: x [1292..], y [1026..]
>> psmouse serio1: synaptics: Your touchpad (PNP: SYN3286 PNP0f13) says it
>> can support a different bus. If i2c-hid and hid-rmi are not used, you
>> might want to try setting psmouse.synaptics_intertouch to 1 and report
>> this to [email protected].
>> psmouse serio1: synaptics: Touchpad model: 1, fw: 8.16, id: 0x1e2b1,
>> caps: 0xf00323/0x840300/0x2e800/0x400000, board id: 3320, fw id: 2659795
>
> P.P.S.: I for now assume that it's a problem that also is present in
> mainline and thus will track it as such.
>
> #regzbot introduced ac5408991ea6
> https://bugzilla.suse.com/show_bug.cgi?id=1206358
> #regzbot title input: synaptics: keyboard broken on HP's 15-da1xxx
> #regzbot ignore-activity


#regzbot fix: Revert "Input: synaptics - switch touchpad on HP Laptop
15-da3001TU to RMI mode"

2022-12-24 08:17:49

by Aman Dhoot

[permalink] [raw]
Subject: Re: [git pull] Input updates for v6.1-rc5 #forregzbot

If I use synaptics touchpad in legacy PS/2 mode.keyboard and touchpad
stop working randomly because of TLP, if I uninstall tlp it resolves
the keyboard touchpad stops working randomly issue. But I see good
battery life in my system using tlp by switching touchpad from legacy
PS/2 mode to RMI mode resolves the problem. this way i can use tlp and
keyboard touchpad works without any problem.

In my dmesg log I don't have msg "psmouse serio1: synaptics: SMbus
companion is not ready yet".

2022-12-24 08:41:18

by Aman Dhoot

[permalink] [raw]
Subject: Re: [git pull] Input updates for v6.1-rc5 #forregzbot

I also attached my dmesg log file for reference.


Attachments:
dmesglog.txt (65.38 kB)

2022-12-24 08:59:54

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: [git pull] Input updates for v6.1-rc5

[CCing Dmitry]

Hi, this is your Linux kernel regression tracker.

On 24.12.22 08:49, Aman Dhoot wrote:
> If I use synaptics touchpad in legacy PS/2 mode.keyboard and touchpad
> stop working randomly because of TLP, if I uninstall tlp it resolves
> the keyboard touchpad stops working randomly issue. But I see good
> battery life in my system using tlp by switching touchpad from legacy
> PS/2 mode to RMI mode resolves the problem. this way i can use tlp and
> keyboard touchpad works without any problem.
>
> In my dmesg log I don't have msg "psmouse serio1: synaptics: SMbus
> companion is not ready yet".

Well, if I got this right the situation is like this: your change
ac5408991ea6 ("Input: synaptics - switch touchpad on HP Laptop
15-da3001TU to RMI mode") breaks things for some users and hence will be
reverted per the "no regressions rule" (
https://docs.kernel.org/process/handling-regressions.html ).

To get this reapplied someone needs to work with those people that are
affected by the regression to ensure this continue working if the
touchpad is in RMI mode (maybe it depends on the BIOS, the revsition,
the kernel config, or something else). IOW: a better change is needed
that doesn't break things for others. If that's not possible maybe there
is some other solution for you. Is there maybe a kernel parameter you
can apply to switch the device to RMI mode on your machine?

HTH, Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker'
hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.

2023-01-27 12:49:41

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: [git pull] Input updates for v6.1-rc5

On 13.12.22 12:41, Jiri Slaby wrote:
> On 19. 11. 22, 2:26, Dmitry Torokhov wrote:
>> to receive updates for the input subsystem. You will get:
>>
>> - a fix for 8042 to stop leaking platform device on unload
>> - a fix for Goodix touchscreens on devices like Nanote UMPC-01 where we
>>    need to reset controller to load config from firmware
>> - a workaround for Acer Switch to avoid interrupt storm from home and
>>    power buttons
>> - a workaround for more ASUS ZenBook models to detect keyboard cnotroller
>> - a fix for iforce driver to properly handle communication errors
>> - touchpad on HP Laptop 15-da3001TU switched to RMI mode
>>
>> Changelog:
>> ---------
>>
>> Aman Dhoot (1):
>>        Input: synaptics - switch touchpad on HP Laptop 15-da3001TU to
>> RMI mode
>
> This appears to break keyboard on HP's 15-da1xxx which appears to have
> the same ID: SYN3286. This happens on 6.0.12.

Dmitry, Jiri's report afaics made you quickly apply a revert that since
round about mid December is in -next:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=master&id=3c44e2b6cde674797b76e76d3a903a63ce8a18bb

But it looks like it never made it to mainline (or am I missing
something here? it feels like I do... anyway, moving on.). Was that
intentional or did that simply fall through the cracks due to the
festive season?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

#regzbot poke

> synaptics excerpt from dmesg:
> psmouse serio1: synaptics: Trying to set up SMBus access
> psmouse serio1: synaptics: SMbus companion is not ready yet
> ...
> psmouse serio1: synaptics: queried max coordinates: x [..5648], y [..4826]
> psmouse serio1: synaptics: queried min coordinates: x [1292..], y [1026..]
> psmouse serio1: synaptics: Trying to set up SMBus access
> rmi4_smbus 6-002c: registering SMbus-connected sensor
> rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics,
> product: TM3320-003, fw id: 2659795
> input: Synaptics TM3320-003 as
> /devices/pci0000:00/0000:00:1f.4/i2c-6/6-002c/rmi4-00/input/input21
>
>
>
>
> This was reported downstream as a regression between 6.0.10 and 6.0.12:
> https://bugzilla.suse.com/show_bug.cgi?id=1206358
>
> Full dmesgs available there too.
>
>
> 6.0.10 has this instead of the above:
> psmouse serio1: synaptics: queried max coordinates: x [..5648], y [..4826]
> psmouse serio1: synaptics: queried min coordinates: x [1292..], y [1026..]
> psmouse serio1: synaptics: Your touchpad (PNP: SYN3286 PNP0f13) says it
> can support a different bus. If i2c-hid and hid-rmi are not used, you
> might want to try setting psmouse.synaptics_intertouch to 1 and report
> this to [email protected].
> psmouse serio1: synaptics: Touchpad model: 1, fw: 8.16, id: 0x1e2b1,
> caps: 0xf00323/0x840300/0x2e800/0x400000, board id: 3320, fw id: 2659795
>
>
>
> thanks,